From 28afbcd45ac9bf1dd281869da9adcdc25d1a9350 Mon Sep 17 00:00:00 2001 From: Iain Billett Date: Wed, 13 Oct 2021 10:48:59 +0100 Subject: [PATCH] Revert "Set catalog table search field placeholder to "Filter"" This reverts commit c9940ec5c5d515888c7f5cd2ee14a3672f9f02ac. Signed-off-by: Iain Billett --- .changeset/healthy-poets-tap.md | 9 --------- .../catalog/src/components/CatalogTable/CatalogTable.tsx | 1 - 2 files changed, 10 deletions(-) delete mode 100644 .changeset/healthy-poets-tap.md diff --git a/.changeset/healthy-poets-tap.md b/.changeset/healthy-poets-tap.md deleted file mode 100644 index 31e03e7e09..0000000000 --- a/.changeset/healthy-poets-tap.md +++ /dev/null @@ -1,9 +0,0 @@ ---- -'@backstage/plugin-catalog': patch ---- - -Set the search field placeholder on the catalog table to "Filter" to differentiate it from the search feature - -We had feedback that users expected the catalog table search field to have more sophisticated behaviour -than simple filtering. This change better sets expectations by setting the placeholder to "Filter" to -differentiate it from components which are part of the search plugin. diff --git a/plugins/catalog/src/components/CatalogTable/CatalogTable.tsx b/plugins/catalog/src/components/CatalogTable/CatalogTable.tsx index 197937d6f7..f293710847 100644 --- a/plugins/catalog/src/components/CatalogTable/CatalogTable.tsx +++ b/plugins/catalog/src/components/CatalogTable/CatalogTable.tsx @@ -163,7 +163,6 @@ export const CatalogTable = ({ columns, actions }: CatalogTableProps) => { title={`${titlePreamble} (${entities.length})`} data={rows} actions={actions || defaultActions} - localization={{ toolbar: { searchPlaceholder: 'Filter' } }} /> ); };