Add documentation to cli-plugin-api and remove CliFeature type

Add thorough TSDoc comments to createCliPlugin, BackstageCommand,
CommandContext, and CliPlugin. Remove the CliFeature type alias in
favor of using CliPlugin directly.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Made-with: Cursor

packages/cli/src/wiring/CliInitializer.ts

@@ -16,7 +16,7 @@
 
 import { CommandGraph } from './CommandGraph';
 import { OpaqueCliPlugin } from '@internal/cli';
-import type { BackstageCommand, CliFeature } from '@backstage/cli-plugin-api';
+import type { BackstageCommand, CliPlugin } from '@backstage/cli-plugin-api';
 import { CommandRegistry } from './CommandRegistry';
 import { Command } from 'commander';
 import { version } from './version';
@@ -36,12 +36,12 @@ function isNodeHidden(
   return node.children.every(child => isNodeHidden(child as any));
 }
 
-type UninitializedFeature = CliFeature | Promise<{ default: CliFeature }>;
+type UninitializedFeature = CliPlugin | Promise<{ default: CliPlugin }>;
 
 export class CliInitializer {
   private graph = new CommandGraph();
   private commandRegistry = new CommandRegistry(this.graph);
-  #uninitiazedFeatures: Promise<CliFeature>[] = [];
+  #uninitiazedFeatures: Promise<CliPlugin>[] = [];
 
   add(feature: UninitializedFeature) {
     if (isPromise(feature)) {
@@ -53,7 +53,7 @@ export class CliInitializer {
     }
   }
 
-  async #register(feature: CliFeature) {
+  async #register(feature: CliPlugin) {
     if (OpaqueCliPlugin.isType(feature)) {
       const internal = OpaqueCliPlugin.toInternal(feature);
       for (const command of await internal.commands) {
@@ -180,8 +180,8 @@ export class CliInitializer {
 
 /** @internal */
 export function unwrapFeature(
-  feature: CliFeature | { default: CliFeature },
-): CliFeature {
+  feature: CliPlugin | { default: CliPlugin },
+): CliPlugin {
   if ('$$type' in feature) {
     return feature;
   }

packages/cli/src/wiring/types.ts

@@ -17,6 +17,5 @@
 export type {
   CommandContext,
   BackstageCommand,
-  CliFeature,
   CliPlugin,
 } from '@backstage/cli-plugin-api';