From 4bdd6bcb3c2cb1a87c2955862815d6e62c225373 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fredrik=20Adel=C3=B6w?= <freben@gmail.com>
Date: Tue, 14 Feb 2023 10:21:48 +0100
Subject: [PATCH] Prefer Link over plain anchors
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Fredrik Adelöw <freben@gmail.com>
---
 .changeset/tidy-kids-hide.md                     |  7 +++++++
 .../DagTableComponent/DagTableComponent.tsx      | 16 +++++++++-------
 .../AzureSitesOverviewTable.tsx                  |  5 ++---
 .../lighthouse/src/components/Intro/index.tsx    |  6 +++---
 4 files changed, 21 insertions(+), 13 deletions(-)
 create mode 100644 .changeset/tidy-kids-hide.md

diff --git a/.changeset/tidy-kids-hide.md b/.changeset/tidy-kids-hide.md
new file mode 100644
index 0000000000..194497d05c
--- /dev/null
+++ b/.changeset/tidy-kids-hide.md
@@ -0,0 +1,7 @@
+---
+'@backstage/plugin-apache-airflow': patch
+'@backstage/plugin-azure-sites': patch
+'@backstage/plugin-lighthouse': patch
+---
+
+Prefer Link over plain anchors
diff --git a/plugins/apache-airflow/src/components/DagTableComponent/DagTableComponent.tsx b/plugins/apache-airflow/src/components/DagTableComponent/DagTableComponent.tsx
index 2660e9380e..2cd136c7fa 100644
--- a/plugins/apache-airflow/src/components/DagTableComponent/DagTableComponent.tsx
+++ b/plugins/apache-airflow/src/components/DagTableComponent/DagTableComponent.tsx
@@ -15,6 +15,7 @@
  */
 
 import {
+  Link,
   Progress,
   StatusError,
   StatusOK,
@@ -144,13 +145,14 @@ export const DenseTable = ({ dags, rowClick }: DenseTableProps) => {
     {
       title: 'Link',
       field: 'dagUrl',
-      render: (row: Partial<DagTableRow>) => (
-        <a href={row.dagUrl}>
-          <IconButton aria-label="details">
-            <OpenInBrowserIcon />
-          </IconButton>
-        </a>
-      ),
+      render: (row: Partial<DagTableRow>) =>
+        !row.dagUrl ? null : (
+          <Link to={row.dagUrl}>
+            <IconButton aria-label="details">
+              <OpenInBrowserIcon />
+            </IconButton>
+          </Link>
+        ),
       width: '5%',
       disableClick: true,
       hidden: hiddenColumns.some(field => field === 'dagUrl'),
diff --git a/plugins/azure-sites/src/components/AzureSitesOverviewTableComponent/AzureSitesOverviewTable.tsx b/plugins/azure-sites/src/components/AzureSitesOverviewTableComponent/AzureSitesOverviewTable.tsx
index dc059b2f15..5b67fe844a 100644
--- a/plugins/azure-sites/src/components/AzureSitesOverviewTableComponent/AzureSitesOverviewTable.tsx
+++ b/plugins/azure-sites/src/components/AzureSitesOverviewTableComponent/AzureSitesOverviewTable.tsx
@@ -164,9 +164,8 @@ const ActionButtons = ({
           </MenuItem>
         )}
         <MenuItem
-          component="a"
-          href={value.logstreamHref}
-          target="_blank"
+          component={Link}
+          to={value.logstreamHref}
           key="logStream"
           onClick={handleClose}
         >
diff --git a/plugins/lighthouse/src/components/Intro/index.tsx b/plugins/lighthouse/src/components/Intro/index.tsx
index 57609476b8..519b0a3f21 100644
--- a/plugins/lighthouse/src/components/Intro/index.tsx
+++ b/plugins/lighthouse/src/components/Intro/index.tsx
@@ -22,6 +22,7 @@ import LighthouseSupportButton from '../SupportButton';
 import {
   ContentHeader,
   InfoCard,
+  Link,
   MarkdownContent,
 } from '@backstage/core-components';
 
@@ -108,10 +109,9 @@ function GettingStartedCard() {
           <Grid container direction="row" justifyContent="flex-end">
             <Grid item>
               <Button
-                component="a"
-                href="https://github.com/spotify/lighthouse-audit-service"
+                component={Link}
+                to="https://github.com/spotify/lighthouse-audit-service"
                 size="small"
-                target="_blank"
               >
                 Check out the README
               </Button>