diff --git a/packages/core-app-api/src/apis/system/ApiProvider.test.tsx b/packages/core-app-api/src/apis/system/ApiProvider.test.tsx
index 6460e12900..ceb3a0d12a 100644
--- a/packages/core-app-api/src/apis/system/ApiProvider.test.tsx
+++ b/packages/core-app-api/src/apis/system/ApiProvider.test.tsx
@@ -55,7 +55,7 @@ describe('ApiProvider', () => {
,
);
- renderedHoc.getByText('hoc message: hello');
+ expect(renderedHoc.getByText('hoc message: hello')).toBeInTheDocument();
});
it('should provide nested access to apis', () => {
@@ -84,7 +84,7 @@ describe('ApiProvider', () => {
,
);
- renderedHook.getByText('a=z b=y');
+ expect(renderedHook.getByText('a=z b=y')).toBeInTheDocument();
});
it('should ignore deps in prototype', () => {
@@ -107,7 +107,7 @@ describe('ApiProvider', () => {
,
);
- renderedHoc.getByText('hoc message: hello');
+ expect(renderedHoc.getByText('hoc message: hello')).toBeInTheDocument();
});
it('should error if no provider is available', () => {
@@ -229,6 +229,6 @@ describe('v1 consumer', () => {
,
);
- renderedHook.getByText('hook message: hello');
+ expect(renderedHook.getByText('hook message: hello')).toBeInTheDocument();
});
});
diff --git a/packages/core-components/src/components/CodeSnippet/CodeSnippet.test.tsx b/packages/core-components/src/components/CodeSnippet/CodeSnippet.test.tsx
index fec5b7ddf7..c0096e7ae9 100644
--- a/packages/core-components/src/components/CodeSnippet/CodeSnippet.test.tsx
+++ b/packages/core-components/src/components/CodeSnippet/CodeSnippet.test.tsx
@@ -34,8 +34,12 @@ describe('', () => {
// react-syntax-highlighter is large and can cause significant slowdowns
// This test makes sure we're loading things in asynchronously and not too broadly.
it('renders quickly', async () => {
+ const start = new Date();
await renderInTestApp();
- }, 1000);
+ const end = new Date();
+
+ expect(end.getTime() - start.getTime()).toBeLessThanOrEqual(1000);
+ }, 1500);
it('renders text without exploding', async () => {
const { getByText } = await renderInTestApp();
diff --git a/packages/core-components/src/components/FeatureDiscovery/FeatureCalloutCircular.test.tsx b/packages/core-components/src/components/FeatureDiscovery/FeatureCalloutCircular.test.tsx
index f72e33ac4b..b5106e1bf9 100644
--- a/packages/core-components/src/components/FeatureDiscovery/FeatureCalloutCircular.test.tsx
+++ b/packages/core-components/src/components/FeatureDiscovery/FeatureCalloutCircular.test.tsx
@@ -58,8 +58,8 @@ describe('', () => {
description="description"
/>,
);
- rendered.getByText('description');
- rendered.getByText('title');
+ expect(rendered.getByText('description')).toBeInTheDocument();
+ expect(rendered.getByText('title')).toBeInTheDocument();
});
it('renders with correct style', async () => {
diff --git a/packages/core-components/src/components/OverflowTooltip/OverflowTooltip.test.tsx b/packages/core-components/src/components/OverflowTooltip/OverflowTooltip.test.tsx
index 2fea7fa5e1..a65c758c28 100644
--- a/packages/core-components/src/components/OverflowTooltip/OverflowTooltip.test.tsx
+++ b/packages/core-components/src/components/OverflowTooltip/OverflowTooltip.test.tsx
@@ -20,10 +20,12 @@ import { OverflowTooltip } from './OverflowTooltip';
describe('', () => {
it('renders without exploding', async () => {
- render();
+ expect(
+ render(),
+ ).toBeTruthy();
});
it('renders without exploding when the text prop is missing', async () => {
- render();
+ expect(render()).toBeTruthy();
});
});
diff --git a/packages/core-components/src/components/ProgressBars/Gauge.test.tsx b/packages/core-components/src/components/ProgressBars/Gauge.test.tsx
index 2d92391a30..0c19d5acb2 100644
--- a/packages/core-components/src/components/ProgressBars/Gauge.test.tsx
+++ b/packages/core-components/src/components/ProgressBars/Gauge.test.tsx
@@ -24,34 +24,34 @@ describe('', () => {
const { getByText } = await renderInTestApp(
,
);
- getByText('10%');
+ expect(getByText('10%')).toBeInTheDocument();
});
it('handles fractional prop', async () => {
const { getByText } = await renderInTestApp(
,
);
- getByText('10%');
+ expect(getByText('10%')).toBeInTheDocument();
});
it('handles max prop', async () => {
const { getByText } = await renderInTestApp(
,
);
- getByText('1%');
+ expect(getByText('1%')).toBeInTheDocument();
});
it('handles unit prop', async () => {
const { getByText } = await renderInTestApp(
,
);
- getByText('10m');
+ expect(getByText('10m')).toBeInTheDocument();
});
it('handle relativeToMax prop', async () => {
const { getByText } = await renderInTestApp(
,
);
- getByText('7 pts');
+ expect(getByText('7 pts')).toBeInTheDocument();
});
it('handle decimalDigits prop', async () => {
@@ -65,7 +65,7 @@ describe('', () => {
unit="/10"
/>,
);
- getByText('5.50/10');
+ expect(getByText('5.50/10')).toBeInTheDocument();
});
const ok = '#111';
diff --git a/packages/core-components/src/layout/ContentHeader/ContentHeader.test.tsx b/packages/core-components/src/layout/ContentHeader/ContentHeader.test.tsx
index 5ae2efb806..8be54b9114 100644
--- a/packages/core-components/src/layout/ContentHeader/ContentHeader.test.tsx
+++ b/packages/core-components/src/layout/ContentHeader/ContentHeader.test.tsx
@@ -17,6 +17,7 @@
import React from 'react';
import { ContentHeader } from './ContentHeader';
import { renderInTestApp } from '@backstage/test-utils';
+import _ from 'lodash';
jest.mock('react-helmet', () => {
return {
@@ -27,14 +28,14 @@ jest.mock('react-helmet', () => {
describe('', () => {
it('should render with title', async () => {
const rendered = await renderInTestApp();
- rendered.getByText('Title');
+ expect(rendered.getByText('Title')).toBeInTheDocument();
});
it('should render without title', async () => {
const rendered = await renderInTestApp(
content,
);
- rendered.getByText('content');
+ expect(rendered.getByText('content')).toBeInTheDocument();
});
it('should render with titleComponent', async () => {
@@ -43,13 +44,13 @@ describe('', () => {
const rendered = await renderInTestApp(
,
);
- rendered.getByText(title);
+ expect(rendered.getByText(title)).toBeInTheDocument();
});
it('should render with description', async () => {
const rendered = await renderInTestApp(
,
);
- rendered.getByText('description');
+ expect(rendered.getByText('description')).toBeInTheDocument();
});
});
diff --git a/packages/core-components/src/layout/Header/Header.test.tsx b/packages/core-components/src/layout/Header/Header.test.tsx
index 776e39045c..2a63b4fedc 100644
--- a/packages/core-components/src/layout/Header/Header.test.tsx
+++ b/packages/core-components/src/layout/Header/Header.test.tsx
@@ -29,42 +29,46 @@ jest.mock('react-helmet', () => {
describe('', () => {
it('should render with title', async () => {
const rendered = await renderInTestApp();
- rendered.getByText('Title');
+ expect(rendered.getByText('Title')).toBeInTheDocument();
});
it('should set document title', async () => {
const rendered = await renderInTestApp();
- rendered.getByText('Title1');
- rendered.getByText('defaultTitle: Title1 | Backstage');
+ expect(rendered.getByText('Title1')).toBeInTheDocument();
+ expect(
+ rendered.getByText('defaultTitle: Title1 | Backstage'),
+ ).toBeInTheDocument();
});
it('should override document title', async () => {
const rendered = await renderInTestApp(
,
);
- rendered.getByText('Title1');
- rendered.getByText('defaultTitle: Title2 | Backstage');
+ expect(rendered.getByText('Title1')).toBeInTheDocument();
+ expect(
+ rendered.getByText('defaultTitle: Title2 | Backstage'),
+ ).toBeInTheDocument();
});
it('should have subtitle', async () => {
const rendered = await renderInTestApp(
,
);
- rendered.getByText('Subtitle');
+ expect(rendered.getByText('Subtitle')).toBeInTheDocument();
});
it('should have type rendered', async () => {
const rendered = await renderInTestApp(
,
);
- rendered.getByText('tool');
+ expect(rendered.getByText('tool')).toBeInTheDocument();
});
it('should have breadcrumb rendered', async () => {
const rendered = await renderInTestApp(
,
);
- rendered.getAllByText('Title');
+ expect(rendered.getAllByText('Title')).toBeTruthy();
});
it('should use app.title', async () => {
@@ -75,6 +79,6 @@ describe('', () => {
,
,
);
- rendered.getAllByText(/Title | Blah/);
+ expect(rendered.getAllByText(/Title | Blah/)).toBeTruthy();
});
});
diff --git a/packages/core-components/src/layout/HeaderActionMenu/HeaderActionMenu.test.tsx b/packages/core-components/src/layout/HeaderActionMenu/HeaderActionMenu.test.tsx
index b56ae3167f..fc9b4f449c 100644
--- a/packages/core-components/src/layout/HeaderActionMenu/HeaderActionMenu.test.tsx
+++ b/packages/core-components/src/layout/HeaderActionMenu/HeaderActionMenu.test.tsx
@@ -22,7 +22,14 @@ import userEvent from '@testing-library/user-event';
describe('', () => {
it('renders without any items and without exploding', async () => {
- await renderInTestApp();
+ const rendered = await renderInTestApp(
+ ,
+ );
+
+ expect(rendered.queryByTestId('header-action-menu')).toBeInTheDocument();
+ expect(
+ rendered.queryByTestId('header-action-item'),
+ ).not.toBeInTheDocument();
});
it('can open the menu and click menu items', async () => {