diff --git a/.changeset/thick-deers-trade.md b/.changeset/thick-deers-trade.md
index 8117b0eeab..9b023d709a 100644
--- a/.changeset/thick-deers-trade.md
+++ b/.changeset/thick-deers-trade.md
@@ -14,4 +14,4 @@
'@backstage/plugin-sonarqube': patch
---
-Fixed Link component import and usage. Now using backstage verion of Link
+Prefer using `Link` from `@backstage/core-components` rather than material-UI.
diff --git a/packages/core-components/src/components/DismissableBanner/DismissableBanner.stories.tsx b/packages/core-components/src/components/DismissableBanner/DismissableBanner.stories.tsx
index b08549539b..449d4a987b 100644
--- a/packages/core-components/src/components/DismissableBanner/DismissableBanner.stories.tsx
+++ b/packages/core-components/src/components/DismissableBanner/DismissableBanner.stories.tsx
@@ -94,6 +94,7 @@ export const WithLink = () => (
);
+
export const Fixed = () => (
@@ -106,6 +107,7 @@ export const Fixed = () => (
);
+
export const Warning = () => (
diff --git a/packages/core-components/src/layout/ErrorPage/ErrorPage.tsx b/packages/core-components/src/layout/ErrorPage/ErrorPage.tsx
index db747e3808..991c419dc3 100644
--- a/packages/core-components/src/layout/ErrorPage/ErrorPage.tsx
+++ b/packages/core-components/src/layout/ErrorPage/ErrorPage.tsx
@@ -80,14 +80,11 @@ export function ErrorPage(props: IErrorPageProps) {
Looks like someone dropped the mic!
-
+ navigate(-1)}>
Go back
- ... or please{' '}
-
- contact support
- {' '}
- if you think this is a bug.
+ ... or please contact support if you
+ think this is a bug.
diff --git a/plugins/catalog/src/components/Router.tsx b/plugins/catalog/src/components/Router.tsx
index fc70297b70..e8b00d8513 100644
--- a/plugins/catalog/src/components/Router.tsx
+++ b/plugins/catalog/src/components/Router.tsx
@@ -38,9 +38,7 @@ const DefaultEntityPage = () => (
To override this component with your custom implementation, read
docs on{' '}
-
- backstage.io/docs
-
+ backstage.io/docs
}
diff --git a/plugins/circleci/src/components/BuildsPage/lib/CITable/CITable.tsx b/plugins/circleci/src/components/BuildsPage/lib/CITable/CITable.tsx
index caf54a4fe4..adc8a569bb 100644
--- a/plugins/circleci/src/components/BuildsPage/lib/CITable/CITable.tsx
+++ b/plugins/circleci/src/components/BuildsPage/lib/CITable/CITable.tsx
@@ -121,9 +121,7 @@ const SourceInfo = ({ build }: { build: CITableBuildInfo }) => {
{source?.branchName}
{source?.commit?.url !== undefined ? (
-
- {source?.commit.shortHash}
-
+ {source?.commit.shortHash}
) : (
source?.commit.shortHash
)}
@@ -169,7 +167,7 @@ const generatedColumns: TableColumn[] = [
field: 'buildName',
highlight: true,
render: (row: Partial) => (
-
+
diff --git a/plugins/cloudbuild/src/components/Cards/Cards.tsx b/plugins/cloudbuild/src/components/Cards/Cards.tsx
index b016518b1c..dad1f7d38f 100644
--- a/plugins/cloudbuild/src/components/Cards/Cards.tsx
+++ b/plugins/cloudbuild/src/components/Cards/Cards.tsx
@@ -63,7 +63,7 @@ const WidgetContent = ({
),
message: lastRun.message,
url: (
-
+
See more on Google{' '}
diff --git a/plugins/github-actions/src/components/Cards/Cards.tsx b/plugins/github-actions/src/components/Cards/Cards.tsx
index 0cb5d1e089..cb4b2190fc 100644
--- a/plugins/github-actions/src/components/Cards/Cards.tsx
+++ b/plugins/github-actions/src/components/Cards/Cards.tsx
@@ -71,7 +71,7 @@ const WidgetContent = ({
),
message: lastRun.message,
url: (
-
+
See more on GitHub{' '}
diff --git a/plugins/gitops-profiles/src/components/ClusterTable/ClusterTable.tsx b/plugins/gitops-profiles/src/components/ClusterTable/ClusterTable.tsx
index 3230f8500c..9ac93a6d6c 100644
--- a/plugins/gitops-profiles/src/components/ClusterTable/ClusterTable.tsx
+++ b/plugins/gitops-profiles/src/components/ClusterTable/ClusterTable.tsx
@@ -24,7 +24,7 @@ const columns: TableColumn[] = [
field: 'name',
highlight: true,
render: (componentData: any) => (
-
+
{componentData.name}
),
diff --git a/plugins/jenkins/src/components/BuildsPage/lib/CITable/CITable.tsx b/plugins/jenkins/src/components/BuildsPage/lib/CITable/CITable.tsx
index a7a0686593..2c464491c2 100644
--- a/plugins/jenkins/src/components/BuildsPage/lib/CITable/CITable.tsx
+++ b/plugins/jenkins/src/components/BuildsPage/lib/CITable/CITable.tsx
@@ -13,12 +13,11 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-import { Progress, Table, TableColumn } from '@backstage/core-components';
+import { Link, Progress, Table, TableColumn } from '@backstage/core-components';
import { alertApiRef, useApi, useRouteRef } from '@backstage/core-plugin-api';
-import { Box, IconButton, Link, Tooltip, Typography } from '@material-ui/core';
+import { Box, IconButton, Tooltip, Typography } from '@material-ui/core';
import RetryIcon from '@material-ui/icons/Replay';
import { default as React, useState } from 'react';
-import { Link as RouterLink } from 'react-router-dom';
import { Project } from '../../../../api/JenkinsApi';
import JenkinsLogo from '../../../../assets/JenkinsLogo.svg';
import { buildRouteRef } from '../../../../plugin';
@@ -107,7 +106,6 @@ const generatedColumns: TableColumn[] = [
return (
) => (
<>
-
+
{row.lastBuild?.source?.branchName}
@@ -154,7 +152,7 @@ const generatedColumns: TableColumn[] = [
<>
{row.lastBuild?.tests && (
-
+
{row.lastBuild?.tests.passed} / {row.lastBuild?.tests.total}{' '}
passed
', () => {
const jenkinsApi: Partial = {
getProjects: () =>
Promise.resolve([
- { lastBuild: { timestamp: 0, status: 'success' } },
+ { lastBuild: { timestamp: 0, status: 'success', url: 'foo' } },
] as Project[]),
};
diff --git a/plugins/jenkins/src/components/Cards/Cards.tsx b/plugins/jenkins/src/components/Cards/Cards.tsx
index 158be5a8e0..cb84964124 100644
--- a/plugins/jenkins/src/components/Cards/Cards.tsx
+++ b/plugins/jenkins/src/components/Cards/Cards.tsx
@@ -67,7 +67,7 @@ const WidgetContent = ({
'latest run': displayDate,
duration: displayDuration,
link: (
-
+
See more on Jenkins{' '}