From 2815a4bb069b92f3689d7056c4168ea518e22fc8 Mon Sep 17 00:00:00 2001 From: Axel Hecht Date: Thu, 16 Jan 2025 11:12:40 +0100 Subject: [PATCH] Ignore internal non-published packages Using just the naming convention for now. Signed-off-by: Axel Hecht --- packages/core-compat-api/knip-report.md | 7 ------- packages/frontend-app-api/knip-report.md | 8 -------- packages/frontend-plugin-api/knip-report.md | 10 ---------- packages/frontend-test-utils/knip-report.md | 6 ------ .../src/commands/knip-reports/knip-extractor.ts | 1 + plugins/scaffolder-react/knip-report.md | 8 -------- plugins/scaffolder/knip-report.md | 6 ------ 7 files changed, 1 insertion(+), 45 deletions(-) diff --git a/packages/core-compat-api/knip-report.md b/packages/core-compat-api/knip-report.md index 7d3c3a7c03..a5794ee10b 100644 --- a/packages/core-compat-api/knip-report.md +++ b/packages/core-compat-api/knip-report.md @@ -8,10 +8,3 @@ | @backstage/types | package.json | error | | zod | package.json | error | -## Unlisted dependencies (2) - -| Name | Location | Severity | -| :----------------- | :------------------------------- | :------- | -| @internal/frontend | src/collectLegacyRoutes.test.tsx | error | -| @internal/frontend | src/convertLegacyPlugin.test.tsx | error | - diff --git a/packages/frontend-app-api/knip-report.md b/packages/frontend-app-api/knip-report.md index 69cb2648b7..b050438d7c 100644 --- a/packages/frontend-app-api/knip-report.md +++ b/packages/frontend-app-api/knip-report.md @@ -8,11 +8,3 @@ | @backstage/errors | package.json | error | | zod | package.json | error | -## Unlisted dependencies (3) - -| Name | Location | Severity | -| :----------------- | :---------------------------------- | :------- | -| @internal/frontend | src/wiring/createSpecializedApp.tsx | error | -| @internal/frontend | src/tree/resolveAppNodeSpecs.ts | error | -| @internal/frontend | src/routing/collectRouteIds.ts | error | - diff --git a/packages/frontend-plugin-api/knip-report.md b/packages/frontend-plugin-api/knip-report.md index 462c1fd03b..402fea3d47 100644 --- a/packages/frontend-plugin-api/knip-report.md +++ b/packages/frontend-plugin-api/knip-report.md @@ -14,13 +14,3 @@ | :-------------------------- | :----------- | :------- | | @backstage/frontend-app-api | package.json | error | -## Unlisted dependencies (5) - -| Name | Location | Severity | -| :----------------- | :------------------------------------------- | :------- | -| @internal/frontend | src/wiring/createExtensionBlueprint.test.tsx | error | -| @internal/frontend | src/wiring/resolveExtensionDefinition.ts | error | -| @internal/frontend | src/wiring/createFrontendModule.ts | error | -| @internal/frontend | src/wiring/createFrontendPlugin.ts | error | -| @internal/frontend | src/wiring/createExtension.ts | error | - diff --git a/packages/frontend-test-utils/knip-report.md b/packages/frontend-test-utils/knip-report.md index 5d03d0a51c..50f4f788e3 100644 --- a/packages/frontend-test-utils/knip-report.md +++ b/packages/frontend-test-utils/knip-report.md @@ -7,9 +7,3 @@ | @backstage/version-bridge | package.json | error | | zod | package.json | error | -## Unlisted dependencies (1) - -| Name | Location | Severity | -| :----------------- | :-------------------------------- | :------- | -| @internal/frontend | src/app/createExtensionTester.tsx | error | - diff --git a/packages/repo-tools/src/commands/knip-reports/knip-extractor.ts b/packages/repo-tools/src/commands/knip-reports/knip-extractor.ts index d7110eec5b..f2cd6e513e 100644 --- a/packages/repo-tools/src/commands/knip-reports/knip-extractor.ts +++ b/packages/repo-tools/src/commands/knip-reports/knip-extractor.ts @@ -81,6 +81,7 @@ async function generateKnipConfig({ knipConfigPath }: KnipConfigOptions) { // TBD: investigate what triggers these '@types/react', '@types/jest', + '@internal/.*', // internal packages are not published and inlined '@backstage/cli', // everything depends on this for its package.json commands '@backstage/theme', // this uses `declare module` in .d.ts so is implicitly used whenever extensions are needed ], diff --git a/plugins/scaffolder-react/knip-report.md b/plugins/scaffolder-react/knip-report.md index 982fa32d6f..38b9eed013 100644 --- a/plugins/scaffolder-react/knip-report.md +++ b/plugins/scaffolder-react/knip-report.md @@ -12,11 +12,3 @@ | :------------------------------- | :----------- | :------- | | @backstage/plugin-catalog-common | package.json | error | -## Unlisted dependencies (3) - -| Name | Location | Severity | -| :------------------- | :--------------------------------------------------- | :------- | -| @internal/scaffolder | src/next/extensions/createScaffolderFormDecorator.ts | error | -| @internal/scaffolder | src/next/blueprints/FormFieldBlueprint.tsx | error | -| @internal/scaffolder | src/next/api/FormFieldsApi.ts | error | - diff --git a/plugins/scaffolder/knip-report.md b/plugins/scaffolder/knip-report.md index caf0b9001b..02a697ddb0 100644 --- a/plugins/scaffolder/knip-report.md +++ b/plugins/scaffolder/knip-report.md @@ -8,9 +8,3 @@ | @rjsf/material-ui | package.json | error | | git-url-parse | package.json | error | -## Unlisted dependencies (1) - -| Name | Location | Severity | -| :------------------- | :----------------------------------- | :------- | -| @internal/scaffolder | src/alpha/hooks/useFormDecorators.ts | error | -