From 78dab638c9c1c86fccecf63486a3d0ae4d5d993c Mon Sep 17 00:00:00 2001 From: Jack Palmer Date: Fri, 1 Sep 2023 17:20:33 +0100 Subject: [PATCH 1/6] chore: Move AllowAllPermissionPolicy to it's own backend module package Signed-off-by: Jack Palmer --- packages/backend-next/package.json | 1 + packages/backend-next/src/index.ts | 6 +-- .../.eslintrc.js | 1 + .../README.md | 5 +++ .../package.json | 40 ++++++++++++++++++ .../src/index.ts | 23 ++++++++++ .../src/module.ts | 34 +++++++++++++++ .../src/policy.ts | 35 ++++++++++++++++ plugins/permission-backend/src/alpha.ts | 2 +- plugins/permission-backend/src/plugin.ts | 42 +------------------ yarn.lock | 15 +++++++ 11 files changed, 159 insertions(+), 45 deletions(-) create mode 100644 plugins/permission-backend-module-policy-allow-all/.eslintrc.js create mode 100644 plugins/permission-backend-module-policy-allow-all/README.md create mode 100644 plugins/permission-backend-module-policy-allow-all/package.json create mode 100644 plugins/permission-backend-module-policy-allow-all/src/index.ts create mode 100644 plugins/permission-backend-module-policy-allow-all/src/module.ts create mode 100644 plugins/permission-backend-module-policy-allow-all/src/policy.ts diff --git a/packages/backend-next/package.json b/packages/backend-next/package.json index ea832c60fb..4dc9056575 100644 --- a/packages/backend-next/package.json +++ b/packages/backend-next/package.json @@ -41,6 +41,7 @@ "@backstage/plugin-lighthouse-backend": "workspace:^", "@backstage/plugin-linguist-backend": "workspace:^", "@backstage/plugin-permission-backend": "workspace:^", + "@backstage/plugin-permission-backend-module-policy-allow-all": "workspace:^", "@backstage/plugin-permission-common": "workspace:^", "@backstage/plugin-permission-node": "workspace:^", "@backstage/plugin-proxy-backend": "workspace:^", diff --git a/packages/backend-next/src/index.ts b/packages/backend-next/src/index.ts index f3b1ea06f8..be9f1a1f53 100644 --- a/packages/backend-next/src/index.ts +++ b/packages/backend-next/src/index.ts @@ -18,10 +18,8 @@ import { createBackend } from '@backstage/backend-defaults'; import { appPlugin } from '@backstage/plugin-app-backend/alpha'; import { catalogPlugin } from '@backstage/plugin-catalog-backend/alpha'; import { kubernetesPlugin } from '@backstage/plugin-kubernetes-backend/alpha'; -import { - permissionModuleAllowAllPolicy, - permissionPlugin, -} from '@backstage/plugin-permission-backend/alpha'; +import { permissionPlugin } from '@backstage/plugin-permission-backend/alpha'; +import { permissionModuleAllowAllPolicy } from '@backstage/plugin-permission-backend-module-policy-allow-all'; import { scaffolderPlugin } from '@backstage/plugin-scaffolder-backend/alpha'; import { catalogModuleTemplateKind } from '@backstage/plugin-scaffolder-backend/alpha'; import { searchModuleCatalogCollator } from '@backstage/plugin-search-backend-module-catalog/alpha'; diff --git a/plugins/permission-backend-module-policy-allow-all/.eslintrc.js b/plugins/permission-backend-module-policy-allow-all/.eslintrc.js new file mode 100644 index 0000000000..e2a53a6ad2 --- /dev/null +++ b/plugins/permission-backend-module-policy-allow-all/.eslintrc.js @@ -0,0 +1 @@ +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); diff --git a/plugins/permission-backend-module-policy-allow-all/README.md b/plugins/permission-backend-module-policy-allow-all/README.md new file mode 100644 index 0000000000..5caae189b4 --- /dev/null +++ b/plugins/permission-backend-module-policy-allow-all/README.md @@ -0,0 +1,5 @@ +# @backstage/plugin-permission-backend-module-policy-allow-all + +The allow all policy backend module for the permission plugin. + +_This plugin was created through the Backstage CLI_ diff --git a/plugins/permission-backend-module-policy-allow-all/package.json b/plugins/permission-backend-module-policy-allow-all/package.json new file mode 100644 index 0000000000..05a0ff68de --- /dev/null +++ b/plugins/permission-backend-module-policy-allow-all/package.json @@ -0,0 +1,40 @@ +{ + "name": "@backstage/plugin-permission-backend-module-policy-allow-all", + "description": "Allow all policy backend module for the permission plugin.", + "version": "0.0.0", + "main": "src/index.ts", + "types": "src/index.ts", + "license": "Apache-2.0", + "private": true, + "publishConfig": { + "access": "public", + "main": "dist/index.cjs.js", + "types": "dist/index.d.ts" + }, + "backstage": { + "role": "backend-plugin-module" + }, + "scripts": { + "start": "backstage-cli package start", + "build": "backstage-cli package build", + "lint": "backstage-cli package lint", + "test": "backstage-cli package test", + "clean": "backstage-cli package clean", + "prepack": "backstage-cli package prepack", + "postpack": "backstage-cli package postpack" + }, + "dependencies": { + "@backstage/backend-common": "workspace:^", + "@backstage/backend-plugin-api": "workspace:^", + "@backstage/plugin-auth-node": "workspace:^", + "@backstage/plugin-permission-common": "workspace:^", + "@backstage/plugin-permission-node": "workspace:^" + }, + "devDependencies": { + "@backstage/backend-test-utils": "workspace:^", + "@backstage/cli": "workspace:^" + }, + "files": [ + "dist" + ] +} diff --git a/plugins/permission-backend-module-policy-allow-all/src/index.ts b/plugins/permission-backend-module-policy-allow-all/src/index.ts new file mode 100644 index 0000000000..f2e9b46bb5 --- /dev/null +++ b/plugins/permission-backend-module-policy-allow-all/src/index.ts @@ -0,0 +1,23 @@ +/* + * Copyright 2023 The Backstage Authors + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +/** + * The allow all policy backend module for the permission plugin. + * + * @packageDocumentation + */ + +export { permissionModuleAllowAllPolicy } from './module'; diff --git a/plugins/permission-backend-module-policy-allow-all/src/module.ts b/plugins/permission-backend-module-policy-allow-all/src/module.ts new file mode 100644 index 0000000000..48a73c1aa6 --- /dev/null +++ b/plugins/permission-backend-module-policy-allow-all/src/module.ts @@ -0,0 +1,34 @@ +/* + * Copyright 2023 The Backstage Authors + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +import { createBackendModule } from '@backstage/backend-plugin-api'; +import { policyExtensionPoint } from '@backstage/plugin-permission-node/alpha'; +import { AllowAllPermissionPolicy } from './policy'; + +/** + * A permission policy module that allows all requests. + */ +export const permissionModuleAllowAllPolicy = createBackendModule({ + moduleId: 'allowAllPolicy', + pluginId: 'permission', + register(reg) { + reg.registerInit({ + deps: { policy: policyExtensionPoint }, + async init({ policy }) { + policy.setPolicy(new AllowAllPermissionPolicy()); + }, + }); + }, +}); diff --git a/plugins/permission-backend-module-policy-allow-all/src/policy.ts b/plugins/permission-backend-module-policy-allow-all/src/policy.ts new file mode 100644 index 0000000000..fae693faba --- /dev/null +++ b/plugins/permission-backend-module-policy-allow-all/src/policy.ts @@ -0,0 +1,35 @@ +import { BackstageIdentityResponse } from '@backstage/plugin-auth-node'; +import { + AuthorizeResult, + PolicyDecision, +} from '@backstage/plugin-permission-common'; +import { + PermissionPolicy, + PolicyQuery, +} from '@backstage/plugin-permission-node'; + +/* + * Copyright 2023 The Backstage Authors + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +export class AllowAllPermissionPolicy implements PermissionPolicy { + async handle( + _request: PolicyQuery, + _user?: BackstageIdentityResponse, + ): Promise { + return { + result: AuthorizeResult.ALLOW, + }; + } +} diff --git a/plugins/permission-backend/src/alpha.ts b/plugins/permission-backend/src/alpha.ts index f6a2bb4f09..5958a52926 100644 --- a/plugins/permission-backend/src/alpha.ts +++ b/plugins/permission-backend/src/alpha.ts @@ -14,4 +14,4 @@ * limitations under the License. */ -export { permissionPlugin, permissionModuleAllowAllPolicy } from './plugin'; +export { permissionPlugin } from './plugin'; diff --git a/plugins/permission-backend/src/plugin.ts b/plugins/permission-backend/src/plugin.ts index a131b6e4b4..cb13204477 100644 --- a/plugins/permission-backend/src/plugin.ts +++ b/plugins/permission-backend/src/plugin.ts @@ -17,18 +17,9 @@ import { loggerToWinstonLogger } from '@backstage/backend-common'; import { coreServices, - createBackendModule, createBackendPlugin, } from '@backstage/backend-plugin-api'; -import { BackstageIdentityResponse } from '@backstage/plugin-auth-node'; -import { - AuthorizeResult, - PolicyDecision, -} from '@backstage/plugin-permission-common'; -import { - PermissionPolicy, - PolicyQuery, -} from '@backstage/plugin-permission-node'; +import { PermissionPolicy } from '@backstage/plugin-permission-node'; import { policyExtensionPoint, PolicyExtensionPoint, @@ -46,35 +37,6 @@ class PolicyExtensionPointImpl implements PolicyExtensionPoint { } } -/** - * A permission policy module that allows all requests. - * - * @alpha - */ -export const permissionModuleAllowAllPolicy = createBackendModule({ - moduleId: 'allowAllPolicy', - pluginId: 'permission', - register(reg) { - class AllowAllPermissionPolicy implements PermissionPolicy { - async handle( - _request: PolicyQuery, - _user?: BackstageIdentityResponse, - ): Promise { - return { - result: AuthorizeResult.ALLOW, - }; - } - } - - reg.registerInit({ - deps: { policy: policyExtensionPoint }, - async init({ policy }) { - policy.setPolicy(new AllowAllPermissionPolicy()); - }, - }); - }, -}); - /** * Permission plugin * @@ -99,7 +61,7 @@ export const permissionPlugin = createBackendPlugin({ const winstonLogger = loggerToWinstonLogger(logger); if (!policies.policy) { throw new Error( - 'No policy module installed! Please install a policy module. If you want to allow all requests, use permissionModuleAllowAllPolicy', + 'No policy module installed! Please install a policy module. If you want to allow all requests, use @backstage/plugin-permission-backend-module-policy-allow-all permissionModuleAllowAllPolicy', ); } diff --git a/yarn.lock b/yarn.lock index e7168d09ce..2556f758b5 100644 --- a/yarn.lock +++ b/yarn.lock @@ -8223,6 +8223,20 @@ __metadata: languageName: unknown linkType: soft +"@backstage/plugin-permission-backend-module-policy-allow-all@workspace:^, @backstage/plugin-permission-backend-module-policy-allow-all@workspace:plugins/permission-backend-module-policy-allow-all": + version: 0.0.0-use.local + resolution: "@backstage/plugin-permission-backend-module-policy-allow-all@workspace:plugins/permission-backend-module-policy-allow-all" + dependencies: + "@backstage/backend-common": "workspace:^" + "@backstage/backend-plugin-api": "workspace:^" + "@backstage/backend-test-utils": "workspace:^" + "@backstage/cli": "workspace:^" + "@backstage/plugin-auth-node": "workspace:^" + "@backstage/plugin-permission-common": "workspace:^" + "@backstage/plugin-permission-node": "workspace:^" + languageName: unknown + linkType: soft + "@backstage/plugin-permission-backend@workspace:^, @backstage/plugin-permission-backend@workspace:plugins/permission-backend": version: 0.0.0-use.local resolution: "@backstage/plugin-permission-backend@workspace:plugins/permission-backend" @@ -25819,6 +25833,7 @@ __metadata: "@backstage/plugin-lighthouse-backend": "workspace:^" "@backstage/plugin-linguist-backend": "workspace:^" "@backstage/plugin-permission-backend": "workspace:^" + "@backstage/plugin-permission-backend-module-policy-allow-all": "workspace:^" "@backstage/plugin-permission-common": "workspace:^" "@backstage/plugin-permission-node": "workspace:^" "@backstage/plugin-proxy-backend": "workspace:^" From f504c99a4db3c4c001996a1d40c905ee6621ace9 Mon Sep 17 00:00:00 2001 From: Jack Palmer Date: Fri, 1 Sep 2023 17:32:02 +0100 Subject: [PATCH 2/6] chore: api-reports Signed-off-by: Jack Palmer --- .../api-report.md | 10 ++++++++++ .../src/module.ts | 2 ++ plugins/permission-backend/alpha-api-report.md | 3 --- 3 files changed, 12 insertions(+), 3 deletions(-) create mode 100644 plugins/permission-backend-module-policy-allow-all/api-report.md diff --git a/plugins/permission-backend-module-policy-allow-all/api-report.md b/plugins/permission-backend-module-policy-allow-all/api-report.md new file mode 100644 index 0000000000..4adfd37219 --- /dev/null +++ b/plugins/permission-backend-module-policy-allow-all/api-report.md @@ -0,0 +1,10 @@ +## API Report File for "@backstage/plugin-permission-backend-module-policy-allow-all" + +> Do not edit this file. It is a report generated by [API Extractor](https://api-extractor.com/). + +```ts +import { BackendFeature } from '@backstage/backend-plugin-api'; + +// @public +export const permissionModuleAllowAllPolicy: () => BackendFeature; +``` diff --git a/plugins/permission-backend-module-policy-allow-all/src/module.ts b/plugins/permission-backend-module-policy-allow-all/src/module.ts index 48a73c1aa6..47ab202a00 100644 --- a/plugins/permission-backend-module-policy-allow-all/src/module.ts +++ b/plugins/permission-backend-module-policy-allow-all/src/module.ts @@ -19,6 +19,8 @@ import { AllowAllPermissionPolicy } from './policy'; /** * A permission policy module that allows all requests. + * + * @public */ export const permissionModuleAllowAllPolicy = createBackendModule({ moduleId: 'allowAllPolicy', diff --git a/plugins/permission-backend/alpha-api-report.md b/plugins/permission-backend/alpha-api-report.md index 926691930b..2397ccd9c9 100644 --- a/plugins/permission-backend/alpha-api-report.md +++ b/plugins/permission-backend/alpha-api-report.md @@ -5,9 +5,6 @@ ```ts import { BackendFeature } from '@backstage/backend-plugin-api'; -// @alpha -export const permissionModuleAllowAllPolicy: () => BackendFeature; - // @alpha export const permissionPlugin: () => BackendFeature; From 34fd8066d93d819d0e39d42a926c4b6f9fd0b571 Mon Sep 17 00:00:00 2001 From: Jack Palmer Date: Fri, 1 Sep 2023 17:32:57 +0100 Subject: [PATCH 3/6] chore: changeset Signed-off-by: Jack Palmer --- .changeset/moody-bugs-begin.md | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 .changeset/moody-bugs-begin.md diff --git a/.changeset/moody-bugs-begin.md b/.changeset/moody-bugs-begin.md new file mode 100644 index 0000000000..502f09081f --- /dev/null +++ b/.changeset/moody-bugs-begin.md @@ -0,0 +1,7 @@ +--- +'@backstage/plugin-permission-backend-module-policy-allow-all': patch +'@backstage/plugin-permission-backend': patch +'example-backend-next': patch +--- + +Moved permissionModuleAllowAllPolicy to @backstage/plugin-permission-backend-module-policy-allow-all From eb4b1d47c53a185942a041f5910691816d2abee4 Mon Sep 17 00:00:00 2001 From: Jack Palmer Date: Mon, 4 Sep 2023 09:10:01 +0100 Subject: [PATCH 4/6] fix: Address PR comments Signed-off-by: Jack Palmer --- .changeset/{moody-bugs-begin.md => proud-starfishes-walk.md} | 1 - plugins/permission-backend-module-policy-allow-all/package.json | 1 - 2 files changed, 2 deletions(-) rename .changeset/{moody-bugs-begin.md => proud-starfishes-walk.md} (88%) diff --git a/.changeset/moody-bugs-begin.md b/.changeset/proud-starfishes-walk.md similarity index 88% rename from .changeset/moody-bugs-begin.md rename to .changeset/proud-starfishes-walk.md index 502f09081f..fa13c964cd 100644 --- a/.changeset/moody-bugs-begin.md +++ b/.changeset/proud-starfishes-walk.md @@ -1,7 +1,6 @@ --- '@backstage/plugin-permission-backend-module-policy-allow-all': patch '@backstage/plugin-permission-backend': patch -'example-backend-next': patch --- Moved permissionModuleAllowAllPolicy to @backstage/plugin-permission-backend-module-policy-allow-all diff --git a/plugins/permission-backend-module-policy-allow-all/package.json b/plugins/permission-backend-module-policy-allow-all/package.json index 05a0ff68de..decb1573e7 100644 --- a/plugins/permission-backend-module-policy-allow-all/package.json +++ b/plugins/permission-backend-module-policy-allow-all/package.json @@ -5,7 +5,6 @@ "main": "src/index.ts", "types": "src/index.ts", "license": "Apache-2.0", - "private": true, "publishConfig": { "access": "public", "main": "dist/index.cjs.js", From 5f7b2153526bfe15b133c84635d2c41c201fe202 Mon Sep 17 00:00:00 2001 From: Jack Palmer Date: Tue, 5 Sep 2023 09:25:45 +0100 Subject: [PATCH 5/6] chore: Address PR comments Signed-off-by: Jack Palmer --- .changeset/proud-starfishes-walk.md | 6 ------ .changeset/tall-items-clap.md | 6 ++++++ packages/backend-next/package.json | 2 +- packages/backend-next/src/index.ts | 2 +- .../README.md | 2 +- .../api-report.md | 2 +- .../package.json | 2 +- .../src/policy.ts | 21 ++++++++++--------- plugins/permission-backend/src/plugin.ts | 2 +- yarn.lock | 6 +++--- 10 files changed, 26 insertions(+), 25 deletions(-) delete mode 100644 .changeset/proud-starfishes-walk.md create mode 100644 .changeset/tall-items-clap.md diff --git a/.changeset/proud-starfishes-walk.md b/.changeset/proud-starfishes-walk.md deleted file mode 100644 index fa13c964cd..0000000000 --- a/.changeset/proud-starfishes-walk.md +++ /dev/null @@ -1,6 +0,0 @@ ---- -'@backstage/plugin-permission-backend-module-policy-allow-all': patch -'@backstage/plugin-permission-backend': patch ---- - -Moved permissionModuleAllowAllPolicy to @backstage/plugin-permission-backend-module-policy-allow-all diff --git a/.changeset/tall-items-clap.md b/.changeset/tall-items-clap.md new file mode 100644 index 0000000000..78f9acd940 --- /dev/null +++ b/.changeset/tall-items-clap.md @@ -0,0 +1,6 @@ +--- +'@backstage/plugin-permission-backend-module-allow-all-policy': minor +'@backstage/plugin-permission-backend': patch +--- + +Moved `permissionModuleAllowAllPolicy` to `@backstage/plugin-permission-backend-module-allow-all-policy` diff --git a/packages/backend-next/package.json b/packages/backend-next/package.json index 4dc9056575..d8c90f6850 100644 --- a/packages/backend-next/package.json +++ b/packages/backend-next/package.json @@ -41,7 +41,7 @@ "@backstage/plugin-lighthouse-backend": "workspace:^", "@backstage/plugin-linguist-backend": "workspace:^", "@backstage/plugin-permission-backend": "workspace:^", - "@backstage/plugin-permission-backend-module-policy-allow-all": "workspace:^", + "@backstage/plugin-permission-backend-module-allow-all-policy": "workspace:^", "@backstage/plugin-permission-common": "workspace:^", "@backstage/plugin-permission-node": "workspace:^", "@backstage/plugin-proxy-backend": "workspace:^", diff --git a/packages/backend-next/src/index.ts b/packages/backend-next/src/index.ts index be9f1a1f53..6f736a2033 100644 --- a/packages/backend-next/src/index.ts +++ b/packages/backend-next/src/index.ts @@ -19,7 +19,7 @@ import { appPlugin } from '@backstage/plugin-app-backend/alpha'; import { catalogPlugin } from '@backstage/plugin-catalog-backend/alpha'; import { kubernetesPlugin } from '@backstage/plugin-kubernetes-backend/alpha'; import { permissionPlugin } from '@backstage/plugin-permission-backend/alpha'; -import { permissionModuleAllowAllPolicy } from '@backstage/plugin-permission-backend-module-policy-allow-all'; +import { permissionModuleAllowAllPolicy } from '@backstage/plugin-permission-backend-module-allow-all-policy'; import { scaffolderPlugin } from '@backstage/plugin-scaffolder-backend/alpha'; import { catalogModuleTemplateKind } from '@backstage/plugin-scaffolder-backend/alpha'; import { searchModuleCatalogCollator } from '@backstage/plugin-search-backend-module-catalog/alpha'; diff --git a/plugins/permission-backend-module-policy-allow-all/README.md b/plugins/permission-backend-module-policy-allow-all/README.md index 5caae189b4..1cdeadcf95 100644 --- a/plugins/permission-backend-module-policy-allow-all/README.md +++ b/plugins/permission-backend-module-policy-allow-all/README.md @@ -1,4 +1,4 @@ -# @backstage/plugin-permission-backend-module-policy-allow-all +# @backstage/plugin-permission-backend-module-allow-all-policy The allow all policy backend module for the permission plugin. diff --git a/plugins/permission-backend-module-policy-allow-all/api-report.md b/plugins/permission-backend-module-policy-allow-all/api-report.md index 4adfd37219..a965e9fa54 100644 --- a/plugins/permission-backend-module-policy-allow-all/api-report.md +++ b/plugins/permission-backend-module-policy-allow-all/api-report.md @@ -1,4 +1,4 @@ -## API Report File for "@backstage/plugin-permission-backend-module-policy-allow-all" +## API Report File for "@backstage/plugin-permission-backend-module-allow-all-policy" > Do not edit this file. It is a report generated by [API Extractor](https://api-extractor.com/). diff --git a/plugins/permission-backend-module-policy-allow-all/package.json b/plugins/permission-backend-module-policy-allow-all/package.json index decb1573e7..71a02539af 100644 --- a/plugins/permission-backend-module-policy-allow-all/package.json +++ b/plugins/permission-backend-module-policy-allow-all/package.json @@ -1,5 +1,5 @@ { - "name": "@backstage/plugin-permission-backend-module-policy-allow-all", + "name": "@backstage/plugin-permission-backend-module-allow-all-policy", "description": "Allow all policy backend module for the permission plugin.", "version": "0.0.0", "main": "src/index.ts", diff --git a/plugins/permission-backend-module-policy-allow-all/src/policy.ts b/plugins/permission-backend-module-policy-allow-all/src/policy.ts index fae693faba..da853e47db 100644 --- a/plugins/permission-backend-module-policy-allow-all/src/policy.ts +++ b/plugins/permission-backend-module-policy-allow-all/src/policy.ts @@ -1,13 +1,3 @@ -import { BackstageIdentityResponse } from '@backstage/plugin-auth-node'; -import { - AuthorizeResult, - PolicyDecision, -} from '@backstage/plugin-permission-common'; -import { - PermissionPolicy, - PolicyQuery, -} from '@backstage/plugin-permission-node'; - /* * Copyright 2023 The Backstage Authors * @@ -23,6 +13,17 @@ import { * See the License for the specific language governing permissions and * limitations under the License. */ + +import { BackstageIdentityResponse } from '@backstage/plugin-auth-node'; +import { + AuthorizeResult, + PolicyDecision, +} from '@backstage/plugin-permission-common'; +import { + PermissionPolicy, + PolicyQuery, +} from '@backstage/plugin-permission-node'; + export class AllowAllPermissionPolicy implements PermissionPolicy { async handle( _request: PolicyQuery, diff --git a/plugins/permission-backend/src/plugin.ts b/plugins/permission-backend/src/plugin.ts index cb13204477..9cf0024e47 100644 --- a/plugins/permission-backend/src/plugin.ts +++ b/plugins/permission-backend/src/plugin.ts @@ -61,7 +61,7 @@ export const permissionPlugin = createBackendPlugin({ const winstonLogger = loggerToWinstonLogger(logger); if (!policies.policy) { throw new Error( - 'No policy module installed! Please install a policy module. If you want to allow all requests, use @backstage/plugin-permission-backend-module-policy-allow-all permissionModuleAllowAllPolicy', + 'No policy module installed! Please install a policy module. If you want to allow all requests, use @backstage/plugin-permission-backend-module-allow-all-policy permissionModuleAllowAllPolicy', ); } diff --git a/yarn.lock b/yarn.lock index 2556f758b5..965ff642e0 100644 --- a/yarn.lock +++ b/yarn.lock @@ -8223,9 +8223,9 @@ __metadata: languageName: unknown linkType: soft -"@backstage/plugin-permission-backend-module-policy-allow-all@workspace:^, @backstage/plugin-permission-backend-module-policy-allow-all@workspace:plugins/permission-backend-module-policy-allow-all": +"@backstage/plugin-permission-backend-module-allow-all-policy@workspace:^, @backstage/plugin-permission-backend-module-allow-all-policy@workspace:plugins/permission-backend-module-policy-allow-all": version: 0.0.0-use.local - resolution: "@backstage/plugin-permission-backend-module-policy-allow-all@workspace:plugins/permission-backend-module-policy-allow-all" + resolution: "@backstage/plugin-permission-backend-module-allow-all-policy@workspace:plugins/permission-backend-module-policy-allow-all" dependencies: "@backstage/backend-common": "workspace:^" "@backstage/backend-plugin-api": "workspace:^" @@ -25833,7 +25833,7 @@ __metadata: "@backstage/plugin-lighthouse-backend": "workspace:^" "@backstage/plugin-linguist-backend": "workspace:^" "@backstage/plugin-permission-backend": "workspace:^" - "@backstage/plugin-permission-backend-module-policy-allow-all": "workspace:^" + "@backstage/plugin-permission-backend-module-allow-all-policy": "workspace:^" "@backstage/plugin-permission-common": "workspace:^" "@backstage/plugin-permission-node": "workspace:^" "@backstage/plugin-proxy-backend": "workspace:^" From 84ad6fccd4d589f93dc3c248025eb495aff294da Mon Sep 17 00:00:00 2001 From: Jack Palmer Date: Tue, 5 Sep 2023 09:35:15 +0100 Subject: [PATCH 6/6] chore: Multiple changesets Signed-off-by: Jack Palmer --- .changeset/pink-months-hammer.md | 5 +++++ .changeset/tall-items-clap.md | 3 +-- 2 files changed, 6 insertions(+), 2 deletions(-) create mode 100644 .changeset/pink-months-hammer.md diff --git a/.changeset/pink-months-hammer.md b/.changeset/pink-months-hammer.md new file mode 100644 index 0000000000..20a484a389 --- /dev/null +++ b/.changeset/pink-months-hammer.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-permission-backend': patch +--- + +Moved `permissionModuleAllowAllPolicy` to `@backstage/plugin-permission-backend-module-allow-all-policy` diff --git a/.changeset/tall-items-clap.md b/.changeset/tall-items-clap.md index 78f9acd940..613c280cbe 100644 --- a/.changeset/tall-items-clap.md +++ b/.changeset/tall-items-clap.md @@ -1,6 +1,5 @@ --- '@backstage/plugin-permission-backend-module-allow-all-policy': minor -'@backstage/plugin-permission-backend': patch --- -Moved `permissionModuleAllowAllPolicy` to `@backstage/plugin-permission-backend-module-allow-all-policy` +Created package with policy `permissionModuleAllowAllPolicy`