From 277da332d6ed9feef92bf1d1768b28dd8f66bda8 Mon Sep 17 00:00:00 2001
From: Brian Fletcher <brian@roadie.io>
Date: Mon, 22 May 2023 12:38:30 +0100
Subject: [PATCH] more review comments

Signed-off-by: Brian Fletcher <brian@roadie.io>
---
 plugins/pagerduty/package.json  |  2 +-
 plugins/pagerduty/src/index.ts  |  8 +++++++-
 plugins/pagerduty/src/plugin.ts | 11 ++---------
 yarn.lock                       |  2 +-
 4 files changed, 11 insertions(+), 12 deletions(-)

diff --git a/plugins/pagerduty/package.json b/plugins/pagerduty/package.json
index b0eea1764e..ac52bd7daf 100644
--- a/plugins/pagerduty/package.json
+++ b/plugins/pagerduty/package.json
@@ -38,7 +38,7 @@
     "@backstage/core-plugin-api": "workspace:^",
     "@backstage/errors": "workspace:^",
     "@backstage/plugin-catalog-react": "workspace:^",
-    "@backstage/plugin-home": "workspace:^",
+    "@backstage/plugin-home-react": "workspace:^",
     "@backstage/theme": "workspace:^",
     "@material-ui/core": "^4.12.2",
     "@material-ui/icons": "^4.9.1",
diff --git a/plugins/pagerduty/src/index.ts b/plugins/pagerduty/src/index.ts
index 19b8456476..d0320e3343 100644
--- a/plugins/pagerduty/src/index.ts
+++ b/plugins/pagerduty/src/index.ts
@@ -29,8 +29,14 @@ export {
 
 export * from './components';
 
-// @deprecated Please use EntityPagerDutyCard
+/**
+ * @deprecated Please use EntityPagerDutyCard
+ */
 export { EntityPagerDutyCard as PagerDutyCard } from './components';
+
+/**
+ * @deprecated Please use EntityPagerDutyCardProps
+ */
 export type { EntityPagerDutyCardProps as PagerDutyCardProps } from './components';
 
 export * from './api';
diff --git a/plugins/pagerduty/src/plugin.ts b/plugins/pagerduty/src/plugin.ts
index 2cf330864d..59cc5cd8cc 100644
--- a/plugins/pagerduty/src/plugin.ts
+++ b/plugins/pagerduty/src/plugin.ts
@@ -23,7 +23,7 @@ import {
   configApiRef,
   createComponentExtension,
 } from '@backstage/core-plugin-api';
-import { createCardExtension } from '@backstage/plugin-home';
+import { createCardExtension } from '@backstage/plugin-home-react';
 import { HomePagePagerDutyCardProps } from './components/HomePagePagerDutyCard/Content';
 
 export const rootRouteRef = createRouteRef({
@@ -60,15 +60,8 @@ export const EntityPagerDutyCard = pagerDutyPlugin.provide(
   }),
 );
 
-export const homePlugin = createPlugin({
-  id: 'pagerduty-home',
-  routes: {
-    root: rootRouteRef,
-  },
-});
-
 /** @public */
-export const HomePagePagerDutyCard = homePlugin.provide(
+export const HomePagePagerDutyCard = pagerDutyPlugin.provide(
   createCardExtension<HomePagePagerDutyCardProps>({
     name: 'HomePagePagerDutyCard',
     title: 'PagerDuty Homepage Card',
diff --git a/yarn.lock b/yarn.lock
index 7411abf9e8..eab5bf2d91 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -7726,7 +7726,7 @@ __metadata:
     "@backstage/dev-utils": "workspace:^"
     "@backstage/errors": "workspace:^"
     "@backstage/plugin-catalog-react": "workspace:^"
-    "@backstage/plugin-home": "workspace:^"
+    "@backstage/plugin-home-react": "workspace:^"
     "@backstage/test-utils": "workspace:^"
     "@backstage/theme": "workspace:^"
     "@material-ui/core": ^4.12.2