From 26a15f75e0fb70f5f46014b7593a929e8e9ceece Mon Sep 17 00:00:00 2001
From: Aditya Kumar <aditya.kumar60@infosys.com>
Date: Tue, 19 Mar 2024 13:20:08 +0530
Subject: [PATCH] Add ESLint Rule to Shortcuts Plugin

Signed-off-by: Aditya Kumar <aditya.kumar60@infosys.com>
---
 .changeset/chatty-bikes-greet.md       |  5 +++++
 plugins/shortcuts/.eslintrc.js         |  6 +++++-
 plugins/shortcuts/src/AddShortcut.tsx  | 12 +++++-------
 plugins/shortcuts/src/EditShortcut.tsx | 12 +++++-------
 plugins/shortcuts/src/ShortcutForm.tsx | 12 +++++-------
 5 files changed, 25 insertions(+), 22 deletions(-)
 create mode 100644 .changeset/chatty-bikes-greet.md

diff --git a/.changeset/chatty-bikes-greet.md b/.changeset/chatty-bikes-greet.md
new file mode 100644
index 0000000000..449740ab93
--- /dev/null
+++ b/.changeset/chatty-bikes-greet.md
@@ -0,0 +1,5 @@
+---
+'@backstage/plugin-shortcuts': patch
+---
+
+Added ESLint rule `no-top-level-material-ui-4-imports` in the `shortcuts` plugin to migrate the Material UI imports.
diff --git a/plugins/shortcuts/.eslintrc.js b/plugins/shortcuts/.eslintrc.js
index e2a53a6ad2..a2d8179106 100644
--- a/plugins/shortcuts/.eslintrc.js
+++ b/plugins/shortcuts/.eslintrc.js
@@ -1 +1,5 @@
-module.exports = require('@backstage/cli/config/eslint-factory')(__dirname);
+module.exports = require('@backstage/cli/config/eslint-factory')(__dirname, {
+    rules: {
+      '@backstage/no-top-level-material-ui-4-imports': 'error',
+    },
+});
diff --git a/plugins/shortcuts/src/AddShortcut.tsx b/plugins/shortcuts/src/AddShortcut.tsx
index 15850ab389..76d3a76a03 100644
--- a/plugins/shortcuts/src/AddShortcut.tsx
+++ b/plugins/shortcuts/src/AddShortcut.tsx
@@ -17,13 +17,11 @@
 import React, { useState } from 'react';
 import { useLocation } from 'react-router-dom';
 import { SubmitHandler } from 'react-hook-form';
-import {
-  Button,
-  Card,
-  CardHeader,
-  makeStyles,
-  Popover,
-} from '@material-ui/core';
+import Button from '@material-ui/core/Button';
+import Card from '@material-ui/core/Card';
+import CardHeader from '@material-ui/core/CardHeader';
+import Popover from '@material-ui/core/Popover';
+import { makeStyles } from '@material-ui/core/styles';
 import { ShortcutForm } from './ShortcutForm';
 import { FormValues, Shortcut } from './types';
 import { ShortcutApi } from './api';
diff --git a/plugins/shortcuts/src/EditShortcut.tsx b/plugins/shortcuts/src/EditShortcut.tsx
index 9f2ffe10be..47ca1cb546 100644
--- a/plugins/shortcuts/src/EditShortcut.tsx
+++ b/plugins/shortcuts/src/EditShortcut.tsx
@@ -16,13 +16,11 @@
 
 import React from 'react';
 import { SubmitHandler } from 'react-hook-form';
-import {
-  Button,
-  Card,
-  CardHeader,
-  makeStyles,
-  Popover,
-} from '@material-ui/core';
+import Button from '@material-ui/core/Button';
+import Card from '@material-ui/core/Card';
+import CardHeader from '@material-ui/core/CardHeader';
+import Popover from '@material-ui/core/Popover';
+import { makeStyles } from '@material-ui/core/styles';
 import { ShortcutForm } from './ShortcutForm';
 import { FormValues, Shortcut } from './types';
 import DeleteIcon from '@material-ui/icons/Delete';
diff --git a/plugins/shortcuts/src/ShortcutForm.tsx b/plugins/shortcuts/src/ShortcutForm.tsx
index 4d6fdcbc27..efb5829768 100644
--- a/plugins/shortcuts/src/ShortcutForm.tsx
+++ b/plugins/shortcuts/src/ShortcutForm.tsx
@@ -17,13 +17,11 @@
 import React, { useEffect, useRef } from 'react';
 import useObservable from 'react-use/lib/useObservable';
 import { useForm, SubmitHandler, Controller } from 'react-hook-form';
-import {
-  Button,
-  CardActions,
-  CardContent,
-  makeStyles,
-  TextField,
-} from '@material-ui/core';
+import Button from '@material-ui/core/Button';
+import CardActions from '@material-ui/core/CardActions';
+import CardContent from '@material-ui/core/CardContent';
+import TextField from '@material-ui/core/TextField';
+import { makeStyles } from '@material-ui/core/styles';
 import { FormValues } from './types';
 import { shortcutsApiRef } from './api';
 import { useApi } from '@backstage/core-plugin-api';