diff --git a/.changeset/remove-nav-item-blueprint-test-utils.md b/.changeset/remove-nav-item-blueprint-test-utils.md index 96e4554556..ef553119b5 100644 --- a/.changeset/remove-nav-item-blueprint-test-utils.md +++ b/.changeset/remove-nav-item-blueprint-test-utils.md @@ -2,4 +2,4 @@ '@backstage/frontend-test-utils': patch --- -Updated `renderInTestApp` to render legacy nav-item extensions without relying on the removed `NavItemBlueprint` from `@backstage/frontend-plugin-api`. +Disabled the app nav extension in `renderInTestApp`, removing the legacy nav-item rendering stub. diff --git a/packages/frontend-test-utils/src/app/renderInTestApp.tsx b/packages/frontend-test-utils/src/app/renderInTestApp.tsx index 3d30ae3d6b..d599bdca01 100644 --- a/packages/frontend-test-utils/src/app/renderInTestApp.tsx +++ b/packages/frontend-test-utils/src/app/renderInTestApp.tsx @@ -15,19 +15,16 @@ */ import { Fragment } from 'react'; -import { Link, MemoryRouter } from 'react-router-dom'; +import { MemoryRouter } from 'react-router-dom'; import { prepareSpecializedApp } from '@backstage/frontend-app-api'; import { RenderResult, render } from '@testing-library/react'; import { ConfigReader } from '@backstage/config'; import { JsonObject } from '@backstage/types'; import { createExtension, - createExtensionDataRef, ExtensionDefinition, coreExtensionData, RouteRef, - useRouteRef, - IconComponent, createFrontendPlugin, FrontendFeature, createFrontendModule, @@ -49,13 +46,6 @@ const DEFAULT_MOCK_CONFIG = { backend: { baseUrl: 'http://localhost:7007' }, }; -// Must match the data ref in @backstage/plugin-app/src/extensions/legacyNavItem.ts -const legacyNavItemTargetDataRef = createExtensionDataRef<{ - title: string; - icon: IconComponent; - routeRef: RouteRef; -}>().with({ id: 'core.nav-item.target' }); - /** * Options to customize the behavior of the test app. * @public @@ -110,25 +100,6 @@ export type TestAppOptions = { apis?: readonly [...TestApiPairs]; }; -const NavItem = (props: { - routeRef: RouteRef; - title: string; - icon: IconComponent; -}) => { - const { routeRef, title, icon: Icon } = props; - const link = useRouteRef(routeRef); - if (!link) { - return null; - } - return ( -
  • - - {title} - -
  • - ); -}; - const appPluginOverride = appPlugin.withOverrides({ extensions: [ appPlugin.getExtension('sign-in-page:app').override({ @@ -141,33 +112,7 @@ const appPluginOverride = appPlugin.withOverrides({ disabled: true, }), appPlugin.getExtension('app/nav').override({ - output: [coreExtensionData.reactElement], - factory(_originalFactory, { inputs }) { - return [ - coreExtensionData.reactElement( - , - ), - ]; - }, + disabled: true, }), ], });