From 263f6be4f6221f0c834e8c0a176c017319d5f502 Mon Sep 17 00:00:00 2001
From: Vincenzo Scamporlino <vincenzos@spotify.com>
Date: Tue, 15 Aug 2023 00:08:19 +0200
Subject: [PATCH] backend-app-api: keep ServiceRegistry immutable

Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
---
 packages/backend-app-api/src/wiring/ServiceRegistry.ts | 7 -------
 packages/backend-app-api/src/wiring/types.ts           | 2 --
 2 files changed, 9 deletions(-)

diff --git a/packages/backend-app-api/src/wiring/ServiceRegistry.ts b/packages/backend-app-api/src/wiring/ServiceRegistry.ts
index 25d777549c..b6de05b361 100644
--- a/packages/backend-app-api/src/wiring/ServiceRegistry.ts
+++ b/packages/backend-app-api/src/wiring/ServiceRegistry.ts
@@ -82,13 +82,6 @@ export class ServiceRegistry implements EnumerableServiceHolder {
     this.#implementations = new Map();
   }
 
-  add(serviceFactory: ServiceFactory) {
-    this.#providedFactories.set(
-      serviceFactory.service.id,
-      toInternalServiceFactory(serviceFactory),
-    );
-  }
-
   #resolveFactory(
     ref: ServiceRef<unknown>,
     pluginId: string,
diff --git a/packages/backend-app-api/src/wiring/types.ts b/packages/backend-app-api/src/wiring/types.ts
index 0a43caae59..552a69a792 100644
--- a/packages/backend-app-api/src/wiring/types.ts
+++ b/packages/backend-app-api/src/wiring/types.ts
@@ -19,7 +19,6 @@ import {
   ExtensionPoint,
   ServiceRef,
   ServiceFactoryOrFunction,
-  ServiceFactory,
 } from '@backstage/backend-plugin-api';
 
 /**
@@ -40,7 +39,6 @@ export interface CreateSpecializedBackendOptions {
 
 export interface ServiceHolder {
   get<T>(api: ServiceRef<T>, pluginId: string): Promise<T> | undefined;
-  add(serviceFactory: ServiceFactory): void;
 }
 
 /**