From 243dd5771b3f89f16048930cd698d5e300f069b6 Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Thu, 25 Feb 2021 19:08:04 +0100 Subject: [PATCH] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Fredrik Adelöw --- docs/plugins/composability.md | 2 +- packages/core-api/src/app/types.ts | 2 +- packages/core-api/src/routing/RouteRef.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/plugins/composability.md b/docs/plugins/composability.md index 07a2b503ec..75993dbc46 100644 --- a/docs/plugins/composability.md +++ b/docs/plugins/composability.md @@ -321,7 +321,7 @@ app, allowing it to be used as a switch for whether a particular link should be displayed or action should be taken. When calling `useRouteRef` with an optional external route, its return signature -is change to `RouteFunc | undefined`, allowing for logic like this: +is changed to `RouteFunc | undefined`, allowing for logic like this: ```tsx const MyComponent = () => { diff --git a/packages/core-api/src/app/types.ts b/packages/core-api/src/app/types.ts index a54234b046..701862601d 100644 --- a/packages/core-api/src/app/types.ts +++ b/packages/core-api/src/app/types.ts @@ -96,7 +96,7 @@ type ExtractKeysWithType = { }[keyof Obj]; /** - * Given a map of boolean values denoting whether a rout is optional, create a + * Given a map of boolean values denoting whether a route is optional, create a * map of needed RouteRefs. * * For example { foo: false, bar: true } gives { foo: RouteRef, bar?: RouteRef } diff --git a/packages/core-api/src/routing/RouteRef.ts b/packages/core-api/src/routing/RouteRef.ts index dc97afbe96..67ff9bc1fb 100644 --- a/packages/core-api/src/routing/RouteRef.ts +++ b/packages/core-api/src/routing/RouteRef.ts @@ -83,7 +83,7 @@ export type ExternalRouteRefOptions = { * Whether or not this route is optional, defaults to false. * * Optional external routes are not required to be bound in the app, and - * if aren't, `useRouteRef` will return `undefined`. + * if they aren't, `useRouteRef` will return `undefined`. */ optional?: Optional; };