From 22c8b3d5df74567b029493e974ec25da3bd7b331 Mon Sep 17 00:00:00 2001 From: benjdlambert Date: Tue, 17 Jun 2025 11:53:30 +0200 Subject: [PATCH] chore: don't use send Signed-off-by: benjdlambert --- .../mcp-actions-backend/src/routers/createSseRouter.ts | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/plugins/mcp-actions-backend/src/routers/createSseRouter.ts b/plugins/mcp-actions-backend/src/routers/createSseRouter.ts index aae9407256..0356da18bf 100644 --- a/plugins/mcp-actions-backend/src/routers/createSseRouter.ts +++ b/plugins/mcp-actions-backend/src/routers/createSseRouter.ts @@ -18,6 +18,7 @@ import { Router } from 'express'; import { McpService } from '../services/McpService'; import { SSEServerTransport } from '@modelcontextprotocol/sdk/server/sse.js'; import { HttpAuthService } from '@backstage/backend-plugin-api'; +import { InputError, NotFoundError } from '@backstage/errors'; /** * Legacy SSE endpoint for older clients, hopefully will not be needed for much longer. @@ -55,15 +56,16 @@ export const createSseRouter = ({ const sessionId = req.query.sessionId as string; if (!sessionId) { - res.status(400).send('sessionId is required'); - return; + throw new InputError('sessionId is required'); } const transport = transportsToSessionId.get(sessionId); if (transport) { await transport.handlePostMessage(req, res, req.body); } else { - res.status(400).send(`No transport found for sessionId "${sessionId}"`); + throw new NotFoundError( + `No transport found for sessionId "${sessionId}"`, + ); } }); return router;