removed deprecated entity props

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
This commit is contained in:
Patrik Oldsberg
2022-02-18 13:09:56 +01:00
parent 10a0a8046b
commit 2262fe19c9
41 changed files with 61 additions and 186 deletions
+17
View File
@@ -0,0 +1,17 @@
---
'@backstage/plugin-api-docs': minor
'@backstage/plugin-catalog': minor
'@backstage/plugin-circleci': minor
'@backstage/plugin-cloudbuild': minor
'@backstage/plugin-github-actions': minor
'@backstage/plugin-jenkins': minor
'@backstage/plugin-kafka': minor
'@backstage/plugin-kubernetes': minor
'@backstage/plugin-lighthouse': minor
'@backstage/plugin-org': minor
'@backstage/plugin-rollbar': minor
'@backstage/plugin-sonarqube': minor
'@backstage/plugin-techdocs': minor
---
**BREAKING**: Removed support for passing in an explicit `entity` prop to entity page extensions, which has been deprecated for a long time. This is only a breaking change at the TypeScript level, as this property was already ignored.
+7 -15
View File
@@ -9,7 +9,6 @@ import { ApiEntity } from '@backstage/catalog-model';
import { ApiRef } from '@backstage/core-plugin-api';
import { BackstagePlugin } from '@backstage/core-plugin-api';
import { CatalogTableRow } from '@backstage/plugin-catalog';
import { Entity } from '@backstage/catalog-model';
import { ExternalRouteRef } from '@backstage/core-plugin-api';
import { default as React_2 } from 'react';
import { RouteRef } from '@backstage/core-plugin-api';
@@ -17,11 +16,10 @@ import { TableColumn } from '@backstage/core-components';
import { TableProps } from '@backstage/core-components';
import { UserListFilterKind } from '@backstage/plugin-catalog-react';
// Warning: (ae-forgotten-export) The symbol "Props" needs to be exported by the entry point index.d.ts
// Warning: (ae-missing-release-tag) "ApiDefinitionCard" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export const ApiDefinitionCard: (_: Props) => JSX.Element;
export const ApiDefinitionCard: () => JSX.Element;
// Warning: (ae-missing-release-tag) "ApiDefinitionWidget" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
@@ -92,13 +90,13 @@ export type AsyncApiDefinitionWidgetProps = {
// Warning: (ae-missing-release-tag) "ConsumedApisCard" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export const ConsumedApisCard: ({ variant }: Props_2) => JSX.Element;
export const ConsumedApisCard: ({ variant }: Props) => JSX.Element;
// Warning: (ae-forgotten-export) The symbol "Props" needs to be exported by the entry point index.d.ts
// Warning: (ae-missing-release-tag) "ConsumingComponentsCard" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export const ConsumingComponentsCard: ({ variant }: Props_5) => JSX.Element;
export const ConsumingComponentsCard: ({ variant }: Props_4) => JSX.Element;
// @public
export const DefaultApiExplorerPage: ({
@@ -122,9 +120,7 @@ export function defaultDefinitionWidgets(): ApiDefinitionWidget[];
// Warning: (ae-missing-release-tag) "EntityApiDefinitionCard" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export const EntityApiDefinitionCard: (_: {
apiEntity?: ApiEntity | undefined;
}) => JSX.Element;
export const EntityApiDefinitionCard: () => JSX.Element;
// Warning: (ae-missing-release-tag) "EntityConsumedApisCard" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
@@ -132,7 +128,6 @@ export const EntityApiDefinitionCard: (_: {
export const EntityConsumedApisCard: ({
variant,
}: {
entity?: Entity | undefined;
variant?: 'gridItem' | undefined;
}) => JSX.Element;
@@ -142,7 +137,6 @@ export const EntityConsumedApisCard: ({
export const EntityConsumingComponentsCard: ({
variant,
}: {
entity?: Entity | undefined;
variant?: 'gridItem' | undefined;
}) => JSX.Element;
@@ -161,7 +155,6 @@ export const EntityHasApisCard: ({
export const EntityProvidedApisCard: ({
variant,
}: {
entity?: Entity | undefined;
variant?: 'gridItem' | undefined;
}) => JSX.Element;
@@ -171,7 +164,6 @@ export const EntityProvidedApisCard: ({
export const EntityProvidingComponentsCard: ({
variant,
}: {
entity?: Entity | undefined;
variant?: 'gridItem' | undefined;
}) => JSX.Element;
@@ -193,7 +185,7 @@ export type GraphQlDefinitionWidgetProps = {
// Warning: (ae-missing-release-tag) "HasApisCard" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export const HasApisCard: ({ variant }: Props_3) => JSX.Element;
export const HasApisCard: ({ variant }: Props_2) => JSX.Element;
// Warning: (ae-missing-release-tag) "OpenApiDefinitionWidget" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
@@ -228,11 +220,11 @@ export type PlainApiDefinitionWidgetProps = {
// Warning: (ae-missing-release-tag) "ProvidedApisCard" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export const ProvidedApisCard: ({ variant }: Props_4) => JSX.Element;
export const ProvidedApisCard: ({ variant }: Props_3) => JSX.Element;
// Warning: (ae-forgotten-export) The symbol "Props" needs to be exported by the entry point index.d.ts
// Warning: (ae-missing-release-tag) "ProvidingComponentsCard" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export const ProvidingComponentsCard: ({ variant }: Props_6) => JSX.Element;
export const ProvidingComponentsCard: ({ variant }: Props_5) => JSX.Element;
```
@@ -24,12 +24,7 @@ import { PlainApiDefinitionWidget } from '../PlainApiDefinitionWidget';
import { CardTab, TabbedCard } from '@backstage/core-components';
import { useApi } from '@backstage/core-plugin-api';
type Props = {
/** @deprecated The entity is now grabbed from context instead */
apiEntity?: ApiEntity;
};
export const ApiDefinitionCard = (_: Props) => {
export const ApiDefinitionCard = () => {
const { entity } = useEntity<ApiEntity>();
const config = useApi(apiDocsConfigRef);
const { getApiDefinitionWidget } = config;
@@ -14,11 +14,7 @@
* limitations under the License.
*/
import {
ApiEntity,
Entity,
RELATION_CONSUMES_API,
} from '@backstage/catalog-model';
import { ApiEntity, RELATION_CONSUMES_API } from '@backstage/catalog-model';
import { Typography } from '@material-ui/core';
import {
EntityTable,
@@ -36,8 +32,6 @@ import {
} from '@backstage/core-components';
type Props = {
/** @deprecated The entity is now grabbed from context instead */
entity?: Entity;
variant?: 'gridItem';
};
@@ -14,11 +14,7 @@
* limitations under the License.
*/
import {
ApiEntity,
Entity,
RELATION_PROVIDES_API,
} from '@backstage/catalog-model';
import { ApiEntity, RELATION_PROVIDES_API } from '@backstage/catalog-model';
import { Typography } from '@material-ui/core';
import {
EntityTable,
@@ -36,8 +32,6 @@ import {
} from '@backstage/core-components';
type Props = {
/** @deprecated The entity is now grabbed from context instead */
entity?: Entity;
variant?: 'gridItem';
};
@@ -16,7 +16,6 @@
import {
ComponentEntity,
Entity,
RELATION_API_CONSUMED_BY,
} from '@backstage/catalog-model';
import { Typography } from '@material-ui/core';
@@ -35,8 +34,6 @@ import {
} from '@backstage/core-components';
type Props = {
/** @deprecated The entity is now grabbed from context instead */
entity?: Entity;
variant?: 'gridItem';
};
@@ -16,7 +16,6 @@
import {
ComponentEntity,
Entity,
RELATION_API_PROVIDED_BY,
} from '@backstage/catalog-model';
import { Typography } from '@material-ui/core';
@@ -35,8 +34,6 @@ import {
} from '@backstage/core-components';
type Props = {
/** @deprecated The entity is now grabbed from context instead */
entity?: Entity;
variant?: 'gridItem';
};
-4
View File
@@ -27,8 +27,6 @@ export function AboutCard(props: AboutCardProps): JSX.Element;
// @public
export interface AboutCardProps {
// @deprecated (undocumented)
entity?: Entity;
// (undocumented)
variant?: InfoCardVariants;
}
@@ -285,8 +283,6 @@ export interface EntityLinksCardProps {
//
// (undocumented)
cols?: ColumnBreakpoints | number;
// @deprecated (undocumented)
entity?: Entity;
// (undocumented)
variant?: 'gridItem';
}
@@ -15,7 +15,6 @@
*/
import {
Entity,
ANNOTATION_LOCATION,
DEFAULT_NAMESPACE,
stringifyEntityRef,
@@ -78,8 +77,6 @@ const useStyles = makeStyles({
* @public
*/
export interface AboutCardProps {
/** @deprecated The entity is now grabbed from context instead */
entity?: Entity;
variant?: InfoCardVariants;
}
@@ -14,7 +14,6 @@
* limitations under the License.
*/
import { Entity } from '@backstage/catalog-model';
import { useEntity } from '@backstage/plugin-catalog-react';
import LanguageIcon from '@material-ui/icons/Language';
import React from 'react';
@@ -26,8 +25,6 @@ import { InfoCard } from '@backstage/core-components';
/** @public */
export interface EntityLinksCardProps {
/** @deprecated The entity is now grabbed from context instead */
entity?: Entity;
cols?: ColumnBreakpoints | number;
variant?: 'gridItem';
}
+2 -5
View File
@@ -87,9 +87,7 @@ export const circleCIRouteRef: RouteRef<undefined>;
// Warning: (ae-missing-release-tag) "EntityCircleCIContent" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export const EntityCircleCIContent: (_props: {
entity?: Entity | undefined;
}) => JSX.Element;
export const EntityCircleCIContent: () => JSX.Element;
export { GitType };
@@ -100,9 +98,8 @@ const isCircleCIAvailable: (entity: Entity) => boolean;
export { isCircleCIAvailable };
export { isCircleCIAvailable as isPluginApplicableToEntity };
// Warning: (ae-forgotten-export) The symbol "Props" needs to be exported by the entry point index.d.ts
// Warning: (ae-missing-release-tag) "Router" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export const Router: (_props: Props) => JSX.Element;
export const Router: () => JSX.Element;
```
+1 -6
View File
@@ -27,12 +27,7 @@ import { MissingAnnotationEmptyState } from '@backstage/core-components';
export const isCircleCIAvailable = (entity: Entity) =>
Boolean(entity.metadata.annotations?.[CIRCLECI_ANNOTATION]);
type Props = {
/** @deprecated The entity is now grabbed from context instead */
entity?: Entity;
};
export const Router = (_props: Props) => {
export const Router = () => {
const { entity } = useEntity();
if (!isCircleCIAvailable(entity)) {
+2 -9
View File
@@ -149,9 +149,7 @@ export { cloudbuildPlugin as plugin };
// Warning: (ae-missing-release-tag) "EntityCloudbuildContent" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export const EntityCloudbuildContent: (_props: {
entity?: Entity | undefined;
}) => JSX.Element;
export const EntityCloudbuildContent: () => JSX.Element;
// Warning: (ae-missing-release-tag) "EntityLatestCloudbuildRunCard" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
@@ -159,7 +157,6 @@ export const EntityCloudbuildContent: (_props: {
export const EntityLatestCloudbuildRunCard: ({
branch,
}: {
entity?: Entity | undefined;
branch: string;
}) => JSX.Element;
@@ -169,7 +166,6 @@ export const EntityLatestCloudbuildRunCard: ({
export const EntityLatestCloudbuildsForBranchCard: ({
branch,
}: {
entity?: Entity | undefined;
branch: string;
}) => JSX.Element;
@@ -196,7 +192,6 @@ export { isCloudbuildAvailable as isPluginApplicableToEntity };
export const LatestWorkflowRunCard: ({
branch,
}: {
entity?: Entity | undefined;
branch: string;
}) => JSX.Element;
@@ -206,7 +201,6 @@ export const LatestWorkflowRunCard: ({
export const LatestWorkflowsForBranchCard: ({
branch,
}: {
entity?: Entity | undefined;
branch: string;
}) => JSX.Element;
@@ -256,11 +250,10 @@ export interface Results {
buildStepOutputs: string[];
}
// Warning: (ae-forgotten-export) The symbol "Props" needs to be exported by the entry point index.d.ts
// Warning: (ae-missing-release-tag) "Router" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export const Router: (_props: Props) => JSX.Element;
export const Router: () => JSX.Element;
// Warning: (ae-missing-release-tag) "Source" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
@@ -16,7 +16,6 @@
import React, { useEffect } from 'react';
import { useWorkflowRuns, WorkflowRun } from '../useWorkflowRuns';
import { WorkflowRunsTable } from '../WorkflowRunsTable';
import { Entity } from '@backstage/catalog-model';
import { useEntity } from '@backstage/plugin-catalog-react';
import { WorkflowRunStatus } from '../WorkflowRunStatus';
import { Theme, makeStyles, LinearProgress } from '@material-ui/core';
@@ -76,8 +75,6 @@ const WidgetContent = ({
export const LatestWorkflowRunCard = ({
branch = 'master',
}: {
/** @deprecated The entity is now grabbed from context instead */
entity?: Entity;
branch: string;
}) => {
const { entity } = useEntity();
@@ -109,8 +106,6 @@ export const LatestWorkflowRunCard = ({
export const LatestWorkflowsForBranchCard = ({
branch = 'master',
}: {
/** @deprecated The entity is now grabbed from context instead */
entity?: Entity;
branch: string;
}) => {
const { entity } = useEntity();
+1 -6
View File
@@ -26,12 +26,7 @@ import { MissingAnnotationEmptyState } from '@backstage/core-components';
export const isCloudbuildAvailable = (entity: Entity) =>
Boolean(entity.metadata.annotations?.[CLOUDBUILD_ANNOTATION]);
type Props = {
/** @deprecated The entity is now grabbed from context instead */
entity?: Entity;
};
export const Router = (_props: Props) => {
export const Router = () => {
const { entity } = useEntity();
if (!isCloudbuildAvailable(entity)) {
+4 -9
View File
@@ -31,9 +31,7 @@ export enum BuildStatus {
// Warning: (ae-missing-release-tag) "EntityGithubActionsContent" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export const EntityGithubActionsContent: (_props: {
entity?: Entity | undefined;
}) => JSX.Element;
export const EntityGithubActionsContent: () => JSX.Element;
// Warning: (ae-missing-release-tag) "EntityLatestGithubActionRunCard" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
@@ -42,7 +40,6 @@ export const EntityLatestGithubActionRunCard: ({
branch,
variant,
}: {
entity?: Entity | undefined;
branch: string;
variant?: InfoCardVariants | undefined;
}) => JSX.Element;
@@ -54,7 +51,6 @@ export const EntityLatestGithubActionsForBranchCard: ({
branch,
variant,
}: {
entity?: Entity | undefined;
branch: string;
variant?: InfoCardVariants | undefined;
}) => JSX.Element;
@@ -315,7 +311,7 @@ export type Jobs = {
export const LatestWorkflowRunCard: ({
branch,
variant,
}: Props_3) => JSX.Element;
}: Props_2) => JSX.Element;
// Warning: (ae-missing-release-tag) "LatestWorkflowsForBranchCard" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
@@ -323,7 +319,7 @@ export const LatestWorkflowRunCard: ({
export const LatestWorkflowsForBranchCard: ({
branch,
variant,
}: Props_3) => JSX.Element;
}: Props_2) => JSX.Element;
// Warning: (ae-missing-release-tag) "RecentWorkflowRunsCard" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
@@ -335,11 +331,10 @@ export const RecentWorkflowRunsCard: ({
variant,
}: Props) => JSX.Element;
// Warning: (ae-forgotten-export) The symbol "Props" needs to be exported by the entry point index.d.ts
// Warning: (ae-missing-release-tag) "Router" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export const Router: (_props: Props_2) => JSX.Element;
export const Router: () => JSX.Element;
// Warning: (ae-missing-release-tag) "Step" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
@@ -13,7 +13,6 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import { Entity } from '@backstage/catalog-model';
import { readGitHubIntegrationConfigs } from '@backstage/integration';
import { useEntity } from '@backstage/plugin-catalog-react';
import {
@@ -122,8 +121,6 @@ export const LatestWorkflowRunCard = ({
};
type Props = {
/** @deprecated The entity is now grabbed from context instead */
entity?: Entity;
branch: string;
variant?: InfoCardVariants;
};
@@ -75,7 +75,7 @@ describe('<RecentWorkflowRunsCard />', () => {
jest.resetAllMocks();
});
const renderSubject = (props: RecentWorkflowRunsCardProps = { entity }) =>
const renderSubject = (props: RecentWorkflowRunsCardProps = {}) =>
render(
<ThemeProvider theme={lightTheme}>
<MemoryRouter>
@@ -85,7 +85,7 @@ describe('<RecentWorkflowRunsCard />', () => {
[configApiRef, configApi],
]}
>
<EntityProvider entity={props.entity!}>
<EntityProvider entity={entity}>
<RecentWorkflowRunsCard {...props} />
</EntityProvider>
</TestApiProvider>
@@ -113,7 +113,7 @@ describe('<RecentWorkflowRunsCard />', () => {
it('requests only the required number of workflow runs', async () => {
const limit = 3;
renderSubject({ entity, limit });
renderSubject({ limit });
expect(useWorkflowRuns).toHaveBeenCalledWith(
expect.objectContaining({ initialPageSize: limit }),
);
@@ -128,7 +128,7 @@ describe('<RecentWorkflowRunsCard />', () => {
it('filters workflows by branch if one is specified', async () => {
const branch = 'master';
renderSubject({ entity, branch });
renderSubject({ branch });
expect(useWorkflowRuns).toHaveBeenCalledWith(
expect.objectContaining({ branch }),
);
@@ -13,7 +13,6 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import { Entity } from '@backstage/catalog-model';
import { readGitHubIntegrationConfigs } from '@backstage/integration';
import { useEntity } from '@backstage/plugin-catalog-react';
import React, { useEffect } from 'react';
@@ -34,8 +33,6 @@ import {
const firstLine = (message: string): string => message.split('\n')[0];
export type Props = {
/** @deprecated The entity is now grabbed from context instead */
entity?: Entity;
branch?: string;
dense?: boolean;
limit?: number;
@@ -26,12 +26,7 @@ import { MissingAnnotationEmptyState } from '@backstage/core-components';
export const isGithubActionsAvailable = (entity: Entity) =>
Boolean(entity.metadata.annotations?.[GITHUB_ACTIONS_ANNOTATION]);
type Props = {
/** @deprecated The entity is now grabbed from context instead */
entity?: Entity;
};
export const Router = (_props: Props) => {
export const Router = () => {
const { entity } = useEntity();
if (!isGithubActionsAvailable(entity)) {
+1 -3
View File
@@ -18,9 +18,7 @@ import { RouteRef } from '@backstage/core-plugin-api';
// Warning: (ae-missing-release-tag) "EntityJenkinsContent" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export const EntityJenkinsContent: (_props: {
entity?: Entity | undefined;
}) => JSX.Element;
export const EntityJenkinsContent: (_props: {}) => JSX.Element;
// Warning: (ae-missing-release-tag) "EntityLatestJenkinsRunCard" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
+1 -4
View File
@@ -27,10 +27,7 @@ export const isJenkinsAvailable = (entity: Entity) =>
Boolean(entity.metadata.annotations?.[JENKINS_ANNOTATION]) ||
Boolean(entity.metadata.annotations?.[LEGACY_JENKINS_ANNOTATION]);
type Props = {
/** @deprecated The entity is now grabbed from context instead */
entity?: Entity;
};
type Props = {};
export const Router = (_props: Props) => {
const { entity } = useEntity();
+1 -3
View File
@@ -12,9 +12,7 @@ import { RouteRef } from '@backstage/core-plugin-api';
// Warning: (ae-missing-release-tag) "EntityKafkaContent" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export const EntityKafkaContent: (_props: {
entity?: Entity | undefined;
}) => JSX.Element;
export const EntityKafkaContent: (_props: {}) => JSX.Element;
// Warning: (ae-missing-release-tag) "isPluginApplicableToEntity" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
+1 -4
View File
@@ -25,10 +25,7 @@ import { MissingAnnotationEmptyState } from '@backstage/core-components';
export const isPluginApplicableToEntity = (entity: Entity) =>
Boolean(entity.metadata.annotations?.[KAFKA_CONSUMER_GROUP_ANNOTATION]);
type Props = {
/** @deprecated The entity is now grabbed from context instead */
entity?: Entity;
};
type Props = {};
export const Router = (_props: Props) => {
const { entity } = useEntity();
+1 -3
View File
@@ -25,9 +25,7 @@ export const clusterLinksFormatters: Record<string, ClusterLinksFormatter>;
// Warning: (ae-missing-release-tag) "EntityKubernetesContent" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export const EntityKubernetesContent: (_props: {
entity?: Entity | undefined;
}) => JSX.Element;
export const EntityKubernetesContent: (_props: {}) => JSX.Element;
// Warning: (ae-forgotten-export) The symbol "FormatClusterLinkOptions" needs to be exported by the entry point index.d.ts
// Warning: (ae-missing-release-tag) "formatClusterLink" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
+1 -4
View File
@@ -32,10 +32,7 @@ export const isKubernetesAvailable = (entity: Entity) =>
entity.metadata.annotations?.[KUBERNETES_LABEL_SELECTOR_QUERY_ANNOTATION],
);
type Props = {
/** @deprecated The entity is now grabbed from context instead */
entity?: Entity;
};
type Props = {};
export const Router = (_props: Props) => {
const { entity } = useEntity();
+1 -3
View File
@@ -70,9 +70,7 @@ export const EntityLastLighthouseAuditCard: ({
// Warning: (ae-missing-release-tag) "EntityLighthouseContent" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export const EntityLighthouseContent: (_props: {
entity?: Entity | undefined;
}) => JSX.Element;
export const EntityLighthouseContent: (_props: {}) => JSX.Element;
// Warning: (ae-missing-release-tag) "FetchError" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
+1 -4
View File
@@ -36,10 +36,7 @@ export const Router = () => (
</Routes>
);
type Props = {
/** @deprecated The entity is now grabbed from context instead */
entity?: Entity;
};
type Props = {};
export const EmbeddedRouter = (_props: Props) => {
const { entity } = useEntity();
-11
View File
@@ -6,11 +6,8 @@
/// <reference types="react" />
import { BackstagePlugin } from '@backstage/core-plugin-api';
import { Entity } from '@backstage/catalog-model';
import { ExternalRouteRef } from '@backstage/core-plugin-api';
import { GroupEntity } from '@backstage/catalog-model';
import { InfoCardVariants } from '@backstage/core-components';
import { UserEntity } from '@backstage/catalog-model';
// Warning: (ae-missing-release-tag) "EntityGroupProfileCard" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
@@ -18,7 +15,6 @@ import { UserEntity } from '@backstage/catalog-model';
export const EntityGroupProfileCard: ({
variant,
}: {
entity?: GroupEntity | undefined;
variant?: InfoCardVariants | undefined;
}) => JSX.Element;
@@ -26,7 +22,6 @@ export const EntityGroupProfileCard: ({
//
// @public (undocumented)
export const EntityMembersListCard: (_props: {
entity?: GroupEntity | undefined;
memberDisplayTitle?: string | undefined;
pageSize?: number | undefined;
}) => JSX.Element;
@@ -38,7 +33,6 @@ export const EntityOwnershipCard: ({
variant,
entityFilterKind,
}: {
entity?: Entity | undefined;
variant?: InfoCardVariants | undefined;
entityFilterKind?: string[] | undefined;
}) => JSX.Element;
@@ -49,7 +43,6 @@ export const EntityOwnershipCard: ({
export const EntityUserProfileCard: ({
variant,
}: {
entity?: UserEntity | undefined;
variant?: InfoCardVariants | undefined;
}) => JSX.Element;
@@ -59,7 +52,6 @@ export const EntityUserProfileCard: ({
export const GroupProfileCard: ({
variant,
}: {
entity?: GroupEntity | undefined;
variant?: InfoCardVariants | undefined;
}) => JSX.Element;
@@ -67,7 +59,6 @@ export const GroupProfileCard: ({
//
// @public (undocumented)
export const MembersListCard: (_props: {
entity?: GroupEntity;
memberDisplayTitle?: string;
pageSize?: number;
}) => JSX.Element;
@@ -91,7 +82,6 @@ export const OwnershipCard: ({
variant,
entityFilterKind,
}: {
entity?: Entity | undefined;
variant?: InfoCardVariants | undefined;
entityFilterKind?: string[] | undefined;
}) => JSX.Element;
@@ -102,7 +92,6 @@ export const OwnershipCard: ({
export const UserProfileCard: ({
variant,
}: {
entity?: UserEntity | undefined;
variant?: InfoCardVariants | undefined;
}) => JSX.Element;
```
@@ -58,8 +58,6 @@ const CardTitle = ({ title }: { title: string }) => (
export const GroupProfileCard = ({
variant,
}: {
/** @deprecated The entity is now grabbed from context instead */
entity?: GroupEntity;
variant?: InfoCardVariants;
}) => {
const { entity: group } = useEntity<GroupEntity>();
@@ -109,8 +109,6 @@ const MemberComponent = ({ member }: { member: UserEntity }) => {
};
export const MembersListCard = (_props: {
/** @deprecated The entity is now grabbed from context instead */
entity?: GroupEntity;
memberDisplayTitle?: string;
pageSize?: number;
}) => {
@@ -131,8 +131,6 @@ export const OwnershipCard = ({
variant,
entityFilterKind,
}: {
/** @deprecated The entity is now grabbed from context instead */
entity?: Entity;
variant?: InfoCardVariants;
entityFilterKind?: string[];
}) => {
@@ -55,7 +55,7 @@ describe('UserSummary Test', () => {
const rendered = await renderWithEffects(
wrapInTestApp(
<EntityProvider entity={userEntity}>
<UserProfileCard entity={userEntity} variant="gridItem" />
<UserProfileCard variant="gridItem" />
</EntityProvider>,
{
mountedRoutes: {
@@ -51,8 +51,6 @@ const CardTitle = ({ title }: { title?: string }) =>
export const UserProfileCard = ({
variant,
}: {
/** @deprecated The entity is now grabbed from context instead */
entity?: UserEntity;
variant?: InfoCardVariants;
}) => {
const { entity: user } = useEntity<UserEntity>();
+3 -6
View File
@@ -12,18 +12,15 @@ import { Entity } from '@backstage/catalog-model';
import { IdentityApi } from '@backstage/core-plugin-api';
import { RouteRef } from '@backstage/core-plugin-api';
// Warning: (ae-forgotten-export) The symbol "Props" needs to be exported by the entry point index.d.ts
// Warning: (ae-missing-release-tag) "EntityPageRollbar" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export const EntityPageRollbar: (_props: Props) => JSX.Element;
export const EntityPageRollbar: () => JSX.Element;
// Warning: (ae-missing-release-tag) "EntityRollbarContent" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export const EntityRollbarContent: (_props: {
entity?: Entity | undefined;
}) => JSX.Element;
export const EntityRollbarContent: (_props: {}) => JSX.Element;
// Warning: (ae-missing-release-tag) "isPluginApplicableToEntity" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
@@ -103,5 +100,5 @@ export { rollbarPlugin };
// Warning: (ae-missing-release-tag) "Router" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export const Router: (_props: Props_2) => JSX.Element;
export const Router: (_props: Props) => JSX.Element;
```
@@ -14,17 +14,11 @@
* limitations under the License.
*/
import { Entity } from '@backstage/catalog-model';
import { useEntity } from '@backstage/plugin-catalog-react';
import React from 'react';
import { RollbarProject } from '../RollbarProject/RollbarProject';
type Props = {
/** @deprecated The entity is now grabbed from context instead */
entity?: Entity;
};
export const EntityPageRollbar = (_props: Props) => {
export const EntityPageRollbar = () => {
const { entity } = useEntity();
return <RollbarProject entity={entity} />;
+2 -5
View File
@@ -25,10 +25,7 @@ import { MissingAnnotationEmptyState } from '@backstage/core-components';
export const isPluginApplicableToEntity = (entity: Entity) =>
Boolean(entity.metadata.annotations?.[ROLLBAR_ANNOTATION]);
type Props = {
/** @deprecated The entity is now grabbed from context instead */
entity?: Entity;
};
type Props = {};
export const Router = (_props: Props) => {
const { entity } = useEntity();
@@ -39,7 +36,7 @@ export const Router = (_props: Props) => {
return (
<Routes>
<Route path="/" element={<EntityPageRollbar entity={entity} />} />
<Route path="/" element={<EntityPageRollbar />} />
</Routes>
);
};
+1 -3
View File
@@ -16,7 +16,6 @@ export const EntitySonarQubeCard: ({
variant,
duplicationRatings,
}: {
entity?: Entity | undefined;
variant?: InfoCardVariants | undefined;
duplicationRatings?:
| {
@@ -38,7 +37,6 @@ export const SonarQubeCard: ({
variant,
duplicationRatings,
}: {
entity?: Entity | undefined;
variant?: InfoCardVariants | undefined;
duplicationRatings?: DuplicationRating[] | undefined;
}) => JSX.Element;
@@ -52,5 +50,5 @@ export { sonarQubePlugin };
// Warnings were encountered during analysis:
//
// src/components/SonarQubeCard/SonarQubeCard.d.ts:11:5 - (ae-forgotten-export) The symbol "DuplicationRating" needs to be exported by the entry point index.d.ts
// src/components/SonarQubeCard/SonarQubeCard.d.ts:9:5 - (ae-forgotten-export) The symbol "DuplicationRating" needs to be exported by the entry point index.d.ts
```
@@ -14,7 +14,6 @@
* limitations under the License.
*/
import { Entity } from '@backstage/catalog-model';
import { useEntity } from '@backstage/plugin-catalog-react';
import { Chip, Grid } from '@material-ui/core';
import { makeStyles } from '@material-ui/core/styles';
@@ -90,7 +89,6 @@ export const SonarQubeCard = ({
variant = 'gridItem',
duplicationRatings = defaultDuplicationRatings,
}: {
entity?: Entity;
variant?: InfoCardVariants;
duplicationRatings?: DuplicationRating[];
}) => {
+2 -4
View File
@@ -169,9 +169,7 @@ export const EntityListDocsTable: {
// Warning: (ae-missing-release-tag) "EntityTechdocsContent" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export const EntityTechdocsContent: (_props: {
entity?: Entity | undefined;
}) => JSX.Element;
export const EntityTechdocsContent: (_props: {}) => JSX.Element;
// Warning: (ae-missing-release-tag) "isTechDocsAvailable" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
@@ -395,5 +393,5 @@ export class TechDocsStorageClient implements TechDocsStorageApi {
//
// src/home/components/EntityListDocsTable.d.ts:11:5 - (ae-forgotten-export) The symbol "columnFactories" needs to be exported by the entry point index.d.ts
// src/home/components/EntityListDocsTable.d.ts:12:5 - (ae-forgotten-export) The symbol "actionFactories" needs to be exported by the entry point index.d.ts
// src/plugin.d.ts:29:5 - (ae-forgotten-export) The symbol "TabsConfig" needs to be exported by the entry point index.d.ts
// src/plugin.d.ts:27:5 - (ae-forgotten-export) The symbol "TabsConfig" needs to be exported by the entry point index.d.ts
```
+1 -4
View File
@@ -40,10 +40,7 @@ export const Router = () => {
);
};
type Props = {
/** @deprecated The entity is now grabbed from context instead */
entity?: Entity;
};
type Props = {};
export const EmbeddedDocsRouter = (_props: Props) => {
const { entity } = useEntity();