From cf82fb1c44b7c547c2454be047a1363c0e7d7f56 Mon Sep 17 00:00:00 2001 From: blam Date: Thu, 24 Feb 2022 15:12:44 +0100 Subject: [PATCH 1/8] try and bump node-gyp Signed-off-by: blam --- .github/workflows/verify_e2e-windows.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/verify_e2e-windows.yml b/.github/workflows/verify_e2e-windows.yml index b4347898e6..866cd7b9b2 100644 --- a/.github/workflows/verify_e2e-windows.yml +++ b/.github/workflows/verify_e2e-windows.yml @@ -42,6 +42,11 @@ jobs: uses: actions/setup-node@v1 with: node-version: ${{ matrix.node-version }} + - name: install latest nodegyp + shell: powershell + run: | + npm install --global node-gyp@latest + npm prefix -g | % {npm config set node_gyp "$_\node_modules\node-gyp\bin\node-gyp.js"} - name: Add msbuild to PATH uses: microsoft/setup-msbuild@v1.0.2 - name: setup chrome From 53ab4cb558b4d904184cdc67bf7594191c3aa38b Mon Sep 17 00:00:00 2001 From: blam Date: Thu, 24 Feb 2022 15:21:24 +0100 Subject: [PATCH 2/8] run when workflow is changed Signed-off-by: blam --- .github/workflows/verify_e2e-windows.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/verify_e2e-windows.yml b/.github/workflows/verify_e2e-windows.yml index 866cd7b9b2..380d74521c 100644 --- a/.github/workflows/verify_e2e-windows.yml +++ b/.github/workflows/verify_e2e-windows.yml @@ -5,7 +5,7 @@ name: E2E Test Windows on: pull_request: paths: - - '.github/workflows/e2e-win.yml' + - '.github/workflows/verify_e2e-windows.yml' - 'packages/cli/**' - 'packages/e2e-test/**' - 'packages/create-app/**' From 4ad2d7104cdfaa677d93a7d211ce5b07badc245d Mon Sep 17 00:00:00 2001 From: blam Date: Thu, 24 Feb 2022 15:47:07 +0100 Subject: [PATCH 3/8] chore: force paricular builds on windows Signed-off-by: blam --- .github/workflows/verify_e2e-windows.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/verify_e2e-windows.yml b/.github/workflows/verify_e2e-windows.yml index 380d74521c..1a79649448 100644 --- a/.github/workflows/verify_e2e-windows.yml +++ b/.github/workflows/verify_e2e-windows.yml @@ -21,7 +21,7 @@ jobs: strategy: matrix: os: [windows-latest] - node-version: [14.x, 16.x] + node-version: ["14.18.3", "16.13.2"] env: CI: true From 960a9604b9e3d98505b916bb9db08284257691a6 Mon Sep 17 00:00:00 2001 From: blam Date: Thu, 24 Feb 2022 15:48:46 +0100 Subject: [PATCH 4/8] removing nodegyp bump Signed-off-by: blam --- .github/workflows/verify_e2e-windows.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/verify_e2e-windows.yml b/.github/workflows/verify_e2e-windows.yml index 1a79649448..7da6b92d66 100644 --- a/.github/workflows/verify_e2e-windows.yml +++ b/.github/workflows/verify_e2e-windows.yml @@ -42,11 +42,7 @@ jobs: uses: actions/setup-node@v1 with: node-version: ${{ matrix.node-version }} - - name: install latest nodegyp - shell: powershell - run: | - npm install --global node-gyp@latest - npm prefix -g | % {npm config set node_gyp "$_\node_modules\node-gyp\bin\node-gyp.js"} + - name: Add msbuild to PATH uses: microsoft/setup-msbuild@v1.0.2 - name: setup chrome From 22747ec473baa98775d76e228a1529e26257f9fb Mon Sep 17 00:00:00 2001 From: blam Date: Thu, 24 Feb 2022 15:52:51 +0100 Subject: [PATCH 5/8] chore: fix prettier Signed-off-by: blam --- .github/workflows/verify_e2e-windows.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/verify_e2e-windows.yml b/.github/workflows/verify_e2e-windows.yml index 7da6b92d66..02595ab1b5 100644 --- a/.github/workflows/verify_e2e-windows.yml +++ b/.github/workflows/verify_e2e-windows.yml @@ -21,7 +21,7 @@ jobs: strategy: matrix: os: [windows-latest] - node-version: ["14.18.3", "16.13.2"] + node-version: ['14.18.3', '16.13.2'] env: CI: true @@ -42,7 +42,7 @@ jobs: uses: actions/setup-node@v1 with: node-version: ${{ matrix.node-version }} - + - name: Add msbuild to PATH uses: microsoft/setup-msbuild@v1.0.2 - name: setup chrome From 7c52c943cbaab52f9b6c17315ed60d99642abb98 Mon Sep 17 00:00:00 2001 From: blam Date: Thu, 24 Feb 2022 16:07:08 +0100 Subject: [PATCH 6/8] chore: clean cache Signed-off-by: blam --- .github/workflows/verify_e2e-windows.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/verify_e2e-windows.yml b/.github/workflows/verify_e2e-windows.yml index 02595ab1b5..dada573c7c 100644 --- a/.github/workflows/verify_e2e-windows.yml +++ b/.github/workflows/verify_e2e-windows.yml @@ -47,6 +47,8 @@ jobs: uses: microsoft/setup-msbuild@v1.0.2 - name: setup chrome uses: browser-actions/setup-chrome@latest + - name: yarn cache clean + run: yarn cache clean - name: yarn install run: yarn install --frozen-lockfile From 07abd18f3d642aed4cd1873b7d3389c3c32e38a6 Mon Sep 17 00:00:00 2001 From: blam Date: Thu, 24 Feb 2022 16:26:57 +0100 Subject: [PATCH 7/8] chore: try this fix? Signed-off-by: blam --- .github/workflows/verify_e2e-windows.yml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/workflows/verify_e2e-windows.yml b/.github/workflows/verify_e2e-windows.yml index dada573c7c..23d140c230 100644 --- a/.github/workflows/verify_e2e-windows.yml +++ b/.github/workflows/verify_e2e-windows.yml @@ -20,8 +20,8 @@ jobs: strategy: matrix: - os: [windows-latest] - node-version: ['14.18.3', '16.13.2'] + os: [windows-2019] + node-version: [14.x, 16.x] env: CI: true @@ -42,13 +42,10 @@ jobs: uses: actions/setup-node@v1 with: node-version: ${{ matrix.node-version }} - - name: Add msbuild to PATH uses: microsoft/setup-msbuild@v1.0.2 - name: setup chrome uses: browser-actions/setup-chrome@latest - - name: yarn cache clean - run: yarn cache clean - name: yarn install run: yarn install --frozen-lockfile From dc35bd79eac7a23882c4f7d9c97a0bae89705df9 Mon Sep 17 00:00:00 2001 From: blam Date: Thu, 24 Feb 2022 16:42:21 +0100 Subject: [PATCH 8/8] chore: updating the verify workflow too Signed-off-by: blam --- .github/workflows/verify_windows.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/verify_windows.yml b/.github/workflows/verify_windows.yml index 55959510d3..c134c9f202 100644 --- a/.github/workflows/verify_windows.yml +++ b/.github/workflows/verify_windows.yml @@ -7,7 +7,7 @@ on: jobs: build: - runs-on: windows-latest + runs-on: windows-2019 strategy: matrix: