From 21becc9441917382be4320815ff3ec557b192b91 Mon Sep 17 00:00:00 2001 From: Dominik Henneke Date: Mon, 30 Aug 2021 09:51:07 +0200 Subject: [PATCH] Don't explicitly set target but instead fallback to the logic in the Link component Signed-off-by: Dominik Henneke --- plugins/catalog/src/components/AboutCard/AboutCard.test.tsx | 1 - plugins/catalog/src/components/AboutCard/AboutCard.tsx | 1 - 2 files changed, 2 deletions(-) diff --git a/plugins/catalog/src/components/AboutCard/AboutCard.test.tsx b/plugins/catalog/src/components/AboutCard/AboutCard.test.tsx index d79fa8e3ae..6c85ebcab7 100644 --- a/plugins/catalog/src/components/AboutCard/AboutCard.test.tsx +++ b/plugins/catalog/src/components/AboutCard/AboutCard.test.tsx @@ -170,7 +170,6 @@ describe('', () => { 'href', 'https://github.com/backstage/backstage/edit/master/software.yaml', ); - expect(editLink).toHaveAttribute('target', '_blank'); }); it('renders without "view source" link', async () => { diff --git a/plugins/catalog/src/components/AboutCard/AboutCard.tsx b/plugins/catalog/src/components/AboutCard/AboutCard.tsx index c554581713..582b464afa 100644 --- a/plugins/catalog/src/components/AboutCard/AboutCard.tsx +++ b/plugins/catalog/src/components/AboutCard/AboutCard.tsx @@ -153,7 +153,6 @@ export function AboutCard({ variant }: AboutCardProps) { disabled={!entityMetadataEditUrl} title="Edit Metadata" to={entityMetadataEditUrl ?? '#'} - target="_blank" >