From 21aa93ad46a49b49175a27c6c9bc39dcf3de6231 Mon Sep 17 00:00:00 2001
From: Fabian Chong <fabian.chong@grab.com>
Date: Wed, 16 Sep 2020 14:56:28 +0800
Subject: [PATCH] update templatingTask test

---
 packages/cli/src/commands/create-plugin/createPlugin.ts | 5 +----
 packages/cli/src/lib/tasks.test.ts                      | 5 +++++
 packages/cli/templates/default-plugin/package.json.hbs  | 2 +-
 3 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/packages/cli/src/commands/create-plugin/createPlugin.ts b/packages/cli/src/commands/create-plugin/createPlugin.ts
index 9b97746c0e..00539a4b33 100644
--- a/packages/cli/src/commands/create-plugin/createPlugin.ts
+++ b/packages/cli/src/commands/create-plugin/createPlugin.ts
@@ -228,10 +228,7 @@ export default async (cmd: Command) => {
     ? `@${cmd.scope.replace(/^@/, '')}/plugin-${answers.id}`
     : `plugin-${answers.id}`;
   const scopeName = cmd.scope ? `@${cmd.scope.replace(/^@/, '')}` : '';
-  const npmRegistry =
-    cmd.npmRegistry && cmd.scope
-      ? `"${scopeName}:registry": "${cmd.npmRegistry}"`
-      : '';
+  const npmRegistry = cmd.npmRegistry && cmd.scope ? cmd.npmRegistry : '';
   const privatePackage = cmd.private === false ? false : true;
   const isMonoRepo = await fs.pathExists(paths.resolveTargetRoot('lerna.json'));
   const appPackage = paths.resolveTargetRoot('packages/app');
diff --git a/packages/cli/src/lib/tasks.test.ts b/packages/cli/src/lib/tasks.test.ts
index 871d5a4d37..2a2f111d4b 100644
--- a/packages/cli/src/lib/tasks.test.ts
+++ b/packages/cli/src/lib/tasks.test.ts
@@ -37,6 +37,11 @@ describe('templatingTask', () => {
     try {
       await templatingTask(tmplDir, destDir, {
         version: '0.0.0',
+        backstageVersiona: '0.0.0',
+        scopeName: '@backstage',
+        name: '@backstage/plugin-test',
+        privatePackage: true,
+        npmRegistry: 'https://registry.npmjs.org/',
       });
 
       await expect(
diff --git a/packages/cli/templates/default-plugin/package.json.hbs b/packages/cli/templates/default-plugin/package.json.hbs
index 5e59b6fa0d..043e54b914 100644
--- a/packages/cli/templates/default-plugin/package.json.hbs
+++ b/packages/cli/templates/default-plugin/package.json.hbs
@@ -7,7 +7,7 @@
 {{#if privatePackage}}  "private": {{privatePackage}},
 {{/if}}
   "publishConfig": {
-{{#if npmRegistry}}    {{{npmRegistry}}},
+{{#if npmRegistry}}    "{{scopeName}}:registry": "{{npmRegistry}}",
 {{/if}}
     "access": "public",
     "main": "dist/index.esm.js",