feat(catalog-backend): stop checking almost-similar names of entities

packages/catalog-model/src/validation/CommonValidatorFunctions.test.ts

@@ -161,18 +161,4 @@ describe('CommonValidatorFunctions', () => {
   ])(`isValidDnsLabel %p ? %p`, (value, result) => {
     expect(CommonValidatorFunctions.isValidDnsLabel(value)).toBe(result);
   });
-
-  it.each([
-    ['', ''],
-    ['a', 'a'],
-    ['a-b', 'ab'],
-    ['-a-b', 'ab'],
-    ['a_b', 'ab'],
-    [`${'a'.repeat(6000)}`, `${'a'.repeat(6000)}`],
-    ['_:;>!"#€', ''],
-  ])(`normalizeToLowercaseAlphanum %p ? %p`, (value, result) => {
-    expect(CommonValidatorFunctions.normalizeToLowercaseAlphanum(value)).toBe(
-      result,
-    );
-  });
 });

packages/catalog-model/src/validation/CommonValidatorFunctions.ts

@@ -92,17 +92,4 @@ export class CommonValidatorFunctions {
       /^[a-z0-9]+(\-[a-z0-9]+)*$/.test(value)
     );
   }
-
-  /**
-   * Normalizes by keeping only a-z, A-Z, and 0-9; and converts to lowercase.
-   *
-   * @param value The value to normalize
-   */
-  static normalizeToLowercaseAlphanum(value: string): string {
-    return value
-      .split('')
-      .filter(x => /[a-zA-Z0-9]/.test(x))
-      .join('')
-      .toLowerCase();
-  }
 }

packages/catalog-model/src/validation/makeValidator.ts

@@ -23,7 +23,6 @@ const defaultValidators: Validators = {
   isValidKind: KubernetesValidatorFunctions.isValidKind,
   isValidEntityName: KubernetesValidatorFunctions.isValidObjectName,
   isValidNamespace: KubernetesValidatorFunctions.isValidNamespace,
-  normalizeEntityName: CommonValidatorFunctions.normalizeToLowercaseAlphanum,
   isValidLabelKey: KubernetesValidatorFunctions.isValidLabelKey,
   isValidLabelValue: KubernetesValidatorFunctions.isValidLabelValue,
   isValidAnnotationKey: KubernetesValidatorFunctions.isValidAnnotationKey,

packages/catalog-model/src/validation/types.ts

@@ -19,7 +19,6 @@ export type Validators = {
   isValidKind(value: any): boolean;
   isValidEntityName(value: any): boolean;
   isValidNamespace(value: any): boolean;
-  normalizeEntityName(value: string): string;
   isValidLabelKey(value: any): boolean;
   isValidLabelValue(value: any): boolean;
   isValidAnnotationKey(value: any): boolean;