From 214f2da8c17a28996a686341e7fb822dc720839a Mon Sep 17 00:00:00 2001 From: Karthikeyan Perumal <7823084+karthikeyanjp@users.noreply.github.com> Date: Fri, 19 Jan 2024 17:58:16 -0600 Subject: [PATCH] fix(Error): resolve misleading HTTP status code 501 in Error page. Fixes #22159 Signed-off-by: Karthikeyan Perumal <7823084+karthikeyanjp@users.noreply.github.com> --- .changeset/soft-balloons-relax.md | 6 ++++++ packages/app-defaults/src/defaults/components.tsx | 2 +- packages/core-components/src/layout/ErrorPage/ErrorPage.tsx | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) create mode 100644 .changeset/soft-balloons-relax.md diff --git a/.changeset/soft-balloons-relax.md b/.changeset/soft-balloons-relax.md new file mode 100644 index 0000000000..3fae8984a3 --- /dev/null +++ b/.changeset/soft-balloons-relax.md @@ -0,0 +1,6 @@ +--- +'@backstage/core-components': patch +'@backstage/app-defaults': patch +--- + +Fix invalid HTTP status code 501 in Error Page diff --git a/packages/app-defaults/src/defaults/components.tsx b/packages/app-defaults/src/defaults/components.tsx index 93a5d9cd50..1e2fddca07 100644 --- a/packages/app-defaults/src/defaults/components.tsx +++ b/packages/app-defaults/src/defaults/components.tsx @@ -49,7 +49,7 @@ const DefaultBootErrorPage = ({ step, error }: BootErrorPageProps) => { // TODO: figure out a nicer way to handle routing on the error page, when it can be done. return ( - + ); }; diff --git a/packages/core-components/src/layout/ErrorPage/ErrorPage.tsx b/packages/core-components/src/layout/ErrorPage/ErrorPage.tsx index 73acf1f650..4639e8de59 100644 --- a/packages/core-components/src/layout/ErrorPage/ErrorPage.tsx +++ b/packages/core-components/src/layout/ErrorPage/ErrorPage.tsx @@ -24,7 +24,7 @@ import { useSupportConfig } from '../../hooks'; import { MicDrop } from './MicDrop'; interface IErrorPageProps { - status: string; + status?: string; statusMessage: string; additionalInfo?: React.ReactNode; supportUrl?: string;