From 213664e85bea5cf074d5fc9ab686cb692557d177 Mon Sep 17 00:00:00 2001 From: zcmander Date: Fri, 13 Sep 2024 14:57:05 +0300 Subject: [PATCH] fix(cache): pass useRedisSets option to KeyvRedis cache storage adapter Co-authored-by: Patrik Oldsberg Signed-off-by: zcmander --- .changeset/clever-numbers-impress.md | 5 +++++ .../backend-defaults/src/entrypoints/cache/CacheManager.ts | 4 +++- 2 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 .changeset/clever-numbers-impress.md diff --git a/.changeset/clever-numbers-impress.md b/.changeset/clever-numbers-impress.md new file mode 100644 index 0000000000..feb1a0438c --- /dev/null +++ b/.changeset/clever-numbers-impress.md @@ -0,0 +1,5 @@ +--- +'@backstage/backend-defaults': patch +--- + +Fixed an issue where the `useRedisSets` configuration for the cache service would have no effect. diff --git a/packages/backend-defaults/src/entrypoints/cache/CacheManager.ts b/packages/backend-defaults/src/entrypoints/cache/CacheManager.ts index 41fe595123..a54959f155 100644 --- a/packages/backend-defaults/src/entrypoints/cache/CacheManager.ts +++ b/packages/backend-defaults/src/entrypoints/cache/CacheManager.ts @@ -147,7 +147,9 @@ export class CacheManager { let store: typeof KeyvRedis | undefined; return (pluginId, defaultTtl) => { if (!store) { - store = new KeyvRedis(this.connection); + store = new KeyvRedis(this.connection, { + useRedisSets: this.useRedisSets, + }); // Always provide an error handler to avoid stopping the process store.on('error', (err: Error) => { this.logger?.error('Failed to create redis cache client', err);