paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 28 Packages Projects Releases Wiki Activity

Duplicate IconLink instead of moving to core

Browse Source 
Signed-off-by: James Turley <jamesturley1905@googlemail.com>
This commit is contained in:
James Turley
2021-04-06 15:37:32 +01:00
parent 9fdbc1e216
commit 20ae6504c7
8 changed files with 102 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/core/src/components/IconLink/IconLink.test.tsx
-38
View File
@@ -1,38 +0,0 @@
/*
* Copyright 2020 Spotify AB
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import { lightTheme } from '@backstage/theme';
import { ThemeProvider } from '@material-ui/core';
import CloudIcon from '@material-ui/icons/Cloud';
import { render } from '@testing-library/react';
import React from 'react';
import { IconLink } from './IconLink';
describe('IconLink', () => {
it('should render an icon link', () => {
const rendered = render(
<ThemeProvider theme={lightTheme}>
<IconLink
href="https://example.com"
text="I am Link"
Icon={CloudIcon}
/>
</ThemeProvider>,
);
expect(rendered.queryByText('I am Link')).toBeInTheDocument();
});
});
packages/core/src/components/IconLink/IconLink.tsx
-59
View File
@@ -1,59 +0,0 @@
/*
* Copyright 2020 Spotify AB
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import React from 'react';
import { IconComponent } from '@backstage/core-api';
import { Grid, LinkProps, makeStyles, Typography } from '@material-ui/core';
import LanguageIcon from '@material-ui/icons/Language';
import { Link } from '../Link';
const useStyles = makeStyles({
svgIcon: {
display: 'inline-block',
'& svg': {
display: 'inline-block',
fontSize: 'inherit',
verticalAlign: 'baseline',
},
},
});
export const IconLink = (
props: {
href: string;
text?: string;
Icon?: IconComponent;
} & LinkProps,
) => {
const { href, text, Icon, ...linkProps } = props;
const classes = useStyles();
return (
<Grid container direction="row" spacing={1}>
<Grid item>
<Typography component="div" className={classes.svgIcon}>
{Icon ? <Icon /> : <LanguageIcon />}
</Typography>
</Grid>
<Grid item>
<Link to={href} {...linkProps}>
{text || href}
</Link>
</Grid>
</Grid>
);
};
packages/core/src/components/IconLink/index.ts
-17
View File
@@ -1,17 +0,0 @@
/*
* Copyright 2020 Spotify AB
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
export { IconLink } from './IconLink';
packages/core/src/components/index.ts
-1
View File
@@ -26,7 +26,6 @@ export * from './ResponseErrorPanel';
export * from './FeatureDiscovery';
export * from './HeaderIconLinkRow';
export * from './HorizontalScrollGrid';
export * from './IconLink';
export * from './Lifecycle';
export * from './Link';
export * from './MarkdownContent';