From 9fe7b5b68dea6f96a4ae5e860a59a6d8f6abb055 Mon Sep 17 00:00:00 2001 From: Florian JUDITH Date: Fri, 20 Oct 2023 00:42:51 -0400 Subject: [PATCH 1/4] Added node-gyp module dependency Signed-off-by: Florian JUDITH --- packages/create-app/package.json | 1 + yarn.lock | 1 + 2 files changed, 2 insertions(+) diff --git a/packages/create-app/package.json b/packages/create-app/package.json index 597908c894..7fdf858605 100644 --- a/packages/create-app/package.json +++ b/packages/create-app/package.json @@ -38,6 +38,7 @@ "fs-extra": "10.1.0", "handlebars": "^4.7.3", "inquirer": "^8.2.0", + "node-gyp": "^9.4.0", "ora": "^5.3.0", "recursive-readdir": "^2.2.2" }, diff --git a/yarn.lock b/yarn.lock index 8561896b24..ded61608b6 100644 --- a/yarn.lock +++ b/yarn.lock @@ -4183,6 +4183,7 @@ __metadata: handlebars: ^4.7.3 inquirer: ^8.2.0 mock-fs: ^5.2.0 + node-gyp: ^9.4.0 nodemon: ^3.0.1 ora: ^5.3.0 recursive-readdir: ^2.2.2 From e6b7ab8d2bc179d543648e143fa1f2eecb08809e Mon Sep 17 00:00:00 2001 From: Florian JUDITH Date: Fri, 20 Oct 2023 00:48:07 -0400 Subject: [PATCH 2/4] Added changeset Signed-off-by: Florian JUDITH --- .changeset/thick-boats-decide.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/thick-boats-decide.md diff --git a/.changeset/thick-boats-decide.md b/.changeset/thick-boats-decide.md new file mode 100644 index 0000000000..e258962ecd --- /dev/null +++ b/.changeset/thick-boats-decide.md @@ -0,0 +1,5 @@ +--- +'@backstage/create-app': patch +--- + +Added missing node-gyp dependency to fix Docker image build From 46c3cf223d1a43a11902488aa6be5e221cbfeee2 Mon Sep 17 00:00:00 2001 From: Florian JUDITH Date: Fri, 20 Oct 2023 17:00:21 -0400 Subject: [PATCH 3/4] Revert "Added node-gyp module dependency" This reverts commit ae83e81512e608afd530bc82403d0723ecbd8d6a. Signed-off-by: Florian JUDITH --- packages/create-app/package.json | 1 - yarn.lock | 1 - 2 files changed, 2 deletions(-) diff --git a/packages/create-app/package.json b/packages/create-app/package.json index 7fdf858605..597908c894 100644 --- a/packages/create-app/package.json +++ b/packages/create-app/package.json @@ -38,7 +38,6 @@ "fs-extra": "10.1.0", "handlebars": "^4.7.3", "inquirer": "^8.2.0", - "node-gyp": "^9.4.0", "ora": "^5.3.0", "recursive-readdir": "^2.2.2" }, diff --git a/yarn.lock b/yarn.lock index ded61608b6..8561896b24 100644 --- a/yarn.lock +++ b/yarn.lock @@ -4183,7 +4183,6 @@ __metadata: handlebars: ^4.7.3 inquirer: ^8.2.0 mock-fs: ^5.2.0 - node-gyp: ^9.4.0 nodemon: ^3.0.1 ora: ^5.3.0 recursive-readdir: ^2.2.2 From 0f29f1c5167157886c0bc8b578bf96c5bf983819 Mon Sep 17 00:00:00 2001 From: Florian JUDITH Date: Tue, 24 Oct 2023 06:30:54 -0400 Subject: [PATCH 4/4] Added "node-gyp" dependency to resolve docker image build Signed-off-by: Florian JUDITH --- .../templates/default-app/packages/backend/package.json.hbs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/create-app/templates/default-app/packages/backend/package.json.hbs b/packages/create-app/templates/default-app/packages/backend/package.json.hbs index cb358db911..1469271132 100644 --- a/packages/create-app/templates/default-app/packages/backend/package.json.hbs +++ b/packages/create-app/templates/default-app/packages/backend/package.json.hbs @@ -39,7 +39,8 @@ "express": "^4.17.1", "express-promise-router": "^4.1.0", "pg": "^8.3.0", - "winston": "^3.2.1" + "winston": "^3.2.1", + "node-gyp": "^9.0.0" }, "devDependencies": { "@backstage/cli": "^{{version '@backstage/cli'}}",