Merge pull request #22509 from backstage/rugvip/notree

frontend-app-api: remove experimental createExtensionTree API
This commit is contained in:
Ben Lambert
2024-01-25 15:45:33 +01:00
committed by GitHub
6 changed files with 9 additions and 169 deletions
+2 -23
View File
@@ -27,12 +27,7 @@ import {
RELATION_PROVIDES_API,
} from '@backstage/catalog-model';
import { createApp } from '@backstage/app-defaults';
import {
AppRouter,
ConfigReader,
defaultConfigLoader,
FlatRoutes,
} from '@backstage/core-app-api';
import { AppRouter, FlatRoutes } from '@backstage/core-app-api';
import {
AlertDisplay,
OAuthRequestDialog,
@@ -112,10 +107,6 @@ import { PuppetDbPage } from '@backstage/plugin-puppetdb';
import { DevToolsPage } from '@backstage/plugin-devtools';
import { customDevToolsPage } from './components/devtools/CustomDevToolsPage';
import { CatalogUnprocessedEntitiesPage } from '@backstage/plugin-catalog-unprocessed-entities';
import {
createExtensionTree,
ExtensionTree,
} from '@backstage/frontend-app-api';
const app = createApp({
apis,
@@ -162,14 +153,6 @@ const app = createApp({
},
});
/* HIGHLY EXPERIMENTAL. DO NOT USE THIS IN YOUR APP */
let extensionTree: ExtensionTree | undefined;
if (process.env.NODE_ENV !== 'test') {
extensionTree = createExtensionTree({
config: ConfigReader.fromConfigs(await defaultConfigLoader()),
});
}
const routes = (
<FlatRoutes>
<Route path="/" element={<Navigate to="catalog" />} />
@@ -258,10 +241,6 @@ const routes = (
path="/tech-radar"
element={<TechRadarPage width={1500} height={800} />}
/>
{
/* HIGHLY EXPERIMENTAL. DO NOT USE THIS IN YOUR APP */ extensionTree?.getRootRoutes() ??
null
}
<Route path="/lighthouse" element={<LighthousePage />} />
<Route path="/api-docs" element={<ApiExplorerPage />} />
<Route path="/gcp-projects" element={<GcpProjectsPage />} />
@@ -302,7 +281,7 @@ export default app.createRoot(
<OAuthRequestDialog />
<AppRouter>
<VisitListener />
<Root extensionTree={extensionTree}>{routes}</Root>
<Root>{routes}</Root>
</AppRouter>
</>,
);
+1 -9
View File
@@ -52,7 +52,6 @@ import { SearchModal } from '../search/SearchModal';
import Score from '@material-ui/icons/Score';
import { useApp } from '@backstage/core-plugin-api';
import BuildIcon from '@material-ui/icons/Build';
import { ExtensionTree } from '@backstage/frontend-app-api';
const useSidebarLogoStyles = makeStyles({
root: {
@@ -82,10 +81,7 @@ const SidebarLogo = () => {
);
};
export const Root = ({
children,
extensionTree,
}: PropsWithChildren<{ extensionTree?: ExtensionTree }>) => (
export const Root = ({ children }: PropsWithChildren<{}>) => (
<SidebarPage>
<Sidebar>
<SidebarLogo />
@@ -166,10 +162,6 @@ export const Root = ({
to="cost-insights"
text="Cost Insights"
/>
{
/* HIGHLY EXPERIMENTAL. DO NOT USE THIS IN YOUR APP */ extensionTree?.getSidebarItems() ??
null
}
<SidebarItem icon={Score} to="score-board" text="Score board" />
</SidebarScrollWrapper>
<SidebarDivider />