From 1f70704580eb12b11e10bd1db3a50de89b04fdd3 Mon Sep 17 00:00:00 2001
From: Eric Voshall <6836155+ericvoshall@users.noreply.github.com>
Date: Wed, 11 May 2022 14:29:05 -0400
Subject: [PATCH] Code review updates
Signed-off-by: Eric Voshall <6836155+ericvoshall@users.noreply.github.com>
---
.changeset/blue-roses-give.md | 8 ++++++++
.changeset/olive-rats-rest.md | 7 +++++++
.changeset/quick-ladybugs-try.md | 7 +++++++
.changeset/short-jokes-applaud.md | 11 +++--------
.../packages/app/src/components/Root/Root.tsx | 1 +
5 files changed, 26 insertions(+), 8 deletions(-)
create mode 100644 .changeset/blue-roses-give.md
create mode 100644 .changeset/olive-rats-rest.md
create mode 100644 .changeset/quick-ladybugs-try.md
diff --git a/.changeset/blue-roses-give.md b/.changeset/blue-roses-give.md
new file mode 100644
index 0000000000..9a54e9054c
--- /dev/null
+++ b/.changeset/blue-roses-give.md
@@ -0,0 +1,8 @@
+---
+'@backstage/plugin-catalog-react': minor
+---
+
+Accessibility updates:
+
+- Wrapped the `EntityLifecyclePicker`, `EntityOwnerPicker`, `EntityTagPicker`, in `label` elements
+- Changed group name `Typography` component to `span` (from default `h6`), added `aria-label` to the `List` component, and `role` of `menuitem` to the container of the `MenuItem` component
diff --git a/.changeset/olive-rats-rest.md b/.changeset/olive-rats-rest.md
new file mode 100644
index 0000000000..6845b31e59
--- /dev/null
+++ b/.changeset/olive-rats-rest.md
@@ -0,0 +1,7 @@
+---
+'@backstage/create-app': minor
+---
+
+Accessibility updates:
+
+- Added `aria-label` to the sidebar Logo link
diff --git a/.changeset/quick-ladybugs-try.md b/.changeset/quick-ladybugs-try.md
new file mode 100644
index 0000000000..ec5f3e25f0
--- /dev/null
+++ b/.changeset/quick-ladybugs-try.md
@@ -0,0 +1,7 @@
+---
+'@backstage/plugin-catalog': minor
+---
+
+Accessibility updates:
+
+- Added screen reader elements to describe default table `Action` buttons
diff --git a/.changeset/short-jokes-applaud.md b/.changeset/short-jokes-applaud.md
index 2a833e591d..b1b4f55858 100644
--- a/.changeset/short-jokes-applaud.md
+++ b/.changeset/short-jokes-applaud.md
@@ -1,13 +1,8 @@
---
-'@backstage/core-components': minor
-'@backstage/plugin-catalog': minor
-'@backstage/plugin-catalog-react': minor
+'@backstage/core-components': patch
---
Accessibility updates:
-- Added `aria-label` to the `Select` component in `core-components`
-- Changed heading level used in the header of `Table` component in `core-components`
-- Added screen reader elements to describe default table `Action` buttons in `plugin-catalog`
-- Wrapped the `EntityLifecyclePicker`, `EntityOwnerPicker`, `EntityTagPicker`, in `label` elements in `plugin-catalog-react`
-- Changed group name `Typography` component to `span` (from default `h6`), added `aria-label` to the `List` component, and `role` of `menuitem` to the container of the `MenuItem` component in `plugin-catalog-react`
+- Added `aria-label` to the `Select` component
+- Changed heading level used in the header of `Table` component
diff --git a/packages/create-app/templates/default-app/packages/app/src/components/Root/Root.tsx b/packages/create-app/templates/default-app/packages/app/src/components/Root/Root.tsx
index 90738c44d4..d10eccf03a 100644
--- a/packages/create-app/templates/default-app/packages/app/src/components/Root/Root.tsx
+++ b/packages/create-app/templates/default-app/packages/app/src/components/Root/Root.tsx
@@ -69,6 +69,7 @@ const SidebarLogo = () => {
to="/"
underline="none"
className={classes.link}
+ aria-label="Home"
>
{isOpen ? : }