diff --git a/plugins/github-deployments/src/components/GithubDeploymentsCard.test.tsx b/plugins/github-deployments/src/components/GithubDeploymentsCard.test.tsx index 7357e96b03..7a022e99b2 100644 --- a/plugins/github-deployments/src/components/GithubDeploymentsCard.test.tsx +++ b/plugins/github-deployments/src/components/GithubDeploymentsCard.test.tsx @@ -113,7 +113,7 @@ describe('github-deployments', () => { ); expect( - await rendered.findByText('No GitHub deployments available.'), + await rendered.findByText('No deployments found for this entity.'), ).toBeInTheDocument(); }); }); diff --git a/plugins/github-deployments/src/components/GithubDeploymentsCard.tsx b/plugins/github-deployments/src/components/GithubDeploymentsCard.tsx index 7425370fe7..4a1c4fcfbb 100644 --- a/plugins/github-deployments/src/components/GithubDeploymentsCard.tsx +++ b/plugins/github-deployments/src/components/GithubDeploymentsCard.tsx @@ -60,11 +60,6 @@ const GithubDeploymentsComponent = ({ ); } - if (!value || value.length === 0) { - return ( - - ); - } return ; }; diff --git a/plugins/github-deployments/src/components/GithubDeploymentsTable/GithubDeploymentsTable.tsx b/plugins/github-deployments/src/components/GithubDeploymentsTable/GithubDeploymentsTable.tsx index a7b1c5bf9e..8f4806779d 100644 --- a/plugins/github-deployments/src/components/GithubDeploymentsTable/GithubDeploymentsTable.tsx +++ b/plugins/github-deployments/src/components/GithubDeploymentsTable/GithubDeploymentsTable.tsx @@ -17,7 +17,15 @@ import React from 'react'; import { Table, TableColumn } from '@backstage/core'; import { GithubDeployment } from '../../api'; import moment from 'moment'; -import { Box, Typography, Link } from '@material-ui/core'; +import { Box, Typography, Link, makeStyles } from '@material-ui/core'; + +const useStyles = makeStyles(theme => ({ + empty: { + padding: theme.spacing(2), + display: 'flex', + justifyContent: 'center', + }, +})); const lastUpdated = (start: string): string => moment(start).fromNow(); @@ -76,12 +84,21 @@ type GithubDeploymentsTableProps = { const GithubDeploymentsTable = ({ deployments, }: GithubDeploymentsTableProps) => { + const classes = useStyles(); + return ( + + No deployments found for this entity. + + + } /> ); };