From 03d355d6e22112540d1d4b8b370d944e166f4212 Mon Sep 17 00:00:00 2001 From: blam Date: Wed, 31 Aug 2022 13:52:17 +0200 Subject: [PATCH 1/3] use the webpack detection for `esmodule` with React Refresh Signed-off-by: blam --- packages/cli/src/lib/bundler/transforms.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/cli/src/lib/bundler/transforms.ts b/packages/cli/src/lib/bundler/transforms.ts index 5fe20a0043..ba8da5bad8 100644 --- a/packages/cli/src/lib/bundler/transforms.ts +++ b/packages/cli/src/lib/bundler/transforms.ts @@ -190,7 +190,6 @@ export const transforms = (options: TransformOptions): Transforms => { if (isDev) { plugins.push( new ReactRefreshPlugin({ - esModule: true, overlay: { sockProtocol: 'ws' }, }), ); From 1cb078ad9ffce8fb4f4905eb3529017bcdd98312 Mon Sep 17 00:00:00 2001 From: blam Date: Wed, 31 Aug 2022 13:53:18 +0200 Subject: [PATCH 2/3] chore: add changeset Signed-off-by: blam --- .changeset/purple-plums-travel.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/purple-plums-travel.md diff --git a/.changeset/purple-plums-travel.md b/.changeset/purple-plums-travel.md new file mode 100644 index 0000000000..cbf842f865 --- /dev/null +++ b/.changeset/purple-plums-travel.md @@ -0,0 +1,5 @@ +--- +'@backstage/cli': patch +--- + +Use the `webpack` `esmodule` detection for React Refresh From c5b2c7e0985fc03d5908fd90834952c1bc09068f Mon Sep 17 00:00:00 2001 From: Ben Lambert Date: Wed, 31 Aug 2022 14:21:45 +0200 Subject: [PATCH 3/3] Update .changeset/purple-plums-travel.md Co-authored-by: Patrik Oldsberg Signed-off-by: Ben Lambert --- .changeset/purple-plums-travel.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/purple-plums-travel.md b/.changeset/purple-plums-travel.md index cbf842f865..0077b15808 100644 --- a/.changeset/purple-plums-travel.md +++ b/.changeset/purple-plums-travel.md @@ -2,4 +2,4 @@ '@backstage/cli': patch --- -Use the `webpack` `esmodule` detection for React Refresh +Fixed a misconfiguration where all modules where treated as ESM by the React Refresh plugin for Webpack.