From 1f15c28ae68bad5d1907476fc548a87057f6caf7 Mon Sep 17 00:00:00 2001 From: Mohamed Mohamed Date: Mon, 14 Nov 2022 09:44:04 -0600 Subject: [PATCH] pr review changes Signed-off-by: Mohamed Mohamed --- .changeset/early-hairs-switch.md | 2 +- .../ExampleFetchComponent/ExampleFetchComponent.test.tsx.hbs | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.changeset/early-hairs-switch.md b/.changeset/early-hairs-switch.md index 328072ec51..16f4298db5 100644 --- a/.changeset/early-hairs-switch.md +++ b/.changeset/early-hairs-switch.md @@ -1,5 +1,5 @@ --- -'@backstage/cli': minor +'@backstage/cli': patch --- changed tests created by create-plugin to follow eslint-rules best practices particularly testing-library/prefer-screen-queries and testing-library/render-result-naming-convention diff --git a/packages/cli/templates/default-plugin/src/components/ExampleFetchComponent/ExampleFetchComponent.test.tsx.hbs b/packages/cli/templates/default-plugin/src/components/ExampleFetchComponent/ExampleFetchComponent.test.tsx.hbs index 0dded1dcc2..a553ecd0b0 100644 --- a/packages/cli/templates/default-plugin/src/components/ExampleFetchComponent/ExampleFetchComponent.test.tsx.hbs +++ b/packages/cli/templates/default-plugin/src/components/ExampleFetchComponent/ExampleFetchComponent.test.tsx.hbs @@ -5,7 +5,6 @@ import { rest } from 'msw'; import { setupServer } from 'msw/node'; import { setupRequestMockHandlers } from '@backstage/test-utils'; - describe('ExampleFetchComponent', () => { const server = setupServer(); // Enable sane handlers for network requests