From 1ea76795a02a7e26bbb77cde8af13f31cb491c13 Mon Sep 17 00:00:00 2001 From: Benjamin Janssens Date: Thu, 23 May 2024 15:21:24 +0200 Subject: [PATCH] fix(scaffolder): remove waiting until all fields are filled in before requesting user credentials Signed-off-by: Benjamin Janssens --- .changeset/hungry-cups-jog.md | 5 +++++ .../src/components/fields/RepoUrlPicker/RepoUrlPicker.tsx | 5 +---- 2 files changed, 6 insertions(+), 4 deletions(-) create mode 100644 .changeset/hungry-cups-jog.md diff --git a/.changeset/hungry-cups-jog.md b/.changeset/hungry-cups-jog.md new file mode 100644 index 0000000000..af600c4f91 --- /dev/null +++ b/.changeset/hungry-cups-jog.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-scaffolder': patch +--- + +Removed waiting until all fields are filled in before requesting user credentials diff --git a/plugins/scaffolder/src/components/fields/RepoUrlPicker/RepoUrlPicker.tsx b/plugins/scaffolder/src/components/fields/RepoUrlPicker/RepoUrlPicker.tsx index 5a40480889..b8fe7b9420 100644 --- a/plugins/scaffolder/src/components/fields/RepoUrlPicker/RepoUrlPicker.tsx +++ b/plugins/scaffolder/src/components/fields/RepoUrlPicker/RepoUrlPicker.tsx @@ -125,10 +125,7 @@ export const RepoUrlPicker = (props: RepoUrlPickerProps) => { const { requestUserCredentials } = uiSchema?.['ui:options'] ?? {}; const workspace = state.owner ? state.owner : state.project; - if ( - !requestUserCredentials || - !(state.host && workspace && state.repoName) - ) { + if (!requestUserCredentials) { return; }