paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 46 Packages Projects Releases Wiki Activity

Fixes post review by Rugvip:

Browse Source 
1. Ensuring that reloadIntervals, if present, is a valid positive number
2. Remote config error message fix
3. Removed remote config from example backend
4. Lessened the writing.md
5. Multiple changesets

Signed-off-by: Praveen Ranjan Keshri <prkeshri@gmail.com>
This commit is contained in:
Praveen Ranjan Keshri
2021-12-08 00:21:53 +05:30
parent d5d69f1169
commit 1e7070443d
5 changed files with 11 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/config-loader/src/loader.ts
+3 -3
View File
@@ -129,12 +129,12 @@ export async function loadConfig(
if (remote === undefined) {
if (configUrls.length > 0) {
throw new Error(
`Remote config detected but this feature is turned off. Please enable by passing remote option in loadBackendConfig() call inside packages/backend/src/index.ts. See https://backstage.io/docs/conf/writing#configuration-files for detailed info.`,
`Please make sure you are passing the remote option when loading the configuration. See https://backstage.io/docs/conf/writing#configuration-files for detailed info.`,
);
}
} else if (remote.reloadIntervalSeconds === undefined) {
} else if (remote.reloadIntervalSeconds <= 0) {
throw new Error(
`Remote config must be contain reloadIntervalSeconds: <seconds> value`,
`Remote config must be contain a non zero reloadIntervalSeconds: <seconds> value`,
);
}