paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 43 Packages Projects Releases Wiki Activity

Merge pull request #23527 from npiyush97/navfix

Browse Source 
🐛 bug fix:fix issue in entitypage tabs with replacing nav link tabs
This commit is contained in:
Ben Lambert
2024-04-02 14:31:58 +02:00
committed by GitHub
parent 4fa079fcfd c77dff47f6
commit 1cbc081d9a
5 changed files with 28 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/user-settings/src/components/DefaultSettingsPage/DefaultSettingsPage.test.tsx
+3 -3
View File
@@ -34,7 +34,7 @@ describe('<DefaultSettingsPage />', () => {
it('should render the settings page with 3 tabs', async () => {
const { container } = await renderInTestApp(<DefaultSettingsPage />);
const tabs = container.querySelectorAll('[class*=MuiTabs-root] button');
const tabs = container.querySelectorAll('[class*=MuiTabs-root] a');
expect(tabs).toHaveLength(3);
});
@@ -48,7 +48,7 @@ describe('<DefaultSettingsPage />', () => {
<DefaultSettingsPage tabs={[advancedTabRoute]} />,
);
const tabs = container.querySelectorAll('[class*=MuiTabs-root] button');
const tabs = container.querySelectorAll('[class*=MuiTabs-root] a');
expect(tabs).toHaveLength(4);
expect(tabs[3].textContent).toEqual('Advanced');
});
@@ -63,7 +63,7 @@ describe('<DefaultSettingsPage />', () => {
<DefaultSettingsPage tabs={[advancedTabRoute]} />,
);
const tabs = container.querySelectorAll('[class*=MuiTabs-root] button');
const tabs = container.querySelectorAll('[class*=MuiTabs-root] a');
expect(tabs).toHaveLength(4);
expect(tabs[3].textContent).toEqual('Advanced');
});
plugins/user-settings/src/components/SettingsPage/SettingsPage.test.tsx
+4 -4
View File
@@ -36,7 +36,7 @@ describe('<SettingsPage />', () => {
it('should render the default settings page with 3 tabs', async () => {
const { container } = await renderInTestApp(<SettingsPage />);
const tabs = container.querySelectorAll('[class*=MuiTabs-root] button');
const tabs = container.querySelectorAll('[class*=MuiTabs-root] a');
expect(tabs).toHaveLength(3);
});
@@ -49,7 +49,7 @@ describe('<SettingsPage />', () => {
(useOutlet as jest.Mock).mockReturnValue(advancedTabRoute);
const { container } = await renderInTestApp(<SettingsPage />);
const tabs = container.querySelectorAll('[class*=MuiTabs-root] button');
const tabs = container.querySelectorAll('[class*=MuiTabs-root] a');
expect(tabs).toHaveLength(4);
expect(tabs[3].textContent).toEqual('Advanced');
});
@@ -63,7 +63,7 @@ describe('<SettingsPage />', () => {
(useOutlet as jest.Mock).mockReturnValue(advancedTabRoute);
const { container } = await renderInTestApp(<SettingsPage />);
const tabs = container.querySelectorAll('[class*=MuiTabs-root] button');
const tabs = container.querySelectorAll('[class*=MuiTabs-root] a');
expect(tabs).toHaveLength(4);
expect(tabs[3].textContent).toEqual('Advanced');
const user = userEvent.setup();
@@ -86,7 +86,7 @@ describe('<SettingsPage />', () => {
(useOutlet as jest.Mock).mockReturnValue(customLayout);
const { container } = await renderInTestApp(<SettingsPage />);
const tabs = container.querySelectorAll('[class*=MuiTabs-root] button');
const tabs = container.querySelectorAll('[class*=MuiTabs-root] a');
expect(tabs).toHaveLength(2);
expect(tabs[0].textContent).toEqual('General');
expect(tabs[1].textContent).toEqual('Advanced');