From 1c8c0a2cc7153a3b610927cfcb1583f7f4fb4fee Mon Sep 17 00:00:00 2001 From: Carlos Esteban Lopez Date: Fri, 21 Oct 2022 13:29:10 -0500 Subject: [PATCH] docs: Address PR comments Signed-off-by: Carlos Esteban Lopez --- .github/vale/Vocab/Backstage/accept.txt | 4 ++++ docs/dls/component-design-guidelines.md | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/vale/Vocab/Backstage/accept.txt b/.github/vale/Vocab/Backstage/accept.txt index 603d5fd9af..9ba2abbc78 100644 --- a/.github/vale/Vocab/Backstage/accept.txt +++ b/.github/vale/Vocab/Backstage/accept.txt @@ -219,6 +219,10 @@ onboarding Onboarding OpenShift orgs +padding +Padding +paddings +Paddings pagerduty pageview parallelization diff --git a/docs/dls/component-design-guidelines.md b/docs/dls/component-design-guidelines.md index 7c0f3e224b..6b96e82ca0 100644 --- a/docs/dls/component-design-guidelines.md +++ b/docs/dls/component-design-guidelines.md @@ -42,7 +42,7 @@ theme's color palette, most Backstage components and all MUI components should use the theme's color palette by default, so unless you need explicit control on the color of a component (say when the component was designed to use the primay color but you want to use the secondary), then the easiest way to access -the color palette is with [useTheme hook](https://mui.com/material-ui/customization/theming/#accessing-the-theme-in-a-component). +the color palette is with [`useTheme` hook](https://mui.com/material-ui/customization/theming/#accessing-the-theme-in-a-component). It's not a very common use case to override a theme color in a MUI component but let's say you have a Paper component that highlights it's content with a