From 1c522713cd85fd0c2bd226a0d7d92375471f2252 Mon Sep 17 00:00:00 2001
From: Patrik Oldsberg <poldsberg@gmail.com>
Date: Thu, 13 Jul 2023 21:57:08 +0200
Subject: [PATCH] auth-backend: throw error if sign-in result does not contain
 token when preparting identity response

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
---
 .../src/providers/prepareBackstageIdentityResponse.ts        | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/plugins/auth-backend/src/providers/prepareBackstageIdentityResponse.ts b/plugins/auth-backend/src/providers/prepareBackstageIdentityResponse.ts
index 761618c225..e2753d6648 100644
--- a/plugins/auth-backend/src/providers/prepareBackstageIdentityResponse.ts
+++ b/plugins/auth-backend/src/providers/prepareBackstageIdentityResponse.ts
@@ -14,6 +14,7 @@
  * limitations under the License.
  */
 
+import { InputError } from '@backstage/errors';
 import {
   BackstageIdentityResponse,
   BackstageSignInResult,
@@ -34,6 +35,10 @@ function parseJwtPayload(token: string) {
 export function prepareBackstageIdentityResponse(
   result: BackstageSignInResult,
 ): BackstageIdentityResponse {
+  if (!result.token) {
+    throw new InputError(`Identity response must return a token`);
+  }
+
   const { sub, ent } = parseJwtPayload(result.token);
 
   return {