From 1b4ab0d44ccf2cfc193987d8c4b83725d250eba2 Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Tue, 25 Jan 2022 22:19:29 +0100 Subject: [PATCH] cli: fix app:serve dependency warning Signed-off-by: Patrik Oldsberg --- .changeset/late-donuts-eat.md | 5 +++++ packages/cli/src/commands/app/serve.ts | 10 +++++----- 2 files changed, 10 insertions(+), 5 deletions(-) create mode 100644 .changeset/late-donuts-eat.md diff --git a/.changeset/late-donuts-eat.md b/.changeset/late-donuts-eat.md new file mode 100644 index 0000000000..2c8aabbde8 --- /dev/null +++ b/.changeset/late-donuts-eat.md @@ -0,0 +1,5 @@ +--- +'@backstage/cli': patch +--- + +Updated the dependency warning that is baked into `app:serve` to only warn about packages that are not allowed to have duplicates. diff --git a/packages/cli/src/commands/app/serve.ts b/packages/cli/src/commands/app/serve.ts index 208042c719..12d92abc45 100644 --- a/packages/cli/src/commands/app/serve.ts +++ b/packages/cli/src/commands/app/serve.ts @@ -22,16 +22,16 @@ import { serveBundle } from '../../lib/bundler'; import { loadCliConfig } from '../../lib/config'; import { paths } from '../../lib/paths'; import { Lockfile } from '../../lib/versioning'; -import { includedFilter } from '../versions/lint'; +import { forbiddenDuplicatesFilter, includedFilter } from '../versions/lint'; export default async (cmd: Command) => { const lockfile = await Lockfile.load(paths.resolveTargetRoot('yarn.lock')); const result = lockfile.analyze({ filter: includedFilter, }); - const problemPackages = [...result.newVersions, ...result.newRanges].map( - ({ name }) => name, - ); + const problemPackages = [...result.newVersions, ...result.newRanges] + .map(({ name }) => name) + .filter(name => forbiddenDuplicatesFilter(name)); if (problemPackages.length > 1) { console.log( @@ -44,7 +44,7 @@ export default async (cmd: Command) => { ); console.log( chalk.yellow( - `⚠️ This can be resolved using the following command: + `⚠️ The following command may fix the issue, but it could also be an issue within one of your dependencies: yarn backstage-cli versions:check --fix `,