From 1a9d19dc6d8cb1d06cd1398a500316a688cbeded Mon Sep 17 00:00:00 2001 From: Spencer Henry Date: Mon, 10 Oct 2022 09:54:32 -0600 Subject: [PATCH] linting fixes Signed-off-by: Spencer Henry --- .changeset/flat-items-perform.md | 6 +++--- .../src/scaffolder/tasks/NunjucksWorkflowRunner.ts | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.changeset/flat-items-perform.md b/.changeset/flat-items-perform.md index ce5b95c7ca..46626ac667 100644 --- a/.changeset/flat-items-perform.md +++ b/.changeset/flat-items-perform.md @@ -10,7 +10,7 @@ Added a set of default Prometheus metrics around scaffolding. See below for a li - `template`: The entity ref of the scaffolded template - `user`: The entity ref of the user that invoked the template run - - `result`: A string describing whether the task ran successfully, errored out, or was skipped + - `result`: A string describing whether the task ran successfully, failed, or was skipped - `scaffolder_task_duration`: a histogram which tracks the duration of a task run @@ -25,7 +25,7 @@ Added a set of default Prometheus metrics around scaffolding. See below for a li - `template`: The entity ref of the scaffolded template - `step`: The name of the step that was run - - `result`: A string describing whether the task ran successfully, errored out, or was skipped + - `result`: A string describing whether the task ran successfully, failed, or was skipped - `scaffolder_step_duration`: a histogram which tracks the duration of each step run @@ -33,6 +33,6 @@ Added a set of default Prometheus metrics around scaffolding. See below for a li - `template`: The entity ref of the scaffolded template - `step`: The name of the step that was run - - `result`: A string describing whether the task ran successfully, errored out, or was skipped + - `result`: A string describing whether the task ran successfully, failed, or was skipped You can find a guide for running Prometheus metrics here: https://github.com/backstage/backstage/blob/master/contrib/docs/tutorials/prometheus-metrics.md diff --git a/plugins/scaffolder-backend/src/scaffolder/tasks/NunjucksWorkflowRunner.ts b/plugins/scaffolder-backend/src/scaffolder/tasks/NunjucksWorkflowRunner.ts index a63bb48694..f651be4830 100644 --- a/plugins/scaffolder-backend/src/scaffolder/tasks/NunjucksWorkflowRunner.ts +++ b/plugins/scaffolder-backend/src/scaffolder/tasks/NunjucksWorkflowRunner.ts @@ -398,7 +398,7 @@ function scaffoldingTracker() { taskCount.inc({ template, user, - result: 'ok' + result: 'ok', }); taskTimer({ result: 'ok' }); } @@ -411,7 +411,7 @@ function scaffoldingTracker() { taskCount.inc({ template, user, - result: 'failed' + result: 'failed', }); taskTimer({ result: 'failed' }); } @@ -443,7 +443,7 @@ function scaffoldingTracker() { stepCount.inc({ template, step: step.name, - result: 'ok' + result: 'ok', }); stepTimer({ result: 'ok' }); } @@ -452,7 +452,7 @@ function scaffoldingTracker() { stepCount.inc({ template, step: step.name, - result: 'failed' + result: 'failed', }); stepTimer({ result: 'failed' }); }