From 191b41a0b35d5a530aa5a9d20730fc67c626bb76 Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Mon, 20 Apr 2026 16:49:21 +0200 Subject: [PATCH] integration: remove unnecessary exports from internal helpers Remove `export` from five internal helper functions that are not part of the published API and are only used within their own files. The `sleep` function in GitLabIntegration is kept exported for test access but marked as `@internal`. Signed-off-by: Patrik Oldsberg Made-with: Cursor --- .../src/awsCodeCommit/AwsCodeCommitIntegration.ts | 3 +-- packages/integration/src/gerrit/core.ts | 5 +---- packages/integration/src/github/core.ts | 2 +- packages/integration/src/gitlab/GitLabIntegration.ts | 1 + packages/integration/src/gitlab/core.ts | 2 +- 5 files changed, 5 insertions(+), 8 deletions(-) diff --git a/packages/integration/src/awsCodeCommit/AwsCodeCommitIntegration.ts b/packages/integration/src/awsCodeCommit/AwsCodeCommitIntegration.ts index e5b0e4b76b..801cd607ab 100644 --- a/packages/integration/src/awsCodeCommit/AwsCodeCommitIntegration.ts +++ b/packages/integration/src/awsCodeCommit/AwsCodeCommitIntegration.ts @@ -81,9 +81,8 @@ export class AwsCodeCommitIntegration implements ScmIntegration { * * @param url - The original URL * @param type - The desired type, e.g. 'blob', 'edit' - * @public */ -export function replaceCodeCommitUrlType( +function replaceCodeCommitUrlType( url: string, repositoryName: string, type: 'browse' | 'edit', diff --git a/packages/integration/src/gerrit/core.ts b/packages/integration/src/gerrit/core.ts index e8db1305ed..c004e4e613 100644 --- a/packages/integration/src/gerrit/core.ts +++ b/packages/integration/src/gerrit/core.ts @@ -209,11 +209,8 @@ export function buildGerritGitilesArchiveUrlFromLocation( * be used. * * @param config - A Gerrit provider config. - * @public */ -export function getAuthenticationPrefix( - config: GerritIntegrationConfig, -): string { +function getAuthenticationPrefix(config: GerritIntegrationConfig): string { return config.password ? '/a/' : '/'; } diff --git a/packages/integration/src/github/core.ts b/packages/integration/src/github/core.ts index 9599338497..6810e06a0c 100644 --- a/packages/integration/src/github/core.ts +++ b/packages/integration/src/github/core.ts @@ -63,7 +63,7 @@ export function getGithubFileFetchUrl( } } -export function chooseEndpoint( +function chooseEndpoint( config: GithubIntegrationConfig, credentials: GithubCredentials, ): 'api' | 'raw' { diff --git a/packages/integration/src/gitlab/GitLabIntegration.ts b/packages/integration/src/gitlab/GitLabIntegration.ts index 68afb6f63e..19c349af9e 100644 --- a/packages/integration/src/gitlab/GitLabIntegration.ts +++ b/packages/integration/src/gitlab/GitLabIntegration.ts @@ -138,6 +138,7 @@ export class GitLabIntegration implements ScmIntegration { } } +/** @internal */ export async function sleep( durationMs: number, abortSignal: AbortSignal | null | undefined, diff --git a/packages/integration/src/gitlab/core.ts b/packages/integration/src/gitlab/core.ts index 435e5a8a31..d5c8703aec 100644 --- a/packages/integration/src/gitlab/core.ts +++ b/packages/integration/src/gitlab/core.ts @@ -75,7 +75,7 @@ export function getGitLabRequestOptions( // Converts // from: https://gitlab.com/groupA/teams/teamA/subgroupA/repoA/-/blob/branch/filepath // to: https://gitlab.com/api/v4/projects/groupA%2Fteams%2FteamA%2FsubgroupA%2FrepoA/repository/files/filepath/raw?ref=branch -export function buildProjectUrl( +function buildProjectUrl( target: string, projectPathOrID: string | Number, config: GitLabIntegrationConfig,