From 19071023cd96b7b79f7f546fe7f96e056d12f9a9 Mon Sep 17 00:00:00 2001 From: Raghunandan Date: Fri, 17 Jul 2020 14:13:47 +0200 Subject: [PATCH] fix type issues --- plugins/auth-backend/src/providers/github/provider.ts | 4 ++-- plugins/auth-backend/src/providers/gitlab/provider.ts | 6 +++--- plugins/auth-backend/src/providers/oauth2/provider.ts | 8 ++++---- plugins/auth-backend/src/providers/okta/provider.ts | 6 +++--- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/plugins/auth-backend/src/providers/github/provider.ts b/plugins/auth-backend/src/providers/github/provider.ts index a67e78febd..37d661f9ab 100644 --- a/plugins/auth-backend/src/providers/github/provider.ts +++ b/plugins/auth-backend/src/providers/github/provider.ts @@ -134,8 +134,8 @@ export function createGithubProvider( const providerId = 'github'; const secure = envConfig.getBoolean('secure'); const appOrigin = envConfig.getString('appOrigin'); - const clientID = envConfig.getOptionalString('clientId'); - const clientSecret = envConfig.getOptionalString('clientSecret'); + const clientID = envConfig.getString('clientId'); + const clientSecret = envConfig.getString('clientSecret'); const callbackURL = `${baseUrl}/${providerId}/handler/frame?env=${env}`; const opts = { diff --git a/plugins/auth-backend/src/providers/gitlab/provider.ts b/plugins/auth-backend/src/providers/gitlab/provider.ts index 78b1a55211..c5c546c6f3 100644 --- a/plugins/auth-backend/src/providers/gitlab/provider.ts +++ b/plugins/auth-backend/src/providers/gitlab/provider.ts @@ -141,9 +141,9 @@ export function createGitlabProvider( const providerId = 'gitlab'; const secure = envConfig.getBoolean('secure'); const appOrigin = envConfig.getString('appOrigin'); - const clientID = envConfig.getOptionalString('clientId'); - const clientSecret = envConfig.getOptionalString('clientSecret'); - const audience = envConfig.getOptionalString('audience'); + const clientID = envConfig.getString('clientId'); + const clientSecret = envConfig.getString('clientSecret'); + const audience = envConfig.getString('audience'); const baseURL = audience || 'https://gitlab.com'; const callbackURL = `${baseUrl}/${providerId}/handler/frame?env=${env}`; diff --git a/plugins/auth-backend/src/providers/oauth2/provider.ts b/plugins/auth-backend/src/providers/oauth2/provider.ts index e4258605ac..967fd011f0 100644 --- a/plugins/auth-backend/src/providers/oauth2/provider.ts +++ b/plugins/auth-backend/src/providers/oauth2/provider.ts @@ -151,11 +151,11 @@ export function createOAuth2Provider( const providerId = 'oauth2'; const secure = envConfig.getBoolean('secure'); const appOrigin = envConfig.getString('appOrigin'); - const clientID = envConfig.getOptionalString('clientId'); - const clientSecret = envConfig.getOptionalString('clientSecret'); + const clientID = envConfig.getString('clientId'); + const clientSecret = envConfig.getString('clientSecret'); const callbackURL = `${baseUrl}/${providerId}/handler/frame?env=${env}`; - const authorizationURL = envConfig.getOptionalString('authorizationURL'); - const tokenURL = envConfig.getOptionalString('tokenURL'); + const authorizationURL = envConfig.getString('authorizationURL'); + const tokenURL = envConfig.getString('tokenURL'); const opts = { clientID, diff --git a/plugins/auth-backend/src/providers/okta/provider.ts b/plugins/auth-backend/src/providers/okta/provider.ts index 5fcc7cb778..56e8b1220d 100644 --- a/plugins/auth-backend/src/providers/okta/provider.ts +++ b/plugins/auth-backend/src/providers/okta/provider.ts @@ -173,9 +173,9 @@ export function createOktaProvider( const providerId = 'okta'; const secure = envConfig.getBoolean('secure'); const appOrigin = envConfig.getString('appOrigin'); - const clientID = envConfig.getOptionalString('clientId'); - const clientSecret = envConfig.getOptionalString('clientSecret'); - const audience = envConfig.getOptionalString('audience'); + const clientID = envConfig.getString('clientId'); + const clientSecret = envConfig.getString('clientSecret'); + const audience = envConfig.getString('audience'); const callbackURL = `${baseUrl}/${providerId}/handler/frame?env=${env}`; const opts = {