From 17644ca68eb67dea67b1691f34181c61b811326a Mon Sep 17 00:00:00 2001
From: Will <willsewell@monzo.com>
Date: Wed, 28 Apr 2021 14:23:10 +0100
Subject: [PATCH] Don't treat singuler `filter` type as legacy

Instead it's a convenience type for when only a single instance
of a param is required.

Signed-off-by: Will Sewell <willsewell@monzo.com>
---
 packages/catalog-client/src/CatalogClient.test.ts | 5 ++---
 packages/catalog-client/src/types.ts              | 2 +-
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/packages/catalog-client/src/CatalogClient.test.ts b/packages/catalog-client/src/CatalogClient.test.ts
index fefe670a55..359e3a2c60 100644
--- a/packages/catalog-client/src/CatalogClient.test.ts
+++ b/packages/catalog-client/src/CatalogClient.test.ts
@@ -76,7 +76,7 @@ describe('CatalogClient', () => {
       expect(response).toEqual(defaultResponse);
     });
 
-    it('builds entity search filters properly', async () => {
+    it('builds multiple entity search filters properly', async () => {
       expect.assertions(2);
 
       server.use(
@@ -107,7 +107,7 @@ describe('CatalogClient', () => {
       expect(response.items).toEqual([]);
     });
 
-    it('builds entity legacy search filters properly', async () => {
+    it('builds single entity search filter properly', async () => {
       expect.assertions(2);
 
       server.use(
@@ -119,7 +119,6 @@ describe('CatalogClient', () => {
 
       const response = await client.getEntities(
         {
-          // The legacy value of filter is not an array
           filter: {
             a: '1',
             b: ['2', '3'],
diff --git a/packages/catalog-client/src/types.ts b/packages/catalog-client/src/types.ts
index 9035657ddc..ef907eafa9 100644
--- a/packages/catalog-client/src/types.ts
+++ b/packages/catalog-client/src/types.ts
@@ -19,7 +19,7 @@ import { Entity, EntityName, Location } from '@backstage/catalog-model';
 export type CatalogEntitiesRequest = {
   filter?:
     | Record<string, string | string[]>[]
-    | Record<string, string | string[]> // Legacy type preserved for backwards compatibility
+    | Record<string, string | string[]>
     | undefined;
   fields?: string[] | undefined;
 };