From 1753dae28aad35a9a42a2f4aec90e74011514929 Mon Sep 17 00:00:00 2001 From: Minn Soe Date: Tue, 15 Jun 2021 17:50:25 +0100 Subject: [PATCH] fix: limit database manager exports and update changeset Signed-off-by: Minn Soe --- .changeset/five-donkeys-brake.md | 6 +++--- packages/backend-common/api-report.md | 8 -------- packages/backend-common/src/database/index.ts | 3 ++- 3 files changed, 5 insertions(+), 12 deletions(-) diff --git a/.changeset/five-donkeys-brake.md b/.changeset/five-donkeys-brake.md index b0bb635876..274e704888 100644 --- a/.changeset/five-donkeys-brake.md +++ b/.changeset/five-donkeys-brake.md @@ -1,7 +1,7 @@ --- -'@backstage/backend-common': minor -'@backstage/create-app': minor -'@backstage/backend-test-utils': minor +'@backstage/backend-common': patch +'@backstage/create-app': patch +'@backstage/backend-test-utils': patch --- Deprecates `SingleConnectionDatabaseManager` and provides an API compatible database diff --git a/packages/backend-common/api-report.md b/packages/backend-common/api-report.md index 1cf1f4f21b..ed78157810 100644 --- a/packages/backend-common/api-report.md +++ b/packages/backend-common/api-report.md @@ -104,14 +104,6 @@ export function createServiceBuilder(_module: NodeModule): ServiceBuilderImpl; // @public (undocumented) export function createStatusCheckRouter(options: StatusCheckRouterOptions): Promise; -// @public -export interface DatabaseConnector { - createClient(dbConfig: Config, overrides?: Partial): Knex; - createNameOverride(name: string): Partial; - ensureDatabaseExists?(dbConfig: Config, ...databases: Array): Promise; - parseConnectionString(connectionString: string, client?: string): Knex.StaticConnectionConfig; -} - // @public (undocumented) export class DatabaseManager { forPlugin(pluginId: string): PluginDatabaseManager; diff --git a/packages/backend-common/src/database/index.ts b/packages/backend-common/src/database/index.ts index 7dfb08359b..f8957907f0 100644 --- a/packages/backend-common/src/database/index.ts +++ b/packages/backend-common/src/database/index.ts @@ -15,6 +15,7 @@ */ export * from './connection'; -export * from './types'; export * from './SingleConnection'; export * from './DatabaseManager'; + +export type { PluginDatabaseManager } from './types';