diff --git a/.changeset/violet-seas-pretend.md b/.changeset/violet-seas-pretend.md new file mode 100644 index 0000000000..09774f0af8 --- /dev/null +++ b/.changeset/violet-seas-pretend.md @@ -0,0 +1,7 @@ +--- +'@backstage/plugin-scaffolder-node': minor +'@backstage/plugin-scaffolder-backend-module-cookiecutter': patch +'@backstage/plugin-scaffolder-backend-module-rails': patch +--- + +Deprecate the `logStream` option in `executeShellCommand`, replacing it with a logger instance. diff --git a/plugins/scaffolder-backend-module-cookiecutter/report.api.md b/plugins/scaffolder-backend-module-cookiecutter/report.api.md index 19f43389dc..316dc6b4a8 100644 --- a/plugins/scaffolder-backend-module-cookiecutter/report.api.md +++ b/plugins/scaffolder-backend-module-cookiecutter/report.api.md @@ -3,8 +3,6 @@ > Do not edit this file. It is a report generated by [API Extractor](https://api-extractor.com/). ```ts -/// - import { BackendFeature } from '@backstage/backend-plugin-api'; import { ContainerRunner } from '@backstage/backend-common'; import { JsonObject } from '@backstage/types'; diff --git a/plugins/scaffolder-backend-module-rails/package.json b/plugins/scaffolder-backend-module-rails/package.json index 56cd2c0451..62929c41f7 100644 --- a/plugins/scaffolder-backend-module-rails/package.json +++ b/plugins/scaffolder-backend-module-rails/package.json @@ -52,6 +52,7 @@ "@backstage/types": "workspace:^", "command-exists": "^1.2.9", "fs-extra": "^11.0.0", + "winston": "^3.2.1", "yaml": "^2.0.0" }, "devDependencies": { diff --git a/plugins/scaffolder-node/report.api.md b/plugins/scaffolder-node/report.api.md index c6cabda02c..26735e18de 100644 --- a/plugins/scaffolder-node/report.api.md +++ b/plugins/scaffolder-node/report.api.md @@ -191,6 +191,7 @@ export type ExecuteShellCommandOptions = { command: string; args: string[]; options?: SpawnOptionsWithoutStdio; + logger?: Logger; logStream?: Writable; }; diff --git a/yarn.lock b/yarn.lock index cd65c170d6..7348496686 100644 --- a/yarn.lock +++ b/yarn.lock @@ -7450,6 +7450,7 @@ __metadata: command-exists: ^1.2.9 fs-extra: ^11.0.0 jest-when: ^3.1.0 + winston: ^3.2.1 yaml: ^2.0.0 languageName: unknown linkType: soft