From 17850a5809aac3935ac625ca8d6398410cd0b0f2 Mon Sep 17 00:00:00 2001 From: MT Lewis Date: Fri, 18 Oct 2024 15:27:54 +0100 Subject: [PATCH 1/2] cli: conditionally include yarnPlugin query param in versions:bump upgrade-helper link Signed-off-by: MT Lewis --- .changeset/swift-laws-applaud.md | 5 +++++ packages/cli/src/commands/versions/bump.ts | 17 ++++++++++++++--- 2 files changed, 19 insertions(+), 3 deletions(-) create mode 100644 .changeset/swift-laws-applaud.md diff --git a/.changeset/swift-laws-applaud.md b/.changeset/swift-laws-applaud.md new file mode 100644 index 0000000000..5846ef0420 --- /dev/null +++ b/.changeset/swift-laws-applaud.md @@ -0,0 +1,5 @@ +--- +'@backstage/cli': patch +--- + +Update upgrade-helper link in versions:bump command to include yarnPlugin param when the yarn plugin is installed diff --git a/packages/cli/src/commands/versions/bump.ts b/packages/cli/src/commands/versions/bump.ts index e41bd98c49..8d43f38967 100644 --- a/packages/cli/src/commands/versions/bump.ts +++ b/packages/cli/src/commands/versions/bump.ts @@ -228,7 +228,10 @@ export default async (opts: OptionValues) => { // Do not update backstage.json when upgrade patterns are used. if (pattern === DEFAULT_PATTERN_GLOB) { - await bumpBackstageJsonVersion(releaseManifest.releaseVersion); + await bumpBackstageJsonVersion( + releaseManifest.releaseVersion, + hasYarnPlugin, + ); } else { console.log( chalk.yellow( @@ -410,7 +413,10 @@ async function getBackstageJson() { }); } -export async function bumpBackstageJsonVersion(version: string) { +export async function bumpBackstageJsonVersion( + version: string, + useYarnPlugin?: boolean, +) { const backstageJson = await getBackstageJson(); const prevVersion = backstageJson?.version; @@ -422,7 +428,12 @@ export async function bumpBackstageJsonVersion(version: string) { if (prevVersion) { const from = encodeURIComponent(prevVersion); const to = encodeURIComponent(version); - const link = `https://backstage.github.io/upgrade-helper/?from=${from}&to=${to}`; + let link = `https://backstage.github.io/upgrade-helper/?from=${from}&to=${to}`; + + if (useYarnPlugin) { + link += '&yarnPlugin=1'; + } + console.log( yellow( `Upgraded from release ${green(prevVersion)} to ${green( From d300e24fe4e9af88933375716c52f30bb9bdb6bf Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Mon, 21 Oct 2024 12:43:40 +0200 Subject: [PATCH 2/2] Update .changeset/swift-laws-applaud.md Signed-off-by: Patrik Oldsberg --- .changeset/swift-laws-applaud.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/swift-laws-applaud.md b/.changeset/swift-laws-applaud.md index 5846ef0420..320fb27e52 100644 --- a/.changeset/swift-laws-applaud.md +++ b/.changeset/swift-laws-applaud.md @@ -2,4 +2,4 @@ '@backstage/cli': patch --- -Update upgrade-helper link in versions:bump command to include yarnPlugin param when the yarn plugin is installed +Update upgrade-helper link in `versions:bump` command to include `yarnPlugin` param when the yarn plugin is installed