From 1654d7288559b453f4eb2580e3fb83937c67b7df Mon Sep 17 00:00:00 2001 From: Musaab Elfaqih Date: Fri, 25 Apr 2025 14:52:51 +0200 Subject: [PATCH] Simplify types Signed-off-by: Musaab Elfaqih --- .changeset/polite-shoes-allow.md | 2 +- packages/frontend-app-api/report.api.md | 7 +------ .../frontend-app-api/src/wiring/createSpecializedApp.tsx | 4 ++-- packages/frontend-app-api/src/wiring/types.ts | 5 ----- 4 files changed, 4 insertions(+), 14 deletions(-) diff --git a/.changeset/polite-shoes-allow.md b/.changeset/polite-shoes-allow.md index d3c5e34d7a..b7e06bce6f 100644 --- a/.changeset/polite-shoes-allow.md +++ b/.changeset/polite-shoes-allow.md @@ -2,4 +2,4 @@ '@backstage/frontend-app-api': patch --- -Added the ability to ignore unknown extension config. +Added the ability to ignore unknown extension config by passing `{ flags: { allowUnknownExtensionConfig: true } }` to `createSpecializedApp`. diff --git a/packages/frontend-app-api/report.api.md b/packages/frontend-app-api/report.api.md index 661da88210..91a33d277d 100644 --- a/packages/frontend-app-api/report.api.md +++ b/packages/frontend-app-api/report.api.md @@ -34,7 +34,7 @@ export function createSpecializedApp(options?: { extensionFactoryMiddleware?: | ExtensionFactoryMiddleware | ExtensionFactoryMiddleware[]; - flags?: SpecializedAppFlags; + flags?: Record; }): { apis: ApiHolder; tree: AppTree; @@ -42,9 +42,4 @@ export function createSpecializedApp(options?: { // @public @deprecated (undocumented) export type FrontendFeature = FrontendFeature_2; - -// @public (undocumented) -export type SpecializedAppFlags = { - allowUnknownExtensionConfig?: boolean; -}; ``` diff --git a/packages/frontend-app-api/src/wiring/createSpecializedApp.tsx b/packages/frontend-app-api/src/wiring/createSpecializedApp.tsx index e1b7f56227..3d356e2a74 100644 --- a/packages/frontend-app-api/src/wiring/createSpecializedApp.tsx +++ b/packages/frontend-app-api/src/wiring/createSpecializedApp.tsx @@ -74,7 +74,7 @@ import { ApiRegistry } from '../../../core-app-api/src/apis/system/ApiRegistry'; // eslint-disable-next-line @backstage/no-relative-monorepo-imports import { AppIdentityProxy } from '../../../core-app-api/src/apis/implementations/IdentityApi/AppIdentityProxy'; import { BackstageRouteObject } from '../routing/types'; -import { FrontendFeature, RouteInfo, SpecializedAppFlags } from './types'; +import { FrontendFeature, RouteInfo } from './types'; import { matchRoutes } from 'react-router-dom'; function deduplicateFeatures( @@ -208,7 +208,7 @@ export function createSpecializedApp(options?: { extensionFactoryMiddleware?: | ExtensionFactoryMiddleware | ExtensionFactoryMiddleware[]; - flags?: SpecializedAppFlags; + flags?: Record; }): { apis: ApiHolder; tree: AppTree } { const config = options?.config ?? new ConfigReader({}, 'empty-config'); const features = deduplicateFeatures(options?.features ?? []); diff --git a/packages/frontend-app-api/src/wiring/types.ts b/packages/frontend-app-api/src/wiring/types.ts index d7af7bd528..2bf08f327f 100644 --- a/packages/frontend-app-api/src/wiring/types.ts +++ b/packages/frontend-app-api/src/wiring/types.ts @@ -28,8 +28,3 @@ export type RouteInfo = { routeParents: Map; routeObjects: BackstageRouteObject[]; }; - -/** @public */ -export type SpecializedAppFlags = { - allowUnknownExtensionConfig?: boolean; -};