From 0b223952a367260cc0ed7dde56c111eb4c87ed52 Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Thu, 7 Aug 2025 11:06:21 +0200 Subject: [PATCH 1/2] remove old canon package Signed-off-by: Patrik Oldsberg --- .github/CODEOWNERS | 1 - .github/workflows/ci.yml | 4 - .github/workflows/deploy_packages.yml | 4 - .github/workflows/sync_canon.yml | 8 +- LABELS.md | 2 +- packages/canon/.eslintrc.js | 9 - packages/canon/.gitignore | 1 - packages/canon/CHANGELOG.md | 328 ------------------ packages/canon/README.md | 3 - packages/canon/catalog-info.yaml | 9 - packages/canon/package.json | 43 --- packages/canon/report.api.md | 7 - packages/canon/src/index.ts | 23 -- .../commands/knip-reports/knip-extractor.ts | 2 +- packages/types/report.api.md | 5 +- yarn.lock | 9 - 16 files changed, 8 insertions(+), 450 deletions(-) delete mode 100644 packages/canon/.eslintrc.js delete mode 100644 packages/canon/.gitignore delete mode 100644 packages/canon/CHANGELOG.md delete mode 100644 packages/canon/README.md delete mode 100644 packages/canon/catalog-info.yaml delete mode 100644 packages/canon/package.json delete mode 100644 packages/canon/report.api.md delete mode 100644 packages/canon/src/index.ts diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 519204ff24..89fba0c8ad 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -28,7 +28,6 @@ yarn.lock @backstage/maintainers @backst /microsite/static @backstage/maintainers @backstage/documentation-maintainers /packages @backstage/framework-maintainers /packages/backend-openapi-utils @backstage/maintainers @backstage/reviewers @backstage/openapi-tooling-maintainers -/packages/canon @backstage/design-system-maintainers /packages/catalog-client @backstage/catalog-maintainers /packages/catalog-model @backstage/catalog-maintainers /packages/cli @backstage/tooling-maintainers diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index bdf6edbbac..34dfb738b5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -127,10 +127,6 @@ jobs: - name: build all packages run: yarn backstage-cli repo build --all - # For now canon has a custom build script and needs to be built separately - - name: build canon - run: yarn --cwd packages/canon build - # For now BUI has a custom build script and needs to be built separately - name: build BUI run: yarn --cwd packages/ui build diff --git a/.github/workflows/deploy_packages.yml b/.github/workflows/deploy_packages.yml index 3f24fcc783..f429be076c 100644 --- a/.github/workflows/deploy_packages.yml +++ b/.github/workflows/deploy_packages.yml @@ -110,10 +110,6 @@ jobs: - name: build run: yarn backstage-cli repo build --all - # For now canon has a custom build script and needs to be built separately - - name: build canon - run: yarn --cwd packages/canon build - # For now BUI has a custom build script and needs to be built separately - name: build BUI run: yarn --cwd packages/ui build diff --git a/.github/workflows/sync_canon.yml b/.github/workflows/sync_canon.yml index 5abae892f6..31009094e3 100644 --- a/.github/workflows/sync_canon.yml +++ b/.github/workflows/sync_canon.yml @@ -1,4 +1,4 @@ -name: Sync Canon Docs +name: Sync BUI Docs on: push: branches: [master] @@ -36,7 +36,7 @@ jobs: - name: Configure Git run: | git config --global user.email noreply@backstage.io - git config --global user.name 'Github Canon Docs workflow' + git config --global user.name 'Github BUI Docs workflow' - name: Install dependencies working-directory: docs-ui @@ -53,9 +53,9 @@ jobs: git rm -rf . cp -R ../docs-ui/dist/. . - - name: Commit to canon-storybook repo + - name: Commit to bui-storybook repo working-directory: bui-external-docs run: | git add . - git commit -am "Canon Docs build for backstage/backstage@${{ github.sha }}" + git commit -am "BUI Docs build for backstage/backstage@${{ github.sha }}" git push diff --git a/LABELS.md b/LABELS.md index 32d5c7f095..f1af06d4fa 100644 --- a/LABELS.md +++ b/LABELS.md @@ -40,7 +40,7 @@ These labels indicate which part of Backstage an issue or pull request relates t - `area:auditor` - Auditor service and it's use in plugins. - `area:auth` - Authentication and 3rd party authorization. - `area:catalog` - The Catalog plugin and the Software Catalog model and integrations. -- `area:design-system` - The Canon design system and library. +- `area:design-system` - The Backstage UI design system and library. - `area:documentation` - Documentation for adopters, users, and developers. - `area:events` - The Events system and integrations for other plugins. - `area:framework` - The core Backstage framework. diff --git a/packages/canon/.eslintrc.js b/packages/canon/.eslintrc.js deleted file mode 100644 index 9638ff6e45..0000000000 --- a/packages/canon/.eslintrc.js +++ /dev/null @@ -1,9 +0,0 @@ -module.exports = { - ...require('@backstage/cli/config/eslint-factory')(__dirname), - extends: ['plugin:storybook/recommended'], - rules: { - 'react/forbid-elements': 'off', - '@backstage/no-mixed-plugin-imports': 'off' - }, -}; - diff --git a/packages/canon/.gitignore b/packages/canon/.gitignore deleted file mode 100644 index dac138d9e0..0000000000 --- a/packages/canon/.gitignore +++ /dev/null @@ -1 +0,0 @@ -css diff --git a/packages/canon/CHANGELOG.md b/packages/canon/CHANGELOG.md deleted file mode 100644 index 6af38b6b55..0000000000 --- a/packages/canon/CHANGELOG.md +++ /dev/null @@ -1,328 +0,0 @@ -# @backstage/canon - -## 0.6.1-next.0 - -### Patch Changes - -- Updated dependencies - - @backstage/ui@0.7.0-next.0 - -## 0.6.0 - -### Minor Changes - -- 1d64db6: **Breaking changes** We are updating our Link component to use React Aria under the hood. To match their API we are updating the `to` prop to `href` to match both internal and external routing. We are also updating our variant naming to include all our new font sizes. -- 83fd7f4: **Breaking change** We are moving the Select component to use React Aria under the hood. We updated most props and events according to their underlying API. -- cae63df: **Breaking changes** The Tabs components has been updates to use React Aria under the hood and to work with react-router-dom directly. -- 4c6d891: **BREAKING CHANGES** - - We’re updating our Button component to provide better support for button links. - - - We’re introducing a new `ButtonLink` component, which replaces the previous render prop pattern. - - To maintain naming consistency across components, `IconButton` is being renamed to `ButtonIcon`. - - Additionally, the render prop will be removed from all button-related components. - - These changes aim to simplify usage and improve clarity in our component API. - -- 2e30459: We are moving our Tooltip component to use React Aria under the hood. In doing so, the structure of the component and its prop are changing to follow the new underlying structure. -- 8fd6fcb: We are renaming @backstage/canon into @backstage/ui. As part of this move we are renaming all class names and CSS variables to follow the new name. "--canon" prefix is becoming "--bui" and all component class names starting with ".canon" will now start with ".bui" - -### Patch Changes - -- 140f652: We are consolidating all css files into a single styles.css in Canon. -- 76255b8: Add new Card component to Canon. -- 8154fb9: Add new SearchField component in Canon -- b0a6c8e: Add new Header component to Canon. -- 6910892: Add new `RadioGroup` + `Radio` component to Canon -- 9c17305: Fix scrolling width and height on ScrollArea component in Canon. -- 390ea20: Export Card and Skeleton components. -- be76576: Improve Button, ButtonIcon and ButtonLink styling in Canon. -- 17beb9b: Update return types for Heading & Text components for React 19. -- a8a8514: We are transforming how we structure our class names and data attributes definitions for all components. They are now all set in the same place. -- 667b951: Added placeholder prop to TextField component. -- eac4a4c: Add new tertiary variant to Button, ButtonIcon and ButtonLink in Canon. -- e71333a: adding export for ButtonLink so it's importable -- 8f2e82d: Add new Skeleton component in Canon -- Updated dependencies - - @backstage/ui@0.6.0 - -## 0.6.0-next.1 - -### Minor Changes - -- 2e30459: We are moving our Tooltip component to use React Aria under the hood. In doing so, the structure of the component and its prop are changing to follow the new underlying structure. - -### Patch Changes - -- 76255b8: Add new Card component to Canon. -- b0a6c8e: Add new Header component to Canon. -- be76576: Improve Button, ButtonIcon and ButtonLink styling in Canon. -- 17beb9b: Update return types for Heading & Text components for React 19. -- eac4a4c: Add new tertiary variant to Button, ButtonIcon and ButtonLink in Canon. -- 8f2e82d: Add new Skeleton component in Canon - -## 0.6.0-next.0 - -### Minor Changes - -- 4c6d891: **BREAKING CHANGES** - - We’re updating our Button component to provide better support for button links. - - - We’re introducing a new `ButtonLink` component, which replaces the previous render prop pattern. - - To maintain naming consistency across components, `IconButton` is being renamed to `ButtonIcon`. - - Additionally, the render prop will be removed from all button-related components. - - These changes aim to simplify usage and improve clarity in our component API. - -### Patch Changes - -- 140f652: We are consolidating all css files into a single styles.css in Canon. -- 8154fb9: Add new SearchField component in Canon -- 6910892: Add new `RadioGroup` + `Radio` component to Canon -- a8a8514: We are transforming how we structure our class names and data attributes definitions for all components. They are now all set in the same place. -- 667b951: Added placeholder prop to TextField component. -- e71333a: adding export for ButtonLink so it's importable - -## 0.5.0 - -### Minor Changes - -- 621fac9: We are updating the default size of the Button component in Canon to be small instead of medium. -- a842554: We set the default size for IconButton in Canon to be small instead of medium. -- 35fd51d: Move TextField component to use react Aria under the hood. Introducing a new FieldLabel component to help build custom fields. -- 78204a2: **Breaking** We are adding a new as prop on the Heading and Text component to make it easier to change the component tag. We are removing the render prop in favour of the as prop. -- c49e335: TextField in Canon now has multiple label sizes as well as the capacity to hide label and description but still make them available for screen readers. -- 24b45ef: Fixes spacing props on layout components and aligned on naming for the Grid component. You should now call the Grid root component using instead of just . - -### Patch Changes - -- 44df879: Add min-width: 0; by default on every Flex components in Canon to help support truncated texts inside flex elements. -- ee6ffe6: Fix styling for the title4 prop on the Heading component in Canon. -- f2f814a: Added a render prop to the Button component in Canon to use it as a link. -- 98f02a6: Add new Switch component in Canon. -- c94f8e0: The filter input in menu comboboxes should now always use the full width of the menu it's in. -- 269316d: Remove leftover console.log from Container component. - -## 0.5.0-next.2 - -### Patch Changes - -- 44df879: Add min-width: 0; by default on every Flex components in Canon to help support truncated texts inside flex elements. -- ee6ffe6: Fix styling for the title4 prop on the Heading component in Canon. -- f2f814a: Added a render prop to the Button component in Canon to use it as a link. - -## 0.5.0-next.1 - -### Minor Changes - -- 621fac9: We are updating the default size of the Button component in Canon to be small instead of medium. -- a842554: We set the default size for IconButton in Canon to be small instead of medium. - -## 0.5.0-next.0 - -### Minor Changes - -- 24b45ef: Fixes spacing props on layout components and aligned on naming for the Grid component. You should now call the Grid root component using instead of just . - -### Patch Changes - -- 269316d: Remove leftover console.log from Container component. - -## 0.4.0 - -### Minor Changes - -- ea36f74: **Breaking Change** Icons on Button and IconButton now need to be imported and placed like this: