From 12608f8ba87f1b74b292779725bc9e09dea90fbc Mon Sep 17 00:00:00 2001 From: Johan Haals Date: Wed, 13 Apr 2022 16:54:40 +0200 Subject: [PATCH] Ignore node & react from dependency check MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Patrik Oldsberg Co-authored-by: blam Co-authored-by: Fredrik Adelöw Signed-off-by: Johan Haals --- .changeset/wet-buttons-dress.md | 5 +++++ packages/backend-common/package.json | 1 + scripts/check-type-dependencies.js | 4 +++- 3 files changed, 9 insertions(+), 1 deletion(-) create mode 100644 .changeset/wet-buttons-dress.md diff --git a/.changeset/wet-buttons-dress.md b/.changeset/wet-buttons-dress.md new file mode 100644 index 0000000000..3852116215 --- /dev/null +++ b/.changeset/wet-buttons-dress.md @@ -0,0 +1,5 @@ +--- +'@backstage/backend-common': patch +--- + +Add `@types/webpack-env` to dependencies. diff --git a/packages/backend-common/package.json b/packages/backend-common/package.json index 2232411318..9e621ba92d 100644 --- a/packages/backend-common/package.json +++ b/packages/backend-common/package.json @@ -47,6 +47,7 @@ "@types/dockerode": "^3.3.0", "@types/express": "^4.17.6", "@types/luxon": "^2.0.4", + "@types/webpack-env": "^1.15.2", "archiver": "^5.0.2", "aws-sdk": "^2.840.0", "compression": "^1.7.4", diff --git a/scripts/check-type-dependencies.js b/scripts/check-type-dependencies.js index f773e91293..4374e36ae6 100755 --- a/scripts/check-type-dependencies.js +++ b/scripts/check-type-dependencies.js @@ -79,7 +79,9 @@ function findAllDeps(declSrc) { .filter(n => !n.startsWith('.')); const referencedDeps = (declSrc.match(/types=".*"/g) || []) .map(match => match.replace(/types="(.*)"/, '$1')) - .filter(n => !n.startsWith('.')); + .filter(n => !n.startsWith('.')) + // We allow references to these without an explicit dependency. + .filter(n => !['node', 'react'].includes(n)); return Array.from(new Set([...importedDeps, ...referencedDeps])); }