cli: use new eslint plugin + fix issues

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>

scripts/assemble-manifest.js

@@ -1,5 +1,5 @@
 #!/usr/bin/env node
-/* eslint-disable import/no-extraneous-dependencies */
+/* eslint-disable @backstage/no-undeclared-imports */
 /*
  * Copyright 2022 The Backstage Authors
  *

scripts/check-docs-quality.js

@@ -56,7 +56,7 @@ async function listFiles(dir = '') {
 // caused by the script. In CI, we want to ensure vale linter is run.
 async function exitIfMissingVale() {
   try {
-    // eslint-disable-next-line import/no-extraneous-dependencies
+    // eslint-disable-next-line @backstage/no-undeclared-imports
     await require('command-exists')('vale');
   } catch (e) {
     if (process.env.CI) {

scripts/check-if-release.js

@@ -1,5 +1,5 @@
 #!/usr/bin/env node
-/* eslint-disable import/no-extraneous-dependencies */
+/* eslint-disable @backstage/no-undeclared-imports */
 /*
  * Copyright 2020 The Backstage Authors
  *

scripts/create-github-release.js

@@ -1,5 +1,5 @@
 #!/usr/bin/env node
-/* eslint-disable import/no-extraneous-dependencies */
+/* eslint-disable @backstage/no-undeclared-imports */
 /*
  * Copyright 2020 The Backstage Authors
  *

scripts/create-release-tag.js

@@ -1,5 +1,5 @@
 #!/usr/bin/env node
-/* eslint-disable import/no-extraneous-dependencies */
+/* eslint-disable @backstage/no-undeclared-imports */
 /*
  * Copyright 2020 The Backstage Authors
  *

scripts/list-deprecations.js

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-/* eslint-disable import/no-extraneous-dependencies */
+/* eslint-disable @backstage/no-undeclared-imports */
 
 const _ = require('lodash');
 const fs = require('fs-extra');

scripts/prepare-release.js

@@ -1,5 +1,5 @@
 #!/usr/bin/env node
-/* eslint-disable import/no-extraneous-dependencies */
+/* eslint-disable @backstage/no-undeclared-imports */
 /*
  * Copyright 2022 The Backstage Authors
  *

scripts/snyk-github-issue-sync.ts

@@ -14,7 +14,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-/* eslint-disable import/no-extraneous-dependencies */
+/* eslint-disable @backstage/no-undeclared-imports */
 import { Octokit } from '@octokit/rest';
 import minimist from 'minimist';
 // Generated by GitHub workflow .github/workflows/snyk-github-issue-creator

scripts/verify-api-reference.js

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-/* eslint-disable import/no-extraneous-dependencies */
+/* eslint-disable @backstage/no-undeclared-imports */
 
 const { resolve: resolvePath } = require('path');
 const { promises: fs } = require('fs');

scripts/verify-changesets.js

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-/* eslint-disable import/no-extraneous-dependencies */
+/* eslint-disable @backstage/no-undeclared-imports */
 
 const { resolve: resolvePath } = require('path');
 const fs = require('fs-extra');

scripts/verify-links.js

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-/* eslint-disable import/no-extraneous-dependencies */
+/* eslint-disable @backstage/no-undeclared-imports */
 
 const { resolve: resolvePath, join: joinPath, dirname } = require('path');
 const fs = require('fs').promises;

scripts/verify-lockfile-duplicates.js

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-/* eslint-disable import/no-extraneous-dependencies */
+/* eslint-disable @backstage/no-undeclared-imports */
 
 const { execFile: execFileCb } = require('child_process');
 const { resolve: resolvePath, dirname: dirnamePath } = require('path');