cli: use new eslint plugin + fix issues

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>

packages/e2e-test/.eslintrc.js

@@ -1,14 +1 @@
-module.exports = require('@backstage/cli/config/eslint-factory')(__dirname, {
-  rules: {
-    'no-console': 0,
-    'import/no-extraneous-dependencies': [
-      'error',
-      {
-        devDependencies: true,
-        optionalDependencies: false,
-        peerDependencies: false,
-        bundledDependencies: false,
-      },
-    ],
-  },
-});
+module.exports = require('@backstage/cli/config/eslint-factory')(__dirname);

packages/e2e-test/package.json

@@ -26,22 +26,24 @@
     "clean": "backstage-cli package clean"
   },
   "bin": "bin/e2e-test",
-  "devDependencies": {
-    "@backstage/cli": "workspace:^",
+  "dependencies": {
     "@backstage/cli-common": "workspace:^",
     "@backstage/errors": "workspace:^",
-    "@types/fs-extra": "^9.0.1",
-    "@types/node": "^16.11.26",
-    "@types/puppeteer": "^5.4.4",
     "chalk": "^4.0.0",
     "commander": "^9.1.0",
     "cross-fetch": "^3.1.5",
     "fs-extra": "10.1.0",
     "handlebars": "^4.7.3",
-    "nodemon": "^2.0.2",
     "pgtools": "^0.3.0",
     "puppeteer": "^17.0.0",
-    "tree-kill": "^1.2.2",
+    "tree-kill": "^1.2.2"
+  },
+  "devDependencies": {
+    "@backstage/cli": "workspace:^",
+    "@types/fs-extra": "^9.0.1",
+    "@types/node": "^16.11.26",
+    "@types/puppeteer": "^5.4.4",
+    "nodemon": "^2.0.2",
     "ts-node": "^10.0.0"
   },
   "nodemonConfig": {

packages/e2e-test/src/commands/run.ts

@@ -159,7 +159,7 @@ async function buildDistWorkspace(workspaceName: string, rootDir: string) {
     appendDeps(pkg);
   }
 
-  // eslint-disable-next-line import/no-extraneous-dependencies
+  // eslint-disable-next-line @backstage/no-forbidden-package-imports
   appendDeps(require('@backstage/create-app/package.json'));
 
   print(`Preparing workspace`);