From 11242ac41ebf3566caa5f81da5a214a5631bc60e Mon Sep 17 00:00:00 2001 From: Himanshu Mishra Date: Fri, 12 Mar 2021 08:54:26 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Adam Harvey Signed-off-by: Himanshu Mishra --- .changeset/techdocs-eleven-planes-teach.md | 2 +- plugins/techdocs-backend/src/DocsBuilder/builder.ts | 2 +- plugins/techdocs-backend/src/service/router.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.changeset/techdocs-eleven-planes-teach.md b/.changeset/techdocs-eleven-planes-teach.md index 9dd163cb3e..2cc4e42175 100644 --- a/.changeset/techdocs-eleven-planes-teach.md +++ b/.changeset/techdocs-eleven-planes-teach.md @@ -12,4 +12,4 @@ Improvements New feature -1. You can now use a mix of basic and recommended setup i.e. techdocs.builder is `'local'` but using an external cloud storage instead of local storage. Previously, in this setup, the docs would never get updated. +1. You can now use a mix of basic and recommended setup i.e. `techdocs.builder` is `'local'` but using an external cloud storage instead of local storage. Previously, in this setup, the docs would never get updated. diff --git a/plugins/techdocs-backend/src/DocsBuilder/builder.ts b/plugins/techdocs-backend/src/DocsBuilder/builder.ts index 5564b7da45..8c632fc6b0 100644 --- a/plugins/techdocs-backend/src/DocsBuilder/builder.ts +++ b/plugins/techdocs-backend/src/DocsBuilder/builder.ts @@ -86,7 +86,7 @@ export class DocsBuilder { ); // If available, use the etag stored in techdocs_metadata.json to - // check if docs are outdated and needs to be regenerated. + // check if docs are outdated and need to be regenerated. let storedEtag: string | undefined; if (await this.publisher.hasDocsBeenGenerated(this.entity)) { storedEtag = ( diff --git a/plugins/techdocs-backend/src/service/router.ts b/plugins/techdocs-backend/src/service/router.ts index 640812db8a..bcf57bfb0d 100644 --- a/plugins/techdocs-backend/src/service/router.ts +++ b/plugins/techdocs-backend/src/service/router.ts @@ -180,7 +180,7 @@ export async function createRouter({ ); res.status(408).json({ error: - 'Sorry! It is taking longer for the generated docs to show up in storage. Check back later.', + 'Sorry! It took too long for the generated docs to show up in storage. Check back later.', }); return; }