From 110014318d72766b597136229e4679ea213f46b3 Mon Sep 17 00:00:00 2001
From: Niklas Granander <ngranander@spotify.com>
Date: Mon, 5 Jul 2021 11:24:01 +0200
Subject: [PATCH] Extract BuildStatus to a type

Signed-off-by: Niklas Granander <ngranander@spotify.com>
---
 plugins/xcmetrics/src/api/types.ts                         | 4 +++-
 .../src/components/OverviewComponent/OverviewComponent.tsx | 7 ++-----
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/plugins/xcmetrics/src/api/types.ts b/plugins/xcmetrics/src/api/types.ts
index 51af93cd43..5df05f0375 100644
--- a/plugins/xcmetrics/src/api/types.ts
+++ b/plugins/xcmetrics/src/api/types.ts
@@ -16,6 +16,8 @@
 
 import { createApiRef } from '@backstage/core-plugin-api';
 
+export type BuildStatus = 'succeeded' | 'failed' | 'stopped';
+
 export type BuildItem = {
   userid: string;
   warningCount: number;
@@ -32,7 +34,7 @@ export type BuildItem = {
   compilationEndTimestampMicroseconds: number;
   errorCount: number;
   id: string;
-  buildStatus: 'succeeded' | 'failed' | 'stopped';
+  buildStatus: BuildStatus;
   compilationDuration: number;
   schema: string;
   compiledCount: number;
diff --git a/plugins/xcmetrics/src/components/OverviewComponent/OverviewComponent.tsx b/plugins/xcmetrics/src/components/OverviewComponent/OverviewComponent.tsx
index c582ddc943..bd923aa91a 100644
--- a/plugins/xcmetrics/src/components/OverviewComponent/OverviewComponent.tsx
+++ b/plugins/xcmetrics/src/components/OverviewComponent/OverviewComponent.tsx
@@ -26,16 +26,13 @@ import {
   EmptyState,
 } from '@backstage/core-components';
 import { useApi } from '@backstage/core-plugin-api';
-import { BuildItem, xcmetricsApiRef } from '../../api';
+import { BuildItem, BuildStatus, xcmetricsApiRef } from '../../api';
 import { useAsync } from 'react-use';
 import { Alert } from '@material-ui/lab';
 import { Duration } from 'luxon';
 import { Chip } from '@material-ui/core';
 
-const formatStatus = (
-  status: 'succeeded' | 'failed' | 'stopped',
-  warningCount: number,
-) => {
+const formatStatus = (status: BuildStatus, warningCount: number) => {
   const statusIcons = {
     succeeded: <StatusOK />,
     failed: <StatusError />,