From 10a7102f4c48604597db02f4b0f1f6c9ace3f7e8 Mon Sep 17 00:00:00 2001 From: Bilawal Hameed Date: Thu, 26 Mar 2020 13:12:17 +0100 Subject: [PATCH] [core/api/app] Set FeatureFlags class to static --- packages/core/src/api/app/FeatureFlags.tsx | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/core/src/api/app/FeatureFlags.tsx b/packages/core/src/api/app/FeatureFlags.tsx index 31a3c37341..c75e072149 100644 --- a/packages/core/src/api/app/FeatureFlags.tsx +++ b/packages/core/src/api/app/FeatureFlags.tsx @@ -21,9 +21,9 @@ import { FeatureFlagsApi } from '../apis/definitions/featureFlags'; // TODO: figure out where to put implementations of APIs, both inside apps // but also in core/separate package. export class FeatureFlags implements FeatureFlagsApi { - private readonly localStorageKey = 'featureFlags'; + private static readonly localStorageKey = 'featureFlags'; - private getEnabledFeatureFlags(): Set { + private static getEnabledFeatureFlags(): Set { if (!('localStorage' in window)) { throw new Error( 'Feature Flags are not supported on browsers without the Local Storage API', @@ -40,7 +40,7 @@ export class FeatureFlags implements FeatureFlagsApi { } } - private saveFeatureFlags(flags: Set): void { + private static saveFeatureFlags(flags: Set): void { if (!('localStorage' in window)) { throw new Error( 'Feature Flags are not supported on browsers without the Local Storage API', @@ -55,17 +55,17 @@ export class FeatureFlags implements FeatureFlagsApi { ); } - getItem(name: FeatureFlagName): boolean { + static getItem(name: FeatureFlagName): boolean { return this.getFeatureFlags().has(name); } - enable(name: FeatureFlagName): void { + static enable(name: FeatureFlagName): void { const flags = this.getFeatureFlags(); flags.add(name); this.saveFeatureFlags(flags); } - disable(name: FeatureFlagName): void { + static disable(name: FeatureFlagName): void { const flags = this.getFeatureFlags(); flags.delete(name); this.saveFeatureFlags(flags);