From 108728f5fea1e33bf1a2380ddaa7a6353d4ee9ef Mon Sep 17 00:00:00 2001
From: Vincenzo Scamporlino <vincenzos@spotify.com>
Date: Thu, 10 Aug 2023 23:57:32 +0200
Subject: [PATCH] backend-app-api: add add method to ServiceRegistry

Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
---
 packages/backend-app-api/src/wiring/ServiceRegistry.ts | 9 ++++++++-
 packages/backend-app-api/src/wiring/types.ts           | 2 ++
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/packages/backend-app-api/src/wiring/ServiceRegistry.ts b/packages/backend-app-api/src/wiring/ServiceRegistry.ts
index 61f95ff4a4..25d777549c 100644
--- a/packages/backend-app-api/src/wiring/ServiceRegistry.ts
+++ b/packages/backend-app-api/src/wiring/ServiceRegistry.ts
@@ -39,7 +39,7 @@ function toInternalServiceFactory<TService, TScope extends 'plugin' | 'root'>(
   factory: ServiceFactory<TService, TScope>,
 ): InternalServiceFactory<TService, TScope> {
   const f = factory as InternalServiceFactory<TService, TScope>;
-  if (f.$$type !== '@backstage/ServiceFactory') {
+  if (f.$$type !== '@backstage/BackendFeature') {
     throw new Error(`Invalid service factory, bad type '${f.$$type}'`);
   }
   if (f.version !== 'v1') {
@@ -82,6 +82,13 @@ export class ServiceRegistry implements EnumerableServiceHolder {
     this.#implementations = new Map();
   }
 
+  add(serviceFactory: ServiceFactory) {
+    this.#providedFactories.set(
+      serviceFactory.service.id,
+      toInternalServiceFactory(serviceFactory),
+    );
+  }
+
   #resolveFactory(
     ref: ServiceRef<unknown>,
     pluginId: string,
diff --git a/packages/backend-app-api/src/wiring/types.ts b/packages/backend-app-api/src/wiring/types.ts
index 36e2dede30..e2cc299541 100644
--- a/packages/backend-app-api/src/wiring/types.ts
+++ b/packages/backend-app-api/src/wiring/types.ts
@@ -19,6 +19,7 @@ import {
   ExtensionPoint,
   ServiceRef,
   ServiceFactoryOrFunction,
+  ServiceFactory,
 } from '@backstage/backend-plugin-api';
 
 /**
@@ -39,6 +40,7 @@ export interface CreateSpecializedBackendOptions {
 
 export interface ServiceHolder {
   get<T>(api: ServiceRef<T>, pluginId: string): Promise<T> | undefined;
+  add(serviceFactory: ServiceFactory): void;
 }
 
 /**