From fe20e6f4a8fa3bb990ca186188a28e70283a1105 Mon Sep 17 00:00:00 2001 From: Gauthier Date: Tue, 16 Nov 2021 17:18:40 +0800 Subject: [PATCH 1/4] Update Kafka configuration types According to https://nodejs.org/dist/latest-v8.x/docs/api/tls.html#tls_tls_createsecurecontext_options the `ssl` options `ca`, `key`, and `cert` are all optional. In my case, i need to pass `rejectUnauthorized`, but I can't do so as the backend expects a `key`. Passing an empty string works, but everything becomes redacted in my log because of that. Signed-off-by: Gauthier Roebroeck --- plugins/kafka-backend/config.d.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/plugins/kafka-backend/config.d.ts b/plugins/kafka-backend/config.d.ts index ee29560809..1417c1fe63 100644 --- a/plugins/kafka-backend/config.d.ts +++ b/plugins/kafka-backend/config.d.ts @@ -33,8 +33,9 @@ export interface Config { | { ca: string[]; /** @visibility secret */ - key: string; + key?: string; cert: string; + rejectUnauthorized?: boolean; } | boolean; /** From f4fe544f73230f142fcaf84531f49b86f77b3e58 Mon Sep 17 00:00:00 2001 From: Gauthier Date: Tue, 16 Nov 2021 17:45:35 +0800 Subject: [PATCH 2/4] Update config.d.ts Signed-off-by: Gauthier Roebroeck --- plugins/kafka-backend/config.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/kafka-backend/config.d.ts b/plugins/kafka-backend/config.d.ts index 1417c1fe63..3e7c196bd7 100644 --- a/plugins/kafka-backend/config.d.ts +++ b/plugins/kafka-backend/config.d.ts @@ -31,10 +31,10 @@ export interface Config { */ ssl?: | { - ca: string[]; + ca?: string[]; /** @visibility secret */ key?: string; - cert: string; + cert?: string; rejectUnauthorized?: boolean; } | boolean; From 9145449220cded4a633fb339d0d9dfec880eea12 Mon Sep 17 00:00:00 2001 From: Gauthier Date: Tue, 16 Nov 2021 19:11:46 +0800 Subject: [PATCH 3/4] Create fresh-zebras-hug.md Signed-off-by: Gauthier Roebroeck --- .changeset/fresh-zebras-hug.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changeset/fresh-zebras-hug.md diff --git a/.changeset/fresh-zebras-hug.md b/.changeset/fresh-zebras-hug.md new file mode 100644 index 0000000000..b18c6acdfc --- /dev/null +++ b/.changeset/fresh-zebras-hug.md @@ -0,0 +1,6 @@ +--- +"@backstage/plugin-kafka-backend": patch +"@backstage/plugin-kafka": patch +--- + +Update Kafka configuration types From f8db7c3988e3424660e1f1428e0ef5e76d6c75d3 Mon Sep 17 00:00:00 2001 From: Gauthier Roebroeck Date: Wed, 17 Nov 2021 09:42:36 +0800 Subject: [PATCH 4/4] remove untouched package from changeset Signed-off-by: Gauthier Roebroeck --- .changeset/fresh-zebras-hug.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.changeset/fresh-zebras-hug.md b/.changeset/fresh-zebras-hug.md index b18c6acdfc..c295dc2287 100644 --- a/.changeset/fresh-zebras-hug.md +++ b/.changeset/fresh-zebras-hug.md @@ -1,6 +1,5 @@ --- -"@backstage/plugin-kafka-backend": patch -"@backstage/plugin-kafka": patch +'@backstage/plugin-kafka-backend': patch --- Update Kafka configuration types